liuzhangxing

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

9d1d25cd75 ZOOKEEPER-4940: Enabling zookeeper.ssl.ocsp with JRE TLS provider errors out add docs add new property for tcnative OCSP setting rename property factor out the stapling handling code to a new method use and honor OpenSSL.isOcspSupported() Add more log messages Remove comments about BoringSSL not supporting OCSP stapling rearrange code to make patch smaller add comment for clarification remove new property Reviewers: anmolnar Author: stoty Closes #2270 from stoty/ZOOKEEPER-4940

5 månader sedan

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

6c5f788ee3 ZOOKEEPER-4943: Use Duration for session timeout in ZooKeeperBuilder ZOOKEEPER-4943: Use Duration for session timeout in ZooKeeperBuilder `ZooKeeperBuilder` is introduced in ZOOKEEPER-4697 which targets 3.10.0, so this api change breaks nothing. Refs: ZOOKEEPER-4697, ZOOKEEPER-4943 Author: kezhuw Closes #2274 from kezhuw/ZOOKEEPER-4943-ZooKeeperBuilder-Duration-timeout
02e93c2554 ZOOKEEPER-4944: Cache zookeeper dists in compatibility tests Reviewers: cnauroth Author: kezhuw Closes #2273 from kezhuw/ZOOKEEPER-4944-cache-zookeeper-dists
View comparison for these 2 commits »

5 månader sedan

liuzhangxing synced commits to branch-3.9 at liuzhangxing/zookeeper from mirror

a846a51788 ZOOKEEPER-4944: Cache zookeeper dists in compatibility tests Reviewers: cnauroth Author: kezhuw Closes #2273 from kezhuw/ZOOKEEPER-4944-cache-zookeeper-dists (cherry picked from commit 02e93c2554317683bb2bdd6fc242f881937d90d6) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

5 månader sedan

liuzhangxing synced commits to branch-3.8 at liuzhangxing/zookeeper from mirror

b9b1616aa0 ZOOKEEPER-4944: Cache zookeeper dists in compatibility tests Reviewers: cnauroth Author: kezhuw Closes #2273 from kezhuw/ZOOKEEPER-4944-cache-zookeeper-dists (cherry picked from commit 02e93c2554317683bb2bdd6fc242f881937d90d6) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

5 månader sedan

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

5b4be58c30 ZOOKEEPER-4921: Retry endlessly to establish a brand-new session Reviewers: tisonkun Author: kezhuw Closes #2252 from kezhuw/ZOOKEEPER-4921-retry-brand-new-session-endlessly This is cherry picked from commit 0971e5e2133f535bb39c5a363dcf0046b64d4a36 which is already merged to branch-3.9, this way we make ZOOKEEPER-4923 a pure feature request. Signed-off-by: Kezhu Wang <kezhuw@apache.org>
f6766eca95 ZOOKEEPER-4810: Fix buf data race at format_endpoint_info ZOOKEEPER-4810: Fix buf data race at format_endpoint_info() format_endpoint_info() is widely called in the IO thread. And the some ZOOAPIs will call this method too: zoo_cycle_next_server() and zoo_get_current_server(). These APIs return the same static buffer read/write by IO thread causes data race. Reviewers: kezhuw Author: fanyang89 Closes #2140 from fanyang89/fix-c-client-format-endpoint-race
1ebd57b270 ZOOKEEPER-4556: Add zoo_version_str to return ZOO_VERSION for runtime library ZOOKEEPER-4556: Add zoo_version_str to return ZOO_VERSION for runtime library This method allows a calling program to determine at runtime whether the version of the dynamically loaded zookeeper library (a.k.a. zoo_version_str()) is same as the version of the library the calling program was compiled against (a.k.a. ZOO_VERSION). Reviewers: eolivelli, kezhuw Author: gjcarrette Closes #1893 from gjcarrette/fix/ZOOKEEPER-4556
View comparison for these 3 commits »

5 månader sedan

liuzhangxing synced commits to branch-3.9 at liuzhangxing/zookeeper from mirror

d2ef1dff82 ZOOKEEPER-4810: Fix buf data race at format_endpoint_info ZOOKEEPER-4810: Fix buf data race at format_endpoint_info() format_endpoint_info() is widely called in the IO thread. And the some ZOOAPIs will call this method too: zoo_cycle_next_server() and zoo_get_current_server(). These APIs return the same static buffer read/write by IO thread causes data race. Reviewers: kezhuw Author: fanyang89 Closes #2140 from fanyang89/fix-c-client-format-endpoint-race (cherry picked from commit f6766eca95b318e6e675a97be029b2eb2397dd0d) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

5 månader sedan

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

35744f3aa8 ZOOKEEPER-4930: Add metrics for TTL node deletion (#2261) Author: Li Wang <liwang@apple.com> Co-authored-by: liwang <liwang@apple.com>

6 månader sedan

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

4e7b8a3d81 ZOOKEEPER-4604: Fix missing break in switch branch COMPLETION_STRING_STAT ZOOKEEPER-4604: Creating a COMPLETION_STRING_STAT overrides acl_result completion c->c is a union so setting c.acl_result would override c.string_stat_result. However, since they're all function pointers pointing to the same function, this won't cause any issue as c.string_stat_result is still correct. This might cause issue if we change the type of these completions in the future. Reviewers: kezhuw Author: adamyi Closes #1912 from adamyi/ZOOKEEPER-4604

6 månader sedan

liuzhangxing synced commits to branch-3.9 at liuzhangxing/zookeeper from mirror

1622b8516f ZOOKEEPER-4604: Fix missing break in switch branch COMPLETION_STRING_STAT ZOOKEEPER-4604: Creating a COMPLETION_STRING_STAT overrides acl_result completion c->c is a union so setting c.acl_result would override c.string_stat_result. However, since they're all function pointers pointing to the same function, this won't cause any issue as c.string_stat_result is still correct. This might cause issue if we change the type of these completions in the future. Reviewers: kezhuw Author: adamyi Closes #1912 from adamyi/ZOOKEEPER-4604 (cherry picked from commit 4e7b8a3d81a797b986ae3b7759f9c582e5d55691) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

6 månader sedan

liuzhangxing synced commits to branch-3.8 at liuzhangxing/zookeeper from mirror

1ad8de220b ZOOKEEPER-4604: Fix missing break in switch branch COMPLETION_STRING_STAT ZOOKEEPER-4604: Creating a COMPLETION_STRING_STAT overrides acl_result completion c->c is a union so setting c.acl_result would override c.string_stat_result. However, since they're all function pointers pointing to the same function, this won't cause any issue as c.string_stat_result is still correct. This might cause issue if we change the type of these completions in the future. Reviewers: kezhuw Author: adamyi Closes #1912 from adamyi/ZOOKEEPER-4604 (cherry picked from commit 4e7b8a3d81a797b986ae3b7759f9c582e5d55691) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

6 månader sedan

liuzhangxing synced commits to branch-3.9.4 at liuzhangxing/zookeeper from mirror

3112398922 ZOOKEEPER-4921: Retry endlessly to establish a brand-new session (#2265) This partially rollback ZOOKEEPER-4508 to keep consistent with versions prior to 3.9.3 (excluded), so to maintain compatibility with third party libraries. Refs: ZOOKEEPER-4508, ZOOKEEPER-4921, ZOOKEEPER-4923 and https://lists.apache.org/thread/nfb9z7rhgglbjzfxvg4z2m3pks53b3c1

6 månader sedan

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

e5dd60bf05 ZOOKEEPER-4925: Fix data loss due to propagation of discontinuous committedLog (#2254) There are two variants of `ZooKeeperServer::processTxn`. Those two variants diverge significantly since ZOOKEEPER-3484. `processTxn(Request request)` pops outstanding change from `outstandingChanges` and adds txn to `committedLog` for follower to sync in addition to what `processTxn(TxnHeader hdr, Record txn)` does. The `Learner` uses `processTxn(TxnHeader hdr, Record txn)` to commit txn to memory after ZOOKEEPER-4394, which means it leaves `committedLog` untouched in `SYNCHRONIZATION` phase. This way, a stale follower will have hole in its `committedLog` after joining cluster. The stale follower will propagate the in memory hole to other stale nodes after becoming leader. This causes data loss. The test case fails on master and 3.9.3, and passes on 3.9.2. So only 3.9.3 is affected. This commit drops `processTxn(TxnHeader hdr, Record txn)` as `processTxn(Request request)` is capable in `SYNCHRONIZATION` phase too. Also, this commit rejects discontinuous proposals in `syncWithLeader` and `committedLog`, so to avoid possible data loss. Refs: ZOOKEEPER-4925, ZOOKEEPER-4394, ZOOKEEPER-3484 Reviewers: li4wang Author: kezhuw Closes #2254 from kezhuw/ZOOKEEPER-4925-fix-data-loss

6 månader sedan

liuzhangxing synced commits to branch-3.9 at liuzhangxing/zookeeper from mirror

685048a7b3 ZOOKEEPER-4925: Fix data loss due to propagation of discontinuous committedLog (#2254) There are two variants of `ZooKeeperServer::processTxn`. Those two variants diverge significantly since ZOOKEEPER-3484. `processTxn(Request request)` pops outstanding change from `outstandingChanges` and adds txn to `committedLog` for follower to sync in addition to what `processTxn(TxnHeader hdr, Record txn)` does. The `Learner` uses `processTxn(TxnHeader hdr, Record txn)` to commit txn to memory after ZOOKEEPER-4394, which means it leaves `committedLog` untouched in `SYNCHRONIZATION` phase. This way, a stale follower will have hole in its `committedLog` after joining cluster. The stale follower will propagate the in memory hole to other stale nodes after becoming leader. This causes data loss. The test case fails on master and 3.9.3, and passes on 3.9.2. So only 3.9.3 is affected. This commit drops `processTxn(TxnHeader hdr, Record txn)` as `processTxn(Request request)` is capable in `SYNCHRONIZATION` phase too. Also, this commit rejects discontinuous proposals in `syncWithLeader` and `committedLog`, so to avoid possible data loss. Refs: ZOOKEEPER-4925, ZOOKEEPER-4394, ZOOKEEPER-3484 Reviewers: li4wang Author: kezhuw Closes #2254 from kezhuw/ZOOKEEPER-4925-fix-data-loss (cherry picked from commit e5dd60bf0512ccc1e090d99410a8da48623219da) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

6 månader sedan

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

524f1d750c Fix client connection rejected due to throttler token overflow Reviewers: kezhuw, tisonkun, li4wang Author: damumu0625 Closes #2264 from damumu0625/ZOOKEEPER-4933

6 månader sedan

liuzhangxing synced commits to branch-3.9 at liuzhangxing/zookeeper from mirror

392abdfa57 Fix client connection rejected due to throttler token overflow Reviewers: kezhuw, tisonkun, li4wang Author: damumu0625 Closes #2264 from damumu0625/ZOOKEEPER-4933 (cherry picked from commit 524f1d750c62920f5fafdb3ee5abf9f69ff54e41) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

6 månader sedan

liuzhangxing synced commits to branch-3.8 at liuzhangxing/zookeeper from mirror

adb8056ae0 Fix client connection rejected due to throttler token overflow Reviewers: kezhuw, tisonkun, li4wang Author: damumu0625 Closes #2264 from damumu0625/ZOOKEEPER-4933 (cherry picked from commit 524f1d750c62920f5fafdb3ee5abf9f69ff54e41) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

6 månader sedan

liuzhangxing synced commits to branch-3.8 at liuzhangxing/zookeeper from mirror

54da69219c ZOOKEEPER-3731: Disable HTTP TRACE Method (branch-3.8) ZOOKEEPER-3731: Disallow HTTP TRACE method on PrometheusMetrics Server (#1682) Author: anmolnar Closes #2262 from anmolnar/ZOOKEEPER-3731_38

6 månader sedan

liuzhangxing synced commits to master at liuzhangxing/zookeeper from mirror

aeadf574c0 ZOOKEEPER-4928: Fix ZOO_VERSION not updated during mvn release:prepare Reviewers: eolivelli, tisonkun Author: kezhuw Closes #2259 from kezhuw/ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release

7 månader sedan

liuzhangxing synced commits to branch-3.9 at liuzhangxing/zookeeper from mirror

adc8744a0f ZOOKEEPER-4928: Fix ZOO_VERSION not updated during mvn release:prepare Reviewers: eolivelli, tisonkun Author: kezhuw Closes #2259 from kezhuw/ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release (cherry picked from commit aeadf574c0463e7e3db092b588033d8347989d4c) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

7 månader sedan

liuzhangxing synced commits to branch-3.8 at liuzhangxing/zookeeper from mirror

56cc908c88 ZOOKEEPER-4928: Fix ZOO_VERSION not updated during mvn release:prepare Reviewers: eolivelli, tisonkun Author: kezhuw Closes #2259 from kezhuw/ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release (cherry picked from commit aeadf574c0463e7e3db092b588033d8347989d4c) Signed-off-by: Kezhu Wang <kezhuw@apache.org>

7 månader sedan