HADOOP-1356. Fix a bug in ValueHistogram. Contributed by Runping.

git-svn-id: https://svn.apache.org/repos/asf/lucene/hadoop/trunk@539089 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -417,6 +417,8 @@ Branch 0.13 (unreleased changes)
 116. HADOOP-1358.  Fix a potential bug when DFSClient calls skipBytes.
      (Hairong Kuang via cutting)
 
+117. HADOOP-1356.  Fix a bug in ValueHistogram.  (Runping Qi via cutting)
+
 
 Release 0.12.3 - 2007-04-06
 

src/java/org/apache/hadoop/mapred/lib/aggregate/ValueHistogram.java

@@ -51,7 +51,7 @@ public class ValueHistogram implements ValueAggregator {
     String valStr = valCountStr;
     String countStr = "1";
     if (pos >= 0) {
-      valCountStr.substring(0, pos);
+      valStr = valCountStr.substring(0, pos);
       countStr = valCountStr.substring(pos + 1);
     }
     

src/test/org/apache/hadoop/mapred/TestAggregates.java

@@ -108,6 +108,8 @@ public class TestAggregates extends TestCase {
     boolean success = true;
     Path outPath = new Path(OUTPUT_DIR, "part-00000");
     String outdata = TestMiniMRWithDFS.readOutput(outPath,job);
+    System.out.println("full out data:");
+    System.out.println(outdata.toString());
     outdata = outdata.substring(0, expectedOutput.toString().length());
 
     assertEquals(expectedOutput.toString(),outdata);