HADOOP-1190. Fix unchecked warnings in conf, examples, filecache, ipc, metrics, net, record, and util packages.

git-svn-id: https://svn.apache.org/repos/asf/lucene/hadoop/trunk@525505 13f79535-47bb-0310-9956-ffa450edef68

src/examples/org/apache/hadoop/examples/Sort.java

@@ -70,7 +70,7 @@ public class Sort {
          jobConf.getInt("test.sort.maps_per_host", 10);
     int num_reduces = cluster.getTaskTrackers() * 
         jobConf.getInt("test.sort.reduces_per_host", cluster.getMaxTasks());
-    List otherArgs = new ArrayList();
+    List<String> otherArgs = new ArrayList<String>();
     for(int i=0; i < args.length; ++i) {
       try {
         if ("-m".equals(args[i])) {

src/examples/org/apache/hadoop/examples/WordCount.java

@@ -114,7 +114,7 @@ public class WordCount {
     conf.setCombinerClass(Reduce.class);
     conf.setReducerClass(Reduce.class);
     
-    List other_args = new ArrayList();
+    List<String> other_args = new ArrayList<String>();
     for(int i=0; i < args.length; ++i) {
       try {
         if ("-m".equals(args[i])) {

src/java/org/apache/hadoop/conf/Configuration.java

@@ -74,8 +74,8 @@ public class Configuration {
     LogFactory.getLog("org.apache.hadoop.conf.Configuration");
 
   private boolean   quietmode = true;
-  private ArrayList defaultResources = new ArrayList();
-  private ArrayList finalResources = new ArrayList();
+  private ArrayList<Object> defaultResources = new ArrayList<Object>();
+  private ArrayList<Object> finalResources = new ArrayList<Object>();
 
   private Properties properties;
   private Properties overlay;
@@ -97,6 +97,7 @@ public class Configuration {
   }
 
   /** A new configuration with the same settings cloned from another. */
+  @SuppressWarnings("unchecked")
   public Configuration(Configuration other) {
     if (LOG.isDebugEnabled()) {
       LOG.debug(StringUtils.stringifyException
@@ -140,7 +141,9 @@ public class Configuration {
     addResource(finalResources, file);
   }
 
-  private synchronized void addResource(ArrayList resources, Object resource) {
+  private synchronized void addResource(ArrayList<Object> resources,
+      Object resource) {
+    
     resources.add(resource);                      // add to resources
     properties = null;                            // trigger reload
   }
@@ -311,14 +314,14 @@ public class Configuration {
    * @return the class object
    * @throws ClassNotFoundException if the class is not found
    */
-  public Class getClassByName(String name) throws ClassNotFoundException {
+  public Class<?> getClassByName(String name) throws ClassNotFoundException {
     return Class.forName(name, true, classLoader);
   }
   
   /** Returns the value of the <code>name</code> property as a Class.  If no
    * such property is specified, then <code>defaultValue</code> is returned.
    */
-  public Class getClass(String name, Class defaultValue) {
+  public Class<?> getClass(String name, Class<?> defaultValue) {
     String valueString = get(name);
     if (valueString == null)
       return defaultValue;
@@ -334,9 +337,11 @@ public class Configuration {
    * An error is thrown if the returned class does not implement the named
    * interface. 
    */
-  public Class getClass(String propertyName, Class defaultValue,Class xface) {
+  public Class<?> getClass(String propertyName, Class<?> defaultValue,
+      Class<?> xface) {
+    
     try {
-      Class theClass = getClass(propertyName, defaultValue);
+      Class<?> theClass = getClass(propertyName, defaultValue);
       if (theClass != null && !xface.isAssignableFrom(theClass))
         throw new RuntimeException(theClass+" not "+xface.getName());
       return theClass;
@@ -348,7 +353,9 @@ public class Configuration {
   /** Sets the value of the <code>name</code> property to the name of a class.
    * First checks that the class implements the named interface. 
    */
-  public void setClass(String propertyName, Class theClass, Class xface) {
+  public void setClass(String propertyName, Class<?> theClass,
+      Class<?> xface) {
+    
     if (!xface.isAssignableFrom(theClass))
       throw new RuntimeException(theClass+" not "+xface.getName());
     set(propertyName, theClass.getName());

src/java/org/apache/hadoop/filecache/DistributedCache.java

@@ -37,7 +37,7 @@ import java.net.URI;
  ******************************************************************************/
 public class DistributedCache {
   // cacheID to cacheStatus mapping
-  private static TreeMap cachedArchives = new TreeMap();
+  private static TreeMap<String, CacheStatus> cachedArchives = new TreeMap<String, CacheStatus>();
   // buffer size for reading checksum files
   private static final int CRC_BUFFER_SIZE = 64 * 1024;
   

src/java/org/apache/hadoop/ipc/Client.java

@@ -61,7 +61,8 @@ public class Client {
   
   public static final Log LOG =
     LogFactory.getLog("org.apache.hadoop.ipc.Client");
-  private Hashtable connections = new Hashtable();
+  private Hashtable<InetSocketAddress, Connection> connections =
+    new Hashtable<InetSocketAddress, Connection>();
 
   private Class valueClass;                       // class of call values
   private int timeout ;// timeout for calls
@@ -121,7 +122,8 @@ public class Client {
     private Socket socket = null;                 // connected socket
     private DataInputStream in;                   
     private DataOutputStream out;
-    private Hashtable calls = new Hashtable();    // currently active calls
+    // currently active calls
+    private Hashtable<Integer, Call> calls = new Hashtable<Integer, Call>();
     private Call readingCall;
     private Call writingCall;
     private int inUse = 0;

src/java/org/apache/hadoop/ipc/Server.java

@@ -134,11 +134,12 @@ public abstract class Server {
   private int maxQueueSize;
 
   volatile private boolean running = true;         // true while server runs
-  private LinkedList callQueue = new LinkedList(); // queued calls
+  private LinkedList<Call> callQueue = new LinkedList<Call>(); // queued calls
 
-  private List connectionList = 
-       Collections.synchronizedList(new LinkedList()); //maintain a list
-                                                       //of client connectionss
+  private List<Connection> connectionList = 
+       Collections.synchronizedList(new LinkedList<Connection>());
+                                                       //maintain a list
+                                                       //of client connections
   private Listener listener = null;
   private int numConnections = 0;
   private Handler[] handlers = null;

src/java/org/apache/hadoop/metrics/file/FileContext.java

@@ -25,7 +25,7 @@ import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
 import java.io.PrintWriter;
-import java.util.Iterator;
+
 import org.apache.hadoop.metrics.ContextFactory;
 import org.apache.hadoop.metrics.MetricsException;
 import org.apache.hadoop.metrics.spi.AbstractMetricsContext;
@@ -126,20 +126,14 @@ public class FileContext extends AbstractMetricsContext {
         writer.print(".");
         writer.print(recordName);
         String separator = ": ";
-        // for (String tagName : outRec.getTagNames()) {
-        Iterator tagIt = outRec.getTagNames().iterator();
-        while (tagIt.hasNext()) {
-            String tagName = (String) tagIt.next();
+        for (String tagName : outRec.getTagNames()) {
             writer.print(separator);
             separator = ", ";
             writer.print(tagName);
             writer.print("=");
             writer.print(outRec.getTag(tagName));
         }
-        // for (String metricName : outRec.getMetricNames()) {
-        Iterator metricIt = outRec.getMetricNames().iterator();
-        while (metricIt.hasNext()) {
-            String metricName = (String) metricIt.next();
+        for (String metricName : outRec.getMetricNames()) {
             writer.print(separator);
             separator = ", ";
             writer.print(metricName);

src/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java

@@ -26,9 +26,9 @@ import java.net.DatagramSocket;
 import java.net.SocketAddress;
 import java.net.SocketException;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+
 import org.apache.hadoop.metrics.ContextFactory;
 import org.apache.hadoop.metrics.MetricsException;
 import org.apache.hadoop.metrics.spi.AbstractMetricsContext;
@@ -55,8 +55,7 @@ public class GangliaContext extends AbstractMetricsContext {
     private static final int DEFAULT_PORT = 8649;
     private static final int BUFFER_SIZE = 1500;       // as per libgmond.c
     
-    //private static final Map<Class,String> typeTable = new HashMap<Class,String>(5);
-    private static final Map typeTable = new HashMap(5);
+    private static final Map<Class,String> typeTable = new HashMap<Class,String>(5);
     
     static {
         typeTable.put(String.class, "string");
@@ -69,16 +68,11 @@ public class GangliaContext extends AbstractMetricsContext {
     private byte[] buffer = new byte[BUFFER_SIZE];
     private int offset;
     
-    //private List<SocketAddress> metricsServers;
-    private List metricsServers;
-    //private Map<String,String> unitsTable;
-    private Map unitsTable;
-    //private Map<String,String> slopeTable;
-    private Map slopeTable;
-    //private Map<String,String> tmaxTable;
-    private Map tmaxTable;
-    //private Map<String,String> dmaxTable;
-    private Map dmaxTable;
+    private List<? extends SocketAddress> metricsServers;
+    private Map<String,String> unitsTable;
+    private Map<String,String> slopeTable;
+    private Map<String,String> tmaxTable;
+    private Map<String,String> dmaxTable;
     
     private DatagramSocket datagramSocket;
     
@@ -125,24 +119,18 @@ public class GangliaContext extends AbstractMetricsContext {
         
         // metric name formed from record name and tag values
         StringBuffer nameBuf = new StringBuffer(recordName);
-        // for (String tagName : outRec.getTagNames()) {
-        Iterator tagIt = outRec.getTagNames().iterator();
-        while (tagIt.hasNext()) {
-            String tagName = (String) tagIt.next();
-            nameBuf.append('.');
-            nameBuf.append(outRec.getTag(tagName));
+        for (String tagName : outRec.getTagNames()) {
+          nameBuf.append('.');
+          nameBuf.append(outRec.getTag(tagName));
         }
         nameBuf.append('.');
         String namePrefix = new String(nameBuf);
         
         // emit each metric in turn
-        // for (String metricName : outRec.getMetricNames()) {
-        Iterator metricIt = outRec.getMetricNames().iterator();
-        while (metricIt.hasNext()) {
-            String metricName = (String) metricIt.next();
-            Object metric = outRec.getMetric(metricName);
-            String type = (String) typeTable.get(metric.getClass());
-            emitMetric(namePrefix + metricName, type, metric.toString());
+        for (String metricName : outRec.getMetricNames()) {
+          Object metric = outRec.getMetric(metricName);
+          String type = (String) typeTable.get(metric.getClass());
+          emitMetric(namePrefix + metricName, type, metric.toString());
         }
         
     }
@@ -165,13 +153,10 @@ public class GangliaContext extends AbstractMetricsContext {
         xdr_int(tmax);
         xdr_int(dmax);
         
-        // for (SocketAddress socketAddress : metricsServers) {
-        Iterator socketIt = metricsServers.iterator();
-        while (socketIt.hasNext()) {
-            SocketAddress socketAddress = (SocketAddress) socketIt.next();
-            DatagramPacket packet = 
-                new DatagramPacket(buffer, offset, socketAddress);
-            datagramSocket.send(packet);
+        for (SocketAddress socketAddress : metricsServers) {
+          DatagramPacket packet = 
+              new DatagramPacket(buffer, offset, socketAddress);
+          datagramSocket.send(packet);
         }
     }
     

src/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java

@@ -25,7 +25,6 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.Map;
 import java.util.Set;
 import java.util.Timer;

src/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java

@@ -33,8 +33,7 @@ import org.apache.hadoop.metrics.spi.AbstractMetricsContext.TagMap;
 public class MetricsRecordImpl implements MetricsRecord {
     
     private TagMap tagTable = new TagMap();
-    //private Map<String,MetricValue> metricTable = new LinkedHashMap<String,MetricValue>();
-    private Map metricTable = new LinkedHashMap();
+    private Map<String,MetricValue> metricTable = new LinkedHashMap<String,MetricValue>();
     
     private String recordName;
     private AbstractMetricsContext context;
@@ -228,8 +227,7 @@ public class MetricsRecordImpl implements MetricsRecord {
         return tagTable;
     }
 
-    //Map<String, MetricValue> getMetricTable() {
-    Map getMetricTable() {
+    Map<String, MetricValue> getMetricTable() {
         return metricTable;
     }
 }

src/java/org/apache/hadoop/metrics/spi/OutputRecord.java

@@ -42,8 +42,7 @@ public class OutputRecord {
     /**
      * Returns the set of tag names
      */
-    //public Set<String> getTagNames() {
-    public Set getTagNames() {
+    public Set<String> getTagNames() {
         return Collections.unmodifiableSet(tagMap.keySet());
     }
     
@@ -59,8 +58,7 @@ public class OutputRecord {
     /**
      * Returns the set of metric names.
      */
-    //public Set<String> getMetricNames() {
-    public Set getMetricNames() {
+    public Set<String> getMetricNames() {
         return Collections.unmodifiableSet(metricMap.keySet());
     }
     

src/java/org/apache/hadoop/metrics/spi/Util.java

@@ -22,6 +22,7 @@
 package org.apache.hadoop.metrics.spi;
 
 import java.net.InetSocketAddress;
+import java.net.SocketAddress;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -42,16 +43,14 @@ public class Util {
      * 
      * @return a list of InetSocketAddress objects.
      */
-    public static List parse(String specs, int defaultPort) {
-        List result = new ArrayList(1); // ArrayList<InetSocketAddress>
+    public static List<InetSocketAddress> parse(String specs, int defaultPort) {
+        List<InetSocketAddress> result = new ArrayList<InetSocketAddress>(1);
         if (specs == null) {
                 result.add(new InetSocketAddress("localhost", defaultPort));
         }
         else {
             String[] specStrings = specs.split("[ ,]+");
-            //for (String specString : specStrings) {
-            for (int i = 0; i < specStrings.length; i++) {
-                String specString = specStrings[i];
+            for (String specString : specStrings) {
                 int colon = specString.indexOf(':');
                 if (colon < 0 || colon == specString.length() - 1) {
                     result.add(new InetSocketAddress(specString, defaultPort));

src/java/org/apache/hadoop/net/DNS.java

@@ -1,6 +1,5 @@
 package org.apache.hadoop.net;
 
-import java.io.IOException;
 import java.net.InetAddress;
 import java.net.NetworkInterface;
 import java.net.SocketException;
@@ -77,7 +76,7 @@ public class DNS {
         return new String[] { InetAddress.getLocalHost()
                               .getHostAddress() };
       else {
-        Vector ips = new Vector();
+        Vector<String> ips = new Vector<String>();
         Enumeration e = netIF.getInetAddresses();
         while (e.hasMoreElements())
           ips.add(((InetAddress) e.nextElement()).getHostAddress());
@@ -119,7 +118,7 @@ public class DNS {
   public static String[] getHosts(String strInterface, String nameserver)
     throws UnknownHostException {
     String[] ips = getIPs(strInterface);
-    Vector hosts = new Vector();
+    Vector<String> hosts = new Vector<String>();
     for (int ctr = 0; ctr < ips.length; ctr++)
       try {
         hosts.add(reverseDns(InetAddress.getByName(ips[ctr]),

src/java/org/apache/hadoop/record/XmlRecordInput.java

@@ -25,7 +25,6 @@ import java.util.ArrayList;
 import org.xml.sax.*;
 import org.xml.sax.helpers.DefaultHandler;
 import javax.xml.parsers.SAXParserFactory;
-import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.parsers.SAXParser;
 
 /**
@@ -52,9 +51,9 @@ public class XmlRecordInput implements RecordInput {
     private class XMLParser extends DefaultHandler {
         private boolean charsValid = false;
         
-        private ArrayList valList;
+        private ArrayList<Value> valList;
         
-        private XMLParser(ArrayList vlist) {
+        private XMLParser(ArrayList<Value> vlist) {
             valList = vlist;
         }
         
@@ -96,7 +95,7 @@ public class XmlRecordInput implements RecordInput {
         public void characters(char buf[], int offset, int len)
         throws SAXException {
             if (charsValid) {
-                Value v = (Value) valList.get(valList.size()-1);
+                Value v = valList.get(valList.size()-1);
                 v.addChars(buf, offset,len);
             }
         }
@@ -105,7 +104,7 @@ public class XmlRecordInput implements RecordInput {
     
     private class XmlIndex implements Index {
         public boolean done() {
-            Value v = (Value) valList.get(vIdx);
+            Value v = valList.get(vIdx);
             if ("/array".equals(v.getType())) {
                 valList.set(vIdx, null);
                 vIdx++;
@@ -117,13 +116,13 @@ public class XmlRecordInput implements RecordInput {
         public void incr() {}
     }
     
-    private ArrayList valList;
+    private ArrayList<Value> valList;
     private int vLen;
     private int vIdx;
     
     private Value next() throws IOException {
         if (vIdx < vLen) {
-            Value v = (Value) valList.get(vIdx);
+            Value v = valList.get(vIdx);
             valList.set(vIdx, null);
             vIdx++;
             return v;
@@ -135,7 +134,7 @@ public class XmlRecordInput implements RecordInput {
     /** Creates a new instance of XmlRecordInput */
     public XmlRecordInput(InputStream in) {
       try{
-        valList = new ArrayList();
+        valList = new ArrayList<Value>();
         DefaultHandler handler = new XMLParser(valList);
         SAXParserFactory factory = SAXParserFactory.newInstance();
         SAXParser parser = factory.newSAXParser();

src/java/org/apache/hadoop/record/XmlRecordOutput.java

@@ -36,7 +36,7 @@ public class XmlRecordOutput implements RecordOutput {
     
     private int indent = 0;
     
-    private Stack compoundStack;
+    private Stack<String> compoundStack;
     
     private void putIndent() {
         StringBuffer sb = new StringBuffer("");
@@ -56,7 +56,7 @@ public class XmlRecordOutput implements RecordOutput {
     
     private void printBeginEnvelope(String tag) {
         if (!compoundStack.empty()) {
-            String s = (String) compoundStack.peek();
+            String s = compoundStack.peek();
             if ("struct".equals(s)) {
                 putIndent();
                 stream.print("<member>\n");
@@ -77,7 +77,7 @@ public class XmlRecordOutput implements RecordOutput {
     
     private void printEndEnvelope(String tag) {
         if (!compoundStack.empty()) {
-            String s = (String) compoundStack.peek();
+            String s = compoundStack.peek();
             if ("struct".equals(s)) {
                 stream.print("</value>\n");
                 closeIndent();
@@ -99,7 +99,7 @@ public class XmlRecordOutput implements RecordOutput {
     }
     
     private void outsideVector(String tag) throws IOException {
-        String s = (String) compoundStack.pop();
+        String s = compoundStack.pop();
         if (!"vector".equals(s)) {
             throw new IOException("Error serializing vector.");
         }
@@ -112,7 +112,7 @@ public class XmlRecordOutput implements RecordOutput {
     }
     
     private void outsideMap(String tag) throws IOException {
-        String s = (String) compoundStack.pop();
+        String s = compoundStack.pop();
         if (!"map".equals(s)) {
             throw new IOException("Error serializing map.");
         }
@@ -125,7 +125,7 @@ public class XmlRecordOutput implements RecordOutput {
     }
     
     private void outsideRecord(String tag) throws IOException {
-        String s = (String) compoundStack.pop();
+        String s = compoundStack.pop();
         if (!"struct".equals(s)) {
             throw new IOException("Error serializing record.");
         }
@@ -136,7 +136,7 @@ public class XmlRecordOutput implements RecordOutput {
     public XmlRecordOutput(OutputStream out) {
       try {
         stream = new PrintStream(out, true, "UTF-8");
-        compoundStack = new Stack();
+        compoundStack = new Stack<String>();
       } catch (UnsupportedEncodingException ex) {
         throw new RuntimeException(ex);
       }

src/java/org/apache/hadoop/util/CopyFiles.java

@@ -122,9 +122,9 @@ public class CopyFiles extends ToolBase {
       if (!absPath.isAbsolute()) { return absPath; }
       String sRoot = root.toUri().getPath();
       String sPath = absPath.toUri().getPath();
-      Enumeration rootTokens = new StringTokenizer(sRoot, "/");
+      Enumeration<Object> rootTokens = new StringTokenizer(sRoot, "/");
       ArrayList rList = Collections.list(rootTokens);
-      Enumeration pathTokens = new StringTokenizer(sPath, "/");
+      Enumeration<Object> pathTokens = new StringTokenizer(sPath, "/");
       ArrayList pList = Collections.list(pathTokens);
       Iterator rIter = rList.iterator();
       Iterator pIter = pList.iterator();
@@ -312,13 +312,13 @@ public class CopyFiles extends ToolBase {
       jobConf.setOutputPath(fakeOutDir);
       
       // create new sequence-files for holding paths
-      ArrayList pathList = new ArrayList();
-      ArrayList finalPathList = new ArrayList();
+      ArrayList<Path> pathList = new ArrayList<Path>();
+      ArrayList<String> finalPathList = new ArrayList<String>();
       pathList.add(new Path(srcPath));
       long totalBytes = 0;
       //int part = 0;
       while(!pathList.isEmpty()) {
-        Path top = (Path) pathList.remove(0);
+        Path top = pathList.remove(0);
         if (srcfs.isFile(top)) {
           totalBytes += srcfs.getLength(top);
           top = makeRelative(rootPath, top);
@@ -349,7 +349,7 @@ public class CopyFiles extends ToolBase {
         SequenceFile.Writer writer = 
           SequenceFile.createWriter(fileSys,conf,file,Text.class,Text.class);
         for (int ipath = idx; ipath < finalPathList.size(); ipath += numMaps) {
-          String path = (String) finalPathList.get(ipath);
+          String path = finalPathList.get(ipath);
           writer.append(new Text(path), new Text(""));
         }
         writer.close();

src/java/org/apache/hadoop/util/MergeSort.java

@@ -27,9 +27,10 @@ public class MergeSort {
   IntWritable I = new IntWritable(0);
   IntWritable J = new IntWritable(0);
   
-  private Comparator comparator; //the comparator that the algo should use
+  //the comparator that the algo should use
+  private Comparator<IntWritable> comparator;
   
-  public MergeSort(Comparator comparator) {
+  public MergeSort(Comparator<IntWritable> comparator) {
     this.comparator = comparator;
   }
   

src/java/org/apache/hadoop/util/ProgramDriver.java

@@ -20,10 +20,8 @@ package org.apache.hadoop.util;
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
-import java.util.TreeMap;
-import java.util.Iterator;
 import java.util.Map;
-import java.util.Map.Entry;
+import java.util.TreeMap;
 
 /** A driver that is used to run programs added to it
  */
@@ -36,10 +34,10 @@ public class ProgramDriver {
      * @author Owen O'Malley
      * @date april 2006
      */
-     Map programs;
+     Map<String, ProgramDescription> programs;
      
      public ProgramDriver(){
-        programs = new TreeMap();
+        programs = new TreeMap<String, ProgramDescription>();
      }
      
     static private class ProgramDescription {
@@ -82,13 +80,12 @@ public class ProgramDriver {
 	private String description;
     }
     
-    private static void printUsage(Map programs) {
+    private static void printUsage(Map<String, ProgramDescription> programs) {
 	System.out.println("Valid program names are:");
-	for(Iterator itr=programs.entrySet().iterator(); itr.hasNext();) {
-	    Map.Entry item = (Entry) itr.next();
-	    System.out.println("  " + (String) item.getKey() + ": " +
-			       ((ProgramDescription) item.getValue()).getDescription());
-	}   
+        for(Map.Entry<String, ProgramDescription> item : programs.entrySet()) {
+            System.out.println("  " + item.getKey() + ": " +
+                       item.getValue().getDescription());         
+        } 
     }
     
     /**
@@ -128,7 +125,7 @@ public class ProgramDriver {
 	}
 	
 	// And that it is good.
-	ProgramDescription pgm = (ProgramDescription) programs.get(args[0]);
+	ProgramDescription pgm = programs.get(args[0]);
 	if (pgm == null) {
 	    System.out.println("Unknown program '" + args[0] + "' chosen.");
 	    printUsage(programs);

src/java/org/apache/hadoop/util/Progress.java

@@ -29,7 +29,7 @@ public class Progress {
   private String status = "";
   private float progress;
   private int currentPhase;
-  private ArrayList phases = new ArrayList();
+  private ArrayList<Progress> phases = new ArrayList<Progress>();
   private Progress parent;
   private float progressPerPhase;
 
@@ -60,7 +60,7 @@ public class Progress {
 
   /** Returns the current sub-node executing. */
   public Progress phase() {
-    return (Progress)phases.get(currentPhase);
+    return phases.get(currentPhase);
   }
 
   /** Completes this node, moving the parent node to its next child. */

src/java/org/apache/hadoop/util/RunJar.java

@@ -131,7 +131,7 @@ public class RunJar {
 
     unJar(file, workDir);
     
-    ArrayList classPath = new ArrayList();
+    ArrayList<URL> classPath = new ArrayList<URL>();
     classPath.add(new File(workDir+"/").toURL());
     classPath.add(file.toURL());
     classPath.add(new File(workDir, "classes/").toURL());
@@ -142,7 +142,7 @@ public class RunJar {
       }
     }
     ClassLoader loader =
-      new URLClassLoader((URL[])classPath.toArray(new URL[0]));
+      new URLClassLoader(classPath.toArray(new URL[0]));
 
     Thread.currentThread().setContextClassLoader(loader);
     Class mainClass = Class.forName(mainClassName, true, loader);

src/java/org/apache/hadoop/util/StringUtils.java

@@ -261,7 +261,7 @@ public class StringUtils {
     if (str == null)
       return null;
     StringTokenizer tokenizer = new StringTokenizer (str,",");
-    List values = new ArrayList();
+    List<String> values = new ArrayList<String>();
     while (tokenizer.hasMoreTokens()) {
       values.add(tokenizer.nextToken());
     }