Kaynağa Gözat

ZOOKEEPER-477. zkCleanup.sh is flaky (fernando via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/trunk@802964 13f79535-47bb-0310-9956-ffa450edef68
Mahadev Konar 15 yıl önce
ebeveyn
işleme
94dabe199c
2 değiştirilmiş dosya ile 14 ekleme ve 3 silme
  1. 3 0
      CHANGES.txt
  2. 11 3
      bin/zkCleanup.sh

+ 3 - 0
CHANGES.txt

@@ -60,6 +60,9 @@ BUGFIXES:
   ZOOKEEPER-499. electionAlg should default to FLE (3) - regression (phunt via
   ZOOKEEPER-499. electionAlg should default to FLE (3) - regression (phunt via
   mahadev) 
   mahadev) 
 
 
+  ZOOKEEPER-477. zkCleanup.sh is flaky (fernando via mahadev)
+
+
 IMPROVEMENTS:
 IMPROVEMENTS:
   ZOOKEEPER-473. cleanup junit tests to eliminate false positives due to
   ZOOKEEPER-473. cleanup junit tests to eliminate false positives due to
   "socket reuse" and failure to close client (phunt via mahadev)
   "socket reuse" and failure to close client (phunt via mahadev)

+ 11 - 3
bin/zkCleanup.sh

@@ -36,8 +36,16 @@ ZOOBINDIR=`dirname "$ZOOBIN"`
 
 
 . $ZOOBINDIR/zkEnv.sh
 . $ZOOBINDIR/zkEnv.sh
 
 
-eval `grep -e "^dataDir=" $ZOOCFG`
+ZOODATADIR=$(grep '^dataDir=' $ZOOCFG | sed -e 's/.*=//')
+ZOODATALOGDIR=$(grep '^dataLogDir=' $ZOOCFG | sed -e 's/.*=//')
 
 
-java "-Dzookeeper.log.dir=${ZOO_LOG_DIR}" "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}" \
+if [ "x${ZOODATALOGDIR}" = "x" ]
+then
+echo java "-Dzookeeper.log.dir=${ZOO_LOG_DIR}" "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}" \
+     -cp $CLASSPATH $JVMFLAGS \
+     org.apache.zookeeper.server.PurgeTxnLog $ZOODATADIR $*
+else
+echo java "-Dzookeeper.log.dir=${ZOO_LOG_DIR}" "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}" \
      -cp $CLASSPATH $JVMFLAGS \
      -cp $CLASSPATH $JVMFLAGS \
-     org.apache.zookeeper.server.PurgeTxnLog $dataDir
+     org.apache.zookeeper.server.PurgeTxnLog $ZOODATALOGDIR $ZOODATADIR $*
+fi