Renamed ZooLog to ZooTrace. Major cleanup of tracing.

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/trunk@670950 13f79535-47bb-0310-9956-ffa450edef68

zookeeper/conf/log4j.properties

@@ -2,7 +2,16 @@
 # ZooKeeper Logging Configuration
 #
 
-log4j.rootLogger=DEBUG, CONSOLE, ROLLINGFILE
+# Format is "<default threshold> (, <appender>)+
+
+# DEFAULT: console appender only
+log4j.rootLogger=DEBUG, CONSOLE
+
+# Example with rolling log file
+#log4j.rootLogger=DEBUG, CONSOLE, ROLLINGFILE
+
+# Example with rolling log file and tracing
+#log4j.rootLogger=TRACE, CONSOLE, ROLLINGFILE, TRACEFILE
 
 #
 # Log INFO level and above messages to the console
@@ -13,9 +22,10 @@ log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout
 log4j.appender.CONSOLE.layout.ConversionPattern=%-5p - [%t:%C{1}@%L] - %m%n
 
 #
-# Log DEBUG level and above messages to a log file
-#
+# Add ROLLINGFILE to rootLogger to get log file output
+#    Log DEBUG level and above messages to a log file
 log4j.appender.ROLLINGFILE=org.apache.log4j.RollingFileAppender
+log4j.appender.ROLLINGFILE.Threshold=DEBUG
 log4j.appender.ROLLINGFILE.File=zookeeper.log
 
 # Max log file size of 10MB
@@ -25,3 +35,15 @@ log4j.appender.ROLLINGFILE.MaxFileSize=10MB
 
 log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
 log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n
+
+
+#
+# Add TRACEFILE to rootLogger to get log file output
+#    Log DEBUG level and above messages to a log file
+log4j.appender.TRACEFILE=org.apache.log4j.FileAppender
+log4j.appender.TRACEFILE.Threshold=TRACE
+log4j.appender.TRACEFILE.File=zookeeper_trace.log
+
+log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout
+### Notice we are including log4j's NDC here (%x)
+log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L][%x] - %m%n

zookeeper/conf/zoo_sample.cfg

@@ -10,8 +10,3 @@ syncLimit=5
 dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
 # the port at which the clients will connect
 clientPort=2181
-# the tracfile extension for loggging traces.
-# if not specified traces are not logged.
-# its recommended to swithc it off since this 
-# causes a lot of peroformacne enhancement.
-traceFile=server1/logs/tracefile