findbugsExcludeFile.xml 7.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219
  1. <FindBugsFilter>
  2. <Match>
  3. <Package name="org.apache.hadoop.record.compiler.generated" />
  4. </Match>
  5. <Match>
  6. <Package name="org.apache.hadoop.hdfs.protocol.proto" />
  7. </Match>
  8. <Match>
  9. <Package name="org.apache.hadoop.hdfs.server.namenode.ha.proto" />
  10. </Match>
  11. <Match>
  12. <Class name="~org.apache.hadoop.hdfs.server.namenode.FsImageProto.*" />
  13. </Match>
  14. <Match>
  15. <Package name="org.apache.hadoop.hdfs.qjournal.protocol" />
  16. </Match>
  17. <Match>
  18. <Bug pattern="EI_EXPOSE_REP" />
  19. </Match>
  20. <Match>
  21. <Bug pattern="EI_EXPOSE_REP2" />
  22. </Match>
  23. <Match>
  24. <Bug pattern="SE_COMPARATOR_SHOULD_BE_SERIALIZABLE" />
  25. </Match>
  26. <Match>
  27. <Bug pattern="SE_BAD_FIELD" />
  28. </Match>
  29. <Match>
  30. <Class name="~.*_jsp" />
  31. <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  32. </Match>
  33. <Match>
  34. <Field name="_jspx_dependants" />
  35. <Bug pattern="UWF_UNWRITTEN_FIELD" />
  36. </Match>
  37. <!--
  38. Inconsistent synchronization for Client.Connection.out is
  39. is intentional to make a connection to be closed instantly.
  40. -->
  41. <Match>
  42. <Class name="org.apache.hadoop.ipc.Client$Connection" />
  43. <Field name="out" />
  44. <Bug pattern="IS2_INCONSISTENT_SYNC" />
  45. </Match>
  46. <!--
  47. Ignore Cross Scripting Vulnerabilities
  48. We have an input quoting filter that protects us.
  49. -->
  50. <Match>
  51. <Bug code="XSS" />
  52. </Match>
  53. <Match>
  54. <Bug code="HRS" />
  55. </Match>
  56. <!--
  57. core changes
  58. -->
  59. <Match>
  60. <Class name="~org.apache.hadoop.*" />
  61. <Bug code="MS" />
  62. </Match>
  63. <!--
  64. getTmpInputStreams is pretty much like a stream constructor.
  65. The newly created streams are not supposed to be closed in the constructor. So ignore
  66. the OBL warning.
  67. -->
  68. <Match>
  69. <Class name="org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl" />
  70. <Method name="getTmpInputStreams" />
  71. <Bug pattern="OBL_UNSATISFIED_OBLIGATION" />
  72. </Match>
  73. <!--
  74. ResponseProccessor is thread that is designed to catch RuntimeException.
  75. -->
  76. <Match>
  77. <Class name="org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer$ResponseProcessor" />
  78. <Method name="run" />
  79. <Bug pattern="REC_CATCH_EXCEPTION" />
  80. </Match>
  81. <!--
  82. lastAppliedTxid is carefully unsynchronized in the BackupNode in a couple spots.
  83. See the comments in BackupImage for justification.
  84. -->
  85. <Match>
  86. <Class name="org.apache.hadoop.hdfs.server.namenode.FSImage" />
  87. <Field name="lastAppliedTxId" />
  88. <Bug pattern="IS2_INCONSISTENT_SYNC" />
  89. </Match>
  90. <!--
  91. Findbugs doesn't realize that closing a FilterOutputStream pushes the close down to
  92. wrapped streams, too.
  93. -->
  94. <Match>
  95. <Class name="org.apache.hadoop.hdfs.server.namenode.FSImageFormat$Saver" />
  96. <Method name="save" />
  97. <Bug pattern="OS_OPEN_STREAM" />
  98. </Match>
  99. <!--
  100. the 'metrics' member is sometimes used from synchronized blocks, sometimes not,
  101. but it's only reset by test cases, so should be fine
  102. -->
  103. <Match>
  104. <Class name="org.apache.hadoop.hdfs.server.namenode.FSEditLog" />
  105. <Field name="metrics" />
  106. <Bug pattern="IS2_INCONSISTENT_SYNC" />
  107. </Match>
  108. <!--
  109. We use a separate lock to protect modifications to journalSet so that
  110. FSEditLog#selectInputStreams does not need to be a synchronized method.
  111. -->
  112. <Match>
  113. <Class name="org.apache.hadoop.hdfs.server.namenode.FSEditLog" />
  114. <Field name="journalSet" />
  115. <Bug pattern="IS2_INCONSISTENT_SYNC" />
  116. </Match>
  117. <!--
  118. This method isn't performance-critical and is much clearer to write as it's written.
  119. -->
  120. <Match>
  121. <Class name="org.apache.hadoop.hdfs.server.datanode.BlockPoolManager" />
  122. <Method name="doRefreshNamenodes" />
  123. <Bug category="PERFORMANCE" />
  124. </Match>
  125. <!-- Don't complain about System.exit() being called from quit() -->
  126. <Match>
  127. <Class name="org.apache.hadoop.hdfs.server.namenode.MetaRecoveryContext" />
  128. <Method name="quit" />
  129. <Bug pattern="DM_EXIT" />
  130. </Match>
  131. <!-- Don't complain about recoverBlock equality check -->
  132. <Match>
  133. <Class name="org.apache.hadoop.hdfs.server.datanode.DataNode" />
  134. <Method name="recoverBlock" />
  135. <Bug pattern="EC_UNRELATED_TYPES" />
  136. </Match>
  137. <!-- More complex cleanup logic confuses findbugs -->
  138. <Match>
  139. <Class name="org.apache.hadoop.hdfs.qjournal.server.Journal" />
  140. <Method name="persistPaxosData" />
  141. <Bug pattern="OS_OPEN_STREAM" />
  142. </Match>
  143. <!-- Don't complain about LocalDatanodeInfo's anonymous class -->
  144. <Match>
  145. <Class name="org.apache.hadoop.hdfs.BlockReaderLocal$LocalDatanodeInfo$1" />
  146. <Bug pattern="SE_BAD_FIELD_INNER_CLASS" />
  147. </Match>
  148. <!-- Only one method increments numFailedVolumes and it is synchronized -->
  149. <Match>
  150. <Class name="org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeList" />
  151. <Field name="numFailedVolumes" />
  152. <Bug pattern="VO_VOLATILE_INCREMENT" />
  153. </Match>
  154. <!-- Access to pendingReceivedRequests is synchronized -->
  155. <Match>
  156. <Class name="org.apache.hadoop.hdfs.server.datanode.BPServiceActor" />
  157. <Method name="notifyNamenodeBlockImmediately" />
  158. <Field name="pendingReceivedRequests" />
  159. <Bug pattern="VO_VOLATILE_INCREMENT" />
  160. </Match>
  161. <!-- Replace System.exit() call with ExitUtil.terminate() -->
  162. <Match>
  163. <Class name="org.apache.hadoop.hdfs.tools.JMXGet"/>
  164. <Method name="main" />
  165. <Bug pattern="NP_NULL_ON_SOME_PATH" />
  166. </Match>
  167. <Match>
  168. <Class name="org.apache.hadoop.hdfs.server.datanode.ReplicaInfo" />
  169. <Method name="setDirInternal" />
  170. <Bug pattern="DM_STRING_CTOR" />
  171. </Match>
  172. <Match>
  173. <Class name="org.apache.hadoop.hdfs.shortcircuit.DfsClientShmManager$EndpointShmManager" />
  174. <Method name="allocSlot" />
  175. <Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH" />
  176. </Match>
  177. <Match>
  178. <Class name="org.apache.hadoop.hdfs.shortcircuit.DfsClientShmManager$EndpointShmManager" />
  179. <Method name="allocSlot" />
  180. <Bug pattern="UL_UNRELEASED_LOCK" />
  181. </Match>
  182. <!-- Manually verified to be okay, we want to throw away the top bit here -->
  183. <Match>
  184. <Class name="org.apache.hadoop.hdfs.server.namenode.CachedBlock" />
  185. <Method name="getReplication" />
  186. <Bug pattern="ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT" />
  187. </Match>
  188. <Match>
  189. <Class name="org.apache.hadoop.hdfs.protocol.CacheDirective" />
  190. <Method name="insertInternal" />
  191. <Bug pattern="BC_UNCONFIRMED_CAST" />
  192. </Match>
  193. <Match>
  194. <Class name="org.apache.hadoop.hdfs.server.blockmanagement.CacheReplicationMonitor" />
  195. <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
  196. </Match>
  197. <Match>
  198. <Class name="org.apache.hadoop.hdfs.DFSUtil"/>
  199. <Method name="assertAllResultsEqual" />
  200. <Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE" />
  201. </Match>
  202. <!--
  203. We use a separate lock to guard cachingStrategy in order to separate
  204. locks for p-reads from seek + read invocations.
  205. -->
  206. <Match>
  207. <Class name="org.apache.hadoop.hdfs.DFSInputStream" />
  208. <Field name="cachingStrategy" />
  209. <Bug pattern="IS2_INCONSISTENT_SYNC" />
  210. </Match>
  211. </FindBugsFilter>