test-patch.sh 36 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006
  1. #!/usr/bin/env bash
  2. # Licensed under the Apache License, Version 2.0 (the "License");
  3. # you may not use this file except in compliance with the License.
  4. # You may obtain a copy of the License at
  5. #
  6. # http://www.apache.org/licenses/LICENSE-2.0
  7. #
  8. # Unless required by applicable law or agreed to in writing, software
  9. # distributed under the License is distributed on an "AS IS" BASIS,
  10. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  11. # See the License for the specific language governing permissions and
  12. # limitations under the License.
  13. #set -x
  14. ulimit -n 1024
  15. ### Setup some variables.
  16. ### SVN_REVISION and BUILD_URL are set by Hudson if it is run by patch process
  17. ### Read variables from properties file
  18. bindir=$(dirname $0)
  19. # Defaults
  20. if [ -z "$MAVEN_HOME" ]; then
  21. MVN=mvn
  22. else
  23. MVN=$MAVEN_HOME/bin/mvn
  24. fi
  25. PROJECT_NAME=Hadoop
  26. JENKINS=false
  27. PATCH_DIR=/tmp
  28. SUPPORT_DIR=/tmp
  29. BASEDIR=$(pwd)
  30. BUILD_NATIVE=true
  31. PS=${PS:-ps}
  32. AWK=${AWK:-awk}
  33. WGET=${WGET:-wget}
  34. SVN=${SVN:-svn}
  35. GREP=${GREP:-grep}
  36. PATCH=${PATCH:-patch}
  37. DIFF=${DIFF:-diff}
  38. JIRACLI=${JIRA:-jira}
  39. FINDBUGS_HOME=${FINDBUGS_HOME}
  40. FORREST_HOME=${FORREST_HOME}
  41. ECLIPSE_HOME=${ECLIPSE_HOME}
  42. ###############################################################################
  43. printUsage() {
  44. echo "Usage: $0 [options] patch-file | defect-number"
  45. echo
  46. echo "Where:"
  47. echo " patch-file is a local patch file containing the changes to test"
  48. echo " defect-number is a JIRA defect number (e.g. 'HADOOP-1234') to test (Jenkins only)"
  49. echo
  50. echo "Options:"
  51. echo "--patch-dir=<dir> The directory for working and output files (default '/tmp')"
  52. echo "--basedir=<dir> The directory to apply the patch to (default current directory)"
  53. echo "--mvn-cmd=<cmd> The 'mvn' command to use (default \$MAVEN_HOME/bin/mvn, or 'mvn')"
  54. echo "--ps-cmd=<cmd> The 'ps' command to use (default 'ps')"
  55. echo "--awk-cmd=<cmd> The 'awk' command to use (default 'awk')"
  56. echo "--svn-cmd=<cmd> The 'svn' command to use (default 'svn')"
  57. echo "--grep-cmd=<cmd> The 'grep' command to use (default 'grep')"
  58. echo "--patch-cmd=<cmd> The 'patch' command to use (default 'patch')"
  59. echo "--diff-cmd=<cmd> The 'diff' command to use (default 'diff')"
  60. echo "--findbugs-home=<path> Findbugs home directory (default FINDBUGS_HOME environment variable)"
  61. echo "--forrest-home=<path> Forrest home directory (default FORREST_HOME environment variable)"
  62. echo "--dirty-workspace Allow the local SVN workspace to have uncommitted changes"
  63. echo "--run-tests Run all tests below the base directory"
  64. echo "--build-native=<bool> If true, then build native components (default 'true')"
  65. echo
  66. echo "Jenkins-only options:"
  67. echo "--jenkins Run by Jenkins (runs tests and posts results to JIRA)"
  68. echo "--support-dir=<dir> The directory to find support files in"
  69. echo "--wget-cmd=<cmd> The 'wget' command to use (default 'wget')"
  70. echo "--jira-cmd=<cmd> The 'jira' command to use (default 'jira')"
  71. echo "--jira-password=<pw> The password for the 'jira' command"
  72. echo "--eclipse-home=<path> Eclipse home directory (default ECLIPSE_HOME environment variable)"
  73. }
  74. ###############################################################################
  75. parseArgs() {
  76. for i in $*
  77. do
  78. case $i in
  79. --jenkins)
  80. JENKINS=true
  81. ;;
  82. --patch-dir=*)
  83. PATCH_DIR=${i#*=}
  84. ;;
  85. --support-dir=*)
  86. SUPPORT_DIR=${i#*=}
  87. ;;
  88. --basedir=*)
  89. BASEDIR=${i#*=}
  90. ;;
  91. --mvn-cmd=*)
  92. MVN=${i#*=}
  93. ;;
  94. --ps-cmd=*)
  95. PS=${i#*=}
  96. ;;
  97. --awk-cmd=*)
  98. AWK=${i#*=}
  99. ;;
  100. --wget-cmd=*)
  101. WGET=${i#*=}
  102. ;;
  103. --svn-cmd=*)
  104. SVN=${i#*=}
  105. ;;
  106. --grep-cmd=*)
  107. GREP=${i#*=}
  108. ;;
  109. --patch-cmd=*)
  110. PATCH=${i#*=}
  111. ;;
  112. --diff-cmd=*)
  113. DIFF=${i#*=}
  114. ;;
  115. --jira-cmd=*)
  116. JIRACLI=${i#*=}
  117. ;;
  118. --jira-password=*)
  119. JIRA_PASSWD=${i#*=}
  120. ;;
  121. --findbugs-home=*)
  122. FINDBUGS_HOME=${i#*=}
  123. ;;
  124. --forrest-home=*)
  125. FORREST_HOME=${i#*=}
  126. ;;
  127. --eclipse-home=*)
  128. ECLIPSE_HOME=${i#*=}
  129. ;;
  130. --dirty-workspace)
  131. DIRTY_WORKSPACE=true
  132. ;;
  133. --run-tests)
  134. RUN_TESTS=true
  135. ;;
  136. --build-native=*)
  137. BUILD_NATIVE=${i#*=}
  138. ;;
  139. *)
  140. PATCH_OR_DEFECT=$i
  141. ;;
  142. esac
  143. done
  144. if [[ $BUILD_NATIVE == "true" ]] ; then
  145. NATIVE_PROFILE=-Pnative
  146. REQUIRE_TEST_LIB_HADOOP=-Drequire.test.libhadoop
  147. fi
  148. if [ -z "$PATCH_OR_DEFECT" ]; then
  149. printUsage
  150. exit 1
  151. fi
  152. if [[ $JENKINS == "true" ]] ; then
  153. echo "Running in Jenkins mode"
  154. defect=$PATCH_OR_DEFECT
  155. ECLIPSE_PROPERTY="-Declipse.home=$ECLIPSE_HOME"
  156. else
  157. echo "Running in developer mode"
  158. JENKINS=false
  159. ### PATCH_FILE contains the location of the patchfile
  160. PATCH_FILE=$PATCH_OR_DEFECT
  161. if [[ ! -e "$PATCH_FILE" ]] ; then
  162. echo "Unable to locate the patch file $PATCH_FILE"
  163. cleanupAndExit 0
  164. fi
  165. ### Check if $PATCH_DIR exists. If it does not exist, create a new directory
  166. if [[ ! -e "$PATCH_DIR" ]] ; then
  167. mkdir "$PATCH_DIR"
  168. if [[ $? == 0 ]] ; then
  169. echo "$PATCH_DIR has been created"
  170. else
  171. echo "Unable to create $PATCH_DIR"
  172. cleanupAndExit 0
  173. fi
  174. fi
  175. ### Obtain the patch filename to append it to the version number
  176. defect=`basename $PATCH_FILE`
  177. fi
  178. }
  179. ###############################################################################
  180. checkout () {
  181. echo ""
  182. echo ""
  183. echo "======================================================================"
  184. echo "======================================================================"
  185. echo " Testing patch for ${defect}."
  186. echo "======================================================================"
  187. echo "======================================================================"
  188. echo ""
  189. echo ""
  190. ### When run by a developer, if the workspace contains modifications, do not continue
  191. ### unless the --dirty-workspace option was set
  192. status=`$SVN stat --ignore-externals | sed -e '/^X[ ]*/D'`
  193. if [[ $JENKINS == "false" ]] ; then
  194. if [[ "$status" != "" && -z $DIRTY_WORKSPACE ]] ; then
  195. echo "ERROR: can't run in a workspace that contains the following modifications"
  196. echo "$status"
  197. cleanupAndExit 1
  198. fi
  199. echo
  200. else
  201. cd $BASEDIR
  202. $SVN revert -R .
  203. rm -rf `$SVN status --no-ignore`
  204. $SVN update
  205. fi
  206. return $?
  207. }
  208. ###############################################################################
  209. downloadPatch () {
  210. ### Download latest patch file (ignoring .htm and .html) when run from patch process
  211. if [[ $JENKINS == "true" ]] ; then
  212. $WGET -q -O $PATCH_DIR/jira http://issues.apache.org/jira/browse/$defect
  213. if [[ `$GREP -c 'Patch Available' $PATCH_DIR/jira` == 0 ]] ; then
  214. echo "$defect is not \"Patch Available\". Exiting."
  215. cleanupAndExit 0
  216. fi
  217. relativePatchURL=`$GREP -o '"/jira/secure/attachment/[0-9]*/[^"]*' $PATCH_DIR/jira | $GREP -v -e 'htm[l]*$' | sort | tail -1 | $GREP -o '/jira/secure/attachment/[0-9]*/[^"]*'`
  218. patchURL="http://issues.apache.org${relativePatchURL}"
  219. patchNum=`echo $patchURL | $GREP -o '[0-9]*/' | $GREP -o '[0-9]*'`
  220. echo "$defect patch is being downloaded at `date` from"
  221. echo "$patchURL"
  222. $WGET -q -O $PATCH_DIR/patch $patchURL
  223. VERSION=${SVN_REVISION}_${defect}_PATCH-${patchNum}
  224. JIRA_COMMENT="Here are the results of testing the latest attachment
  225. $patchURL
  226. against trunk revision ${SVN_REVISION}."
  227. ### Copy in any supporting files needed by this process
  228. cp -r $SUPPORT_DIR/lib/* ./lib
  229. #PENDING: cp -f $SUPPORT_DIR/etc/checkstyle* ./src/test
  230. ### Copy the patch file to $PATCH_DIR
  231. else
  232. VERSION=PATCH-${defect}
  233. cp $PATCH_FILE $PATCH_DIR/patch
  234. if [[ $? == 0 ]] ; then
  235. echo "Patch file $PATCH_FILE copied to $PATCH_DIR"
  236. else
  237. echo "Could not copy $PATCH_FILE to $PATCH_DIR"
  238. cleanupAndExit 0
  239. fi
  240. fi
  241. }
  242. ###############################################################################
  243. verifyPatch () {
  244. # Before building, check to make sure that the patch is valid
  245. $bindir/smart-apply-patch.sh $PATCH_DIR/patch dryrun
  246. if [[ $? != 0 ]] ; then
  247. echo "PATCH APPLICATION FAILED"
  248. JIRA_COMMENT="$JIRA_COMMENT
  249. {color:red}-1 patch{color}. The patch command could not apply the patch."
  250. return 1
  251. else
  252. return 0
  253. fi
  254. }
  255. ###############################################################################
  256. buildWithPatch () {
  257. echo ""
  258. echo ""
  259. echo "======================================================================"
  260. echo "======================================================================"
  261. echo " Pre-build trunk to verify trunk stability and javac warnings"
  262. echo "======================================================================"
  263. echo "======================================================================"
  264. echo ""
  265. echo ""
  266. if [[ ! -d hadoop-common-project ]]; then
  267. cd $bindir/..
  268. echo "Compiling $(pwd)"
  269. echo "$MVN clean test -DskipTests > $PATCH_DIR/trunkCompile.txt 2>&1"
  270. $MVN clean test -DskipTests > $PATCH_DIR/trunkCompile.txt 2>&1
  271. if [[ $? != 0 ]] ; then
  272. echo "Top-level trunk compilation is broken?"
  273. cleanupAndExit 1
  274. fi
  275. cd -
  276. fi
  277. echo "Compiling $(pwd)"
  278. echo "$MVN clean test -DskipTests -D${PROJECT_NAME}PatchProcess -Ptest-patch > $PATCH_DIR/trunkJavacWarnings.txt 2>&1"
  279. $MVN clean test -DskipTests -D${PROJECT_NAME}PatchProcess -Ptest-patch > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
  280. if [[ $? != 0 ]] ; then
  281. echo "Trunk compilation is broken?"
  282. cleanupAndExit 1
  283. fi
  284. }
  285. ###############################################################################
  286. ### Check for @author tags in the patch
  287. checkAuthor () {
  288. echo ""
  289. echo ""
  290. echo "======================================================================"
  291. echo "======================================================================"
  292. echo " Checking there are no @author tags in the patch."
  293. echo "======================================================================"
  294. echo "======================================================================"
  295. echo ""
  296. echo ""
  297. authorTags=`$GREP -c -i '@author' $PATCH_DIR/patch`
  298. echo "There appear to be $authorTags @author tags in the patch."
  299. if [[ $authorTags != 0 ]] ; then
  300. JIRA_COMMENT="$JIRA_COMMENT
  301. {color:red}-1 @author{color}. The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
  302. return 1
  303. fi
  304. JIRA_COMMENT="$JIRA_COMMENT
  305. {color:green}+1 @author{color}. The patch does not contain any @author tags."
  306. return 0
  307. }
  308. ###############################################################################
  309. ### Check for tests in the patch
  310. checkTests () {
  311. echo ""
  312. echo ""
  313. echo "======================================================================"
  314. echo "======================================================================"
  315. echo " Checking there are new or changed tests in the patch."
  316. echo "======================================================================"
  317. echo "======================================================================"
  318. echo ""
  319. echo ""
  320. testReferences=`$GREP -c -i -e '^+++.*/test' $PATCH_DIR/patch`
  321. echo "There appear to be $testReferences test files referenced in the patch."
  322. if [[ $testReferences == 0 ]] ; then
  323. if [[ $JENKINS == "true" ]] ; then
  324. patchIsDoc=`$GREP -c -i 'title="documentation' $PATCH_DIR/jira`
  325. if [[ $patchIsDoc != 0 ]] ; then
  326. echo "The patch appears to be a documentation patch that doesn't require tests."
  327. JIRA_COMMENT="$JIRA_COMMENT
  328. {color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests."
  329. return 0
  330. fi
  331. fi
  332. JIRA_COMMENT="$JIRA_COMMENT
  333. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
  334. Please justify why no new tests are needed for this patch.
  335. Also please list what manual steps were performed to verify this patch."
  336. return 1
  337. fi
  338. JIRA_COMMENT="$JIRA_COMMENT
  339. {color:green}+1 tests included{color}. The patch appears to include $testReferences new or modified test files."
  340. return 0
  341. }
  342. cleanUpXml () {
  343. cd $BASEDIR/conf
  344. for file in `ls *.xml.template`
  345. do
  346. rm -f `basename $file .template`
  347. done
  348. cd $BASEDIR
  349. }
  350. ###############################################################################
  351. ### Attempt to apply the patch
  352. applyPatch () {
  353. echo ""
  354. echo ""
  355. echo "======================================================================"
  356. echo "======================================================================"
  357. echo " Applying patch."
  358. echo "======================================================================"
  359. echo "======================================================================"
  360. echo ""
  361. echo ""
  362. export PATCH
  363. $bindir/smart-apply-patch.sh $PATCH_DIR/patch
  364. if [[ $? != 0 ]] ; then
  365. echo "PATCH APPLICATION FAILED"
  366. JIRA_COMMENT="$JIRA_COMMENT
  367. {color:red}-1 patch{color}. The patch command could not apply the patch."
  368. return 1
  369. fi
  370. return 0
  371. }
  372. ###############################################################################
  373. ### Check there are no javadoc warnings
  374. checkJavadocWarnings () {
  375. echo ""
  376. echo ""
  377. echo "======================================================================"
  378. echo "======================================================================"
  379. echo " Determining number of patched javadoc warnings."
  380. echo "======================================================================"
  381. echo "======================================================================"
  382. echo ""
  383. echo ""
  384. echo "$MVN clean test javadoc:javadoc -DskipTests -Pdocs -D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchJavadocWarnings.txt 2>&1"
  385. if [ -d hadoop-project ]; then
  386. (cd hadoop-project; $MVN install > /dev/null 2>&1)
  387. fi
  388. if [ -d hadoop-common-project/hadoop-annotations ]; then
  389. (cd hadoop-common-project/hadoop-annotations; $MVN install > /dev/null 2>&1)
  390. fi
  391. $MVN clean test javadoc:javadoc -DskipTests -Pdocs -D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchJavadocWarnings.txt 2>&1
  392. javadocWarnings=`$GREP '\[WARNING\]' $PATCH_DIR/patchJavadocWarnings.txt | $AWK '/Javadoc Warnings/,EOF' | $GREP warning | $AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
  393. echo ""
  394. echo ""
  395. echo "There appear to be $javadocWarnings javadoc warnings generated by the patched build."
  396. #There are 11 warnings that are caused by things that are caused by using sun internal APIs.
  397. OK_JAVADOC_WARNINGS=11;
  398. ### if current warnings greater than OK_JAVADOC_WARNINGS
  399. if [[ $javadocWarnings -ne $OK_JAVADOC_WARNINGS ]] ; then
  400. JIRA_COMMENT="$JIRA_COMMENT
  401. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated `expr $(($javadocWarnings-$OK_JAVADOC_WARNINGS))` warning messages."
  402. return 1
  403. fi
  404. JIRA_COMMENT="$JIRA_COMMENT
  405. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages."
  406. return 0
  407. }
  408. ###############################################################################
  409. ### Check there are no changes in the number of Javac warnings
  410. checkJavacWarnings () {
  411. echo ""
  412. echo ""
  413. echo "======================================================================"
  414. echo "======================================================================"
  415. echo " Determining number of patched javac warnings."
  416. echo "======================================================================"
  417. echo "======================================================================"
  418. echo ""
  419. echo ""
  420. echo "$MVN clean test -DskipTests -D${PROJECT_NAME}PatchProcess $NATIVE_PROFILE -Ptest-patch > $PATCH_DIR/patchJavacWarnings.txt 2>&1"
  421. $MVN clean test -DskipTests -D${PROJECT_NAME}PatchProcess $NATIVE_PROFILE -Ptest-patch > $PATCH_DIR/patchJavacWarnings.txt 2>&1
  422. if [[ $? != 0 ]] ; then
  423. JIRA_COMMENT="$JIRA_COMMENT
  424. {color:red}-1 javac{color:red}. The patch appears to cause the build to fail."
  425. return 2
  426. fi
  427. ### Compare trunk and patch javac warning numbers
  428. if [[ -f $PATCH_DIR/patchJavacWarnings.txt ]] ; then
  429. $GREP '\[WARNING\]' $PATCH_DIR/trunkJavacWarnings.txt > $PATCH_DIR/filteredTrunkJavacWarnings.txt
  430. $GREP '\[WARNING\]' $PATCH_DIR/patchJavacWarnings.txt > $PATCH_DIR/filteredPatchJavacWarnings.txt
  431. trunkJavacWarnings=`cat $PATCH_DIR/filteredTrunkJavacWarnings.txt | $AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
  432. patchJavacWarnings=`cat $PATCH_DIR/filteredPatchJavacWarnings.txt | $AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
  433. echo "There appear to be $trunkJavacWarnings javac compiler warnings before the patch and $patchJavacWarnings javac compiler warnings after applying the patch."
  434. if [[ $patchJavacWarnings != "" && $trunkJavacWarnings != "" ]] ; then
  435. if [[ $patchJavacWarnings -gt $trunkJavacWarnings ]] ; then
  436. JIRA_COMMENT="$JIRA_COMMENT
  437. {color:red}-1 javac{color}. The applied patch generated $patchJavacWarnings javac compiler warnings (more than the trunk's current $trunkJavacWarnings warnings)."
  438. $DIFF $PATCH_DIR/filteredTrunkJavacWarnings.txt $PATCH_DIR/filteredPatchJavacWarnings.txt > $PATCH_DIR/diffJavacWarnings.txt
  439. JIRA_COMMENT_FOOTER="Javac warnings: $BUILD_URL/artifact/trunk/patchprocess/diffJavacWarnings.txt
  440. $JIRA_COMMENT_FOOTER"
  441. return 1
  442. fi
  443. fi
  444. fi
  445. JIRA_COMMENT="$JIRA_COMMENT
  446. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings."
  447. return 0
  448. }
  449. ###############################################################################
  450. ### Check there are no changes in the number of release audit (RAT) warnings
  451. checkReleaseAuditWarnings () {
  452. echo ""
  453. echo ""
  454. echo "======================================================================"
  455. echo "======================================================================"
  456. echo " Determining number of patched release audit warnings."
  457. echo "======================================================================"
  458. echo "======================================================================"
  459. echo ""
  460. echo ""
  461. echo "$MVN apache-rat:check -D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchReleaseAuditOutput.txt 2>&1"
  462. $MVN apache-rat:check -D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchReleaseAuditOutput.txt 2>&1
  463. find $BASEDIR -name rat.txt | xargs cat > $PATCH_DIR/patchReleaseAuditWarnings.txt
  464. ### Compare trunk and patch release audit warning numbers
  465. if [[ -f $PATCH_DIR/patchReleaseAuditWarnings.txt ]] ; then
  466. patchReleaseAuditWarnings=`$GREP -c '\!?????' $PATCH_DIR/patchReleaseAuditWarnings.txt`
  467. echo ""
  468. echo ""
  469. echo "There appear to be $patchReleaseAuditWarnings release audit warnings after applying the patch."
  470. if [[ $patchReleaseAuditWarnings != "" ]] ; then
  471. if [[ $patchReleaseAuditWarnings -gt 0 ]] ; then
  472. JIRA_COMMENT="$JIRA_COMMENT
  473. {color:red}-1 release audit{color}. The applied patch generated $patchReleaseAuditWarnings release audit warnings."
  474. $GREP '\!?????' $PATCH_DIR/patchReleaseAuditWarnings.txt > $PATCH_DIR/patchReleaseAuditProblems.txt
  475. echo "Lines that start with ????? in the release audit report indicate files that do not have an Apache license header." >> $PATCH_DIR/patchReleaseAuditProblems.txt
  476. JIRA_COMMENT_FOOTER="Release audit warnings: $BUILD_URL/artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
  477. $JIRA_COMMENT_FOOTER"
  478. return 1
  479. fi
  480. fi
  481. fi
  482. JIRA_COMMENT="$JIRA_COMMENT
  483. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings."
  484. return 0
  485. }
  486. ###############################################################################
  487. ### Check there are no changes in the number of Checkstyle warnings
  488. checkStyle () {
  489. echo ""
  490. echo ""
  491. echo "======================================================================"
  492. echo "======================================================================"
  493. echo " Determining number of patched checkstyle warnings."
  494. echo "======================================================================"
  495. echo "======================================================================"
  496. echo ""
  497. echo ""
  498. echo "THIS IS NOT IMPLEMENTED YET"
  499. echo ""
  500. echo ""
  501. echo "$MVN test checkstyle:checkstyle -DskipTests -D${PROJECT_NAME}PatchProcess"
  502. $MVN test checkstyle:checkstyle -DskipTests -D${PROJECT_NAME}PatchProcess
  503. JIRA_COMMENT_FOOTER="Checkstyle results: $BUILD_URL/artifact/trunk/build/test/checkstyle-errors.html
  504. $JIRA_COMMENT_FOOTER"
  505. ### TODO: calculate actual patchStyleErrors
  506. # patchStyleErrors=0
  507. # if [[ $patchStyleErrors != 0 ]] ; then
  508. # JIRA_COMMENT="$JIRA_COMMENT
  509. #
  510. # {color:red}-1 checkstyle{color}. The patch generated $patchStyleErrors code style errors."
  511. # return 1
  512. # fi
  513. # JIRA_COMMENT="$JIRA_COMMENT
  514. #
  515. # {color:green}+1 checkstyle{color}. The patch generated 0 code style errors."
  516. return 0
  517. }
  518. ###############################################################################
  519. ### Install the new jars so tests and findbugs can find all of the updated jars
  520. buildAndInstall () {
  521. echo ""
  522. echo ""
  523. echo "======================================================================"
  524. echo "======================================================================"
  525. echo " Installing all of the jars"
  526. echo "======================================================================"
  527. echo "======================================================================"
  528. echo ""
  529. echo ""
  530. echo "$MVN install -Dmaven.javadoc.skip=true -DskipTests -D${PROJECT_NAME}PatchProcess"
  531. $MVN install -Dmaven.javadoc.skip=true -DskipTests -D${PROJECT_NAME}PatchProcess
  532. return $?
  533. }
  534. ###############################################################################
  535. ### Check there are no changes in the number of Findbugs warnings
  536. checkFindbugsWarnings () {
  537. findbugs_version=`${FINDBUGS_HOME}/bin/findbugs -version`
  538. echo ""
  539. echo ""
  540. echo "======================================================================"
  541. echo "======================================================================"
  542. echo " Determining number of patched Findbugs warnings."
  543. echo "======================================================================"
  544. echo "======================================================================"
  545. echo ""
  546. echo ""
  547. modules=$(findModules)
  548. rc=0
  549. for module in $modules;
  550. do
  551. cd $module
  552. echo " Running findbugs in $module"
  553. module_suffix=`basename ${module}`
  554. echo "$MVN clean test findbugs:findbugs -DskipTests -D${PROJECT_NAME}PatchProcess < /dev/null > $PATCH_DIR/patchFindBugsOutput${module_suffix}.txt 2>&1"
  555. $MVN clean test findbugs:findbugs -DskipTests -D${PROJECT_NAME}PatchProcess < /dev/null > $PATCH_DIR/patchFindBugsOutput${module_suffix}.txt 2>&1
  556. (( rc = rc + $? ))
  557. cd -
  558. done
  559. if [ $rc != 0 ] ; then
  560. JIRA_COMMENT="$JIRA_COMMENT
  561. {color:red}-1 findbugs{color}. The patch appears to cause Findbugs (version ${findbugs_version}) to fail."
  562. return 1
  563. fi
  564. findbugsWarnings=0
  565. for file in $(find $BASEDIR -name findbugsXml.xml)
  566. do
  567. relative_file=${file#$BASEDIR/} # strip leading $BASEDIR prefix
  568. if [ ! $relative_file == "target/findbugsXml.xml" ]; then
  569. module_suffix=${relative_file%/target/findbugsXml.xml} # strip trailing path
  570. module_suffix=`basename ${module_suffix}`
  571. fi
  572. cp $file $PATCH_DIR/patchFindbugsWarnings${module_suffix}.xml
  573. $FINDBUGS_HOME/bin/setBugDatabaseInfo -timestamp "01/01/2000" \
  574. $PATCH_DIR/patchFindbugsWarnings${module_suffix}.xml \
  575. $PATCH_DIR/patchFindbugsWarnings${module_suffix}.xml
  576. newFindbugsWarnings=`$FINDBUGS_HOME/bin/filterBugs -first "01/01/2000" $PATCH_DIR/patchFindbugsWarnings${module_suffix}.xml \
  577. $PATCH_DIR/newPatchFindbugsWarnings${module_suffix}.xml | $AWK '{print $1}'`
  578. echo "Found $newFindbugsWarnings Findbugs warnings ($file)"
  579. findbugsWarnings=$((findbugsWarnings+newFindbugsWarnings))
  580. $FINDBUGS_HOME/bin/convertXmlToText -html \
  581. $PATCH_DIR/newPatchFindbugsWarnings${module_suffix}.xml \
  582. $PATCH_DIR/newPatchFindbugsWarnings${module_suffix}.html
  583. if [[ $newFindbugsWarnings > 0 ]] ; then
  584. JIRA_COMMENT_FOOTER="Findbugs warnings: $BUILD_URL/artifact/trunk/patchprocess/newPatchFindbugsWarnings${module_suffix}.html
  585. $JIRA_COMMENT_FOOTER"
  586. fi
  587. done
  588. if [[ $findbugsWarnings -gt 0 ]] ; then
  589. JIRA_COMMENT="$JIRA_COMMENT
  590. {color:red}-1 findbugs{color}. The patch appears to introduce $findbugsWarnings new Findbugs (version ${findbugs_version}) warnings."
  591. return 1
  592. fi
  593. JIRA_COMMENT="$JIRA_COMMENT
  594. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version ${findbugs_version}) warnings."
  595. return 0
  596. }
  597. ###############################################################################
  598. ### Verify eclipse:eclipse works
  599. checkEclipseGeneration () {
  600. echo ""
  601. echo ""
  602. echo "======================================================================"
  603. echo "======================================================================"
  604. echo " Running mvn eclipse:eclipse."
  605. echo "======================================================================"
  606. echo "======================================================================"
  607. echo ""
  608. echo ""
  609. echo "$MVN eclipse:eclipse -D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchEclipseOutput.txt 2>&1"
  610. $MVN eclipse:eclipse -D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchEclipseOutput.txt 2>&1
  611. if [[ $? != 0 ]] ; then
  612. JIRA_COMMENT="$JIRA_COMMENT
  613. {color:red}-1 eclipse:eclipse{color}. The patch failed to build with eclipse:eclipse."
  614. return 1
  615. fi
  616. JIRA_COMMENT="$JIRA_COMMENT
  617. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse."
  618. return 0
  619. }
  620. ###############################################################################
  621. ### Run the tests
  622. runTests () {
  623. echo ""
  624. echo ""
  625. echo "======================================================================"
  626. echo "======================================================================"
  627. echo " Running tests."
  628. echo "======================================================================"
  629. echo "======================================================================"
  630. echo ""
  631. echo ""
  632. failed_tests=""
  633. modules=$(findModules)
  634. #
  635. # If we are building hadoop-hdfs-project, we must build the native component
  636. # of hadoop-common-project first. In order to accomplish this, we move the
  637. # hadoop-hdfs subprojects to the end of the list so that common will come
  638. # first.
  639. #
  640. # Of course, we may not be building hadoop-common at all-- in this case, we
  641. # explicitly insert a mvn compile -Pnative of common, to ensure that the
  642. # native libraries show up where we need them.
  643. #
  644. building_common=0
  645. for module in $modules; do
  646. if [[ $module == hadoop-hdfs-project* ]]; then
  647. hdfs_modules="$hdfs_modules $module"
  648. elif [[ $module == hadoop-common-project* ]]; then
  649. ordered_modules="$ordered_modules $module"
  650. building_common=1
  651. else
  652. ordered_modules="$ordered_modules $module"
  653. fi
  654. done
  655. if [ -n "$hdfs_modules" ]; then
  656. ordered_modules="$ordered_modules $hdfs_modules"
  657. if [[ $building_common -eq 0 ]]; then
  658. echo " Building hadoop-common with -Pnative in order to provide \
  659. libhadoop.so to the hadoop-hdfs unit tests."
  660. echo " $MVN compile $NATIVE_PROFILE -D${PROJECT_NAME}PatchProcess"
  661. if ! $MVN compile $NATIVE_PROFILE -D${PROJECT_NAME}PatchProcess; then
  662. JIRA_COMMENT="$JIRA_COMMENT
  663. {color:red}-1 core tests{color}. Failed to build the native portion \
  664. of hadoop-common prior to running the unit tests in $ordered_modules"
  665. return 1
  666. fi
  667. fi
  668. fi
  669. for module in $ordered_modules; do
  670. cd $module
  671. echo " Running tests in $module"
  672. echo " $MVN clean install -fn $NATIVE_PROFILE $REQUIRE_TEST_LIB_HADOOP -D${PROJECT_NAME}PatchProcess"
  673. $MVN clean install -fn $NATIVE_PROFILE $REQUIRE_TEST_LIB_HADOOP -D${PROJECT_NAME}PatchProcess
  674. module_failed_tests=`find . -name 'TEST*.xml' | xargs $GREP -l -E "<failure|<error" | sed -e "s|.*target/surefire-reports/TEST-| |g" | sed -e "s|\.xml||g"`
  675. # With -fn mvn always exits with a 0 exit code. Because of this we need to
  676. # find the errors instead of using the exit code. We assume that if the build
  677. # failed a -1 is already given for that case
  678. if [[ -n "$module_failed_tests" ]] ; then
  679. failed_tests="${failed_tests}
  680. ${module_failed_tests}"
  681. fi
  682. cd -
  683. done
  684. if [[ -n "$failed_tests" ]] ; then
  685. JIRA_COMMENT="$JIRA_COMMENT
  686. {color:red}-1 core tests{color}. The patch failed these unit tests in $modules:
  687. $failed_tests"
  688. return 1
  689. fi
  690. JIRA_COMMENT="$JIRA_COMMENT
  691. {color:green}+1 core tests{color}. The patch passed unit tests in $modules."
  692. return 0
  693. }
  694. ###############################################################################
  695. # Find the maven module containing the given file.
  696. findModule (){
  697. dir=`dirname $1`
  698. while [ 1 ]
  699. do
  700. if [ -f "$dir/pom.xml" ]
  701. then
  702. echo $dir
  703. return
  704. else
  705. dir=`dirname $dir`
  706. fi
  707. done
  708. }
  709. findModules () {
  710. # Come up with a list of changed files into $TMP
  711. TMP=/tmp/tmp.paths.$$
  712. $GREP '^+++ \|^--- ' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
  713. # if all of the lines start with a/ or b/, then this is a git patch that
  714. # was generated without --no-prefix
  715. if ! $GREP -qv '^a/\|^b/' $TMP ; then
  716. sed -i -e 's,^[ab]/,,' $TMP
  717. fi
  718. # Now find all the modules that were changed
  719. TMP_MODULES=/tmp/tmp.modules.$$
  720. for file in $(cut -f 1 $TMP | sort | uniq); do
  721. echo $(findModule $file) >> $TMP_MODULES
  722. done
  723. rm $TMP
  724. # Filter out modules without code
  725. CHANGED_MODULES=""
  726. for module in $(cat $TMP_MODULES | sort | uniq); do
  727. $GREP "<packaging>pom</packaging>" $module/pom.xml > /dev/null
  728. if [ "$?" != 0 ]; then
  729. CHANGED_MODULES="$CHANGED_MODULES $module"
  730. fi
  731. done
  732. rm $TMP_MODULES
  733. echo $CHANGED_MODULES
  734. }
  735. ###############################################################################
  736. ### Run the test-contrib target
  737. runContribTests () {
  738. echo ""
  739. echo ""
  740. echo "======================================================================"
  741. echo "======================================================================"
  742. echo " Running contrib tests."
  743. echo "======================================================================"
  744. echo "======================================================================"
  745. echo ""
  746. echo ""
  747. if [[ `$GREP -c 'test-contrib' build.xml` == 0 ]] ; then
  748. echo "No contrib tests in this project."
  749. return 0
  750. fi
  751. ### Kill any rogue build processes from the last attempt
  752. $PS auxwww | $GREP ${PROJECT_NAME}PatchProcess | $AWK '{print $2}' | /usr/bin/xargs -t -I {} /bin/kill -9 {} > /dev/null
  753. #echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=no test-contrib"
  754. #$ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=no test-contrib
  755. echo "NOP"
  756. if [[ $? != 0 ]] ; then
  757. JIRA_COMMENT="$JIRA_COMMENT
  758. {color:red}-1 contrib tests{color}. The patch failed contrib unit tests."
  759. return 1
  760. fi
  761. JIRA_COMMENT="$JIRA_COMMENT
  762. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests."
  763. return 0
  764. }
  765. ###############################################################################
  766. ### Run the inject-system-faults target
  767. checkInjectSystemFaults () {
  768. echo ""
  769. echo ""
  770. echo "======================================================================"
  771. echo "======================================================================"
  772. echo " Checking the integrity of system test framework code."
  773. echo "======================================================================"
  774. echo "======================================================================"
  775. echo ""
  776. echo ""
  777. ### Kill any rogue build processes from the last attempt
  778. $PS auxwww | $GREP ${PROJECT_NAME}PatchProcess | $AWK '{print $2}' | /usr/bin/xargs -t -I {} /bin/kill -9 {} > /dev/null
  779. #echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=no -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME inject-system-faults"
  780. #$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=no -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME inject-system-faults
  781. echo "NOP"
  782. return 0
  783. if [[ $? != 0 ]] ; then
  784. JIRA_COMMENT="$JIRA_COMMENT
  785. {color:red}-1 system test framework{color}. The patch failed system test framework compile."
  786. return 1
  787. fi
  788. JIRA_COMMENT="$JIRA_COMMENT
  789. {color:green}+1 system test framework{color}. The patch passed system test framework compile."
  790. return 0
  791. }
  792. ###############################################################################
  793. ### Submit a comment to the defect's Jira
  794. submitJiraComment () {
  795. local result=$1
  796. ### Do not output the value of JIRA_COMMENT_FOOTER when run by a developer
  797. if [[ $JENKINS == "false" ]] ; then
  798. JIRA_COMMENT_FOOTER=""
  799. fi
  800. if [[ $result == 0 ]] ; then
  801. comment="{color:green}+1 overall{color}. $JIRA_COMMENT
  802. $JIRA_COMMENT_FOOTER"
  803. else
  804. comment="{color:red}-1 overall{color}. $JIRA_COMMENT
  805. $JIRA_COMMENT_FOOTER"
  806. fi
  807. ### Output the test result to the console
  808. echo "
  809. $comment"
  810. if [[ $JENKINS == "true" ]] ; then
  811. echo ""
  812. echo ""
  813. echo "======================================================================"
  814. echo "======================================================================"
  815. echo " Adding comment to Jira."
  816. echo "======================================================================"
  817. echo "======================================================================"
  818. echo ""
  819. echo ""
  820. ### Update Jira with a comment
  821. export USER=hudson
  822. $JIRACLI -s https://issues.apache.org/jira -a addcomment -u hadoopqa -p $JIRA_PASSWD --comment "$comment" --issue $defect
  823. $JIRACLI -s https://issues.apache.org/jira -a logout -u hadoopqa -p $JIRA_PASSWD
  824. fi
  825. }
  826. ###############################################################################
  827. ### Cleanup files
  828. cleanupAndExit () {
  829. local result=$1
  830. if [[ $JENKINS == "true" ]] ; then
  831. if [ -e "$PATCH_DIR" ] ; then
  832. mv $PATCH_DIR $BASEDIR
  833. fi
  834. fi
  835. echo ""
  836. echo ""
  837. echo "======================================================================"
  838. echo "======================================================================"
  839. echo " Finished build."
  840. echo "======================================================================"
  841. echo "======================================================================"
  842. echo ""
  843. echo ""
  844. exit $result
  845. }
  846. ###############################################################################
  847. ###############################################################################
  848. ###############################################################################
  849. JIRA_COMMENT=""
  850. JIRA_COMMENT_FOOTER="Console output: $BUILD_URL/console
  851. This message is automatically generated."
  852. ### Check if arguments to the script have been specified properly or not
  853. parseArgs $@
  854. cd $BASEDIR
  855. checkout
  856. RESULT=$?
  857. if [[ $JENKINS == "true" ]] ; then
  858. if [[ $RESULT != 0 ]] ; then
  859. exit 100
  860. fi
  861. fi
  862. downloadPatch
  863. verifyPatch
  864. (( RESULT = RESULT + $? ))
  865. if [[ $RESULT != 0 ]] ; then
  866. submitJiraComment 1
  867. cleanupAndExit 1
  868. fi
  869. buildWithPatch
  870. checkAuthor
  871. (( RESULT = RESULT + $? ))
  872. if [[ $JENKINS == "true" ]] ; then
  873. cleanUpXml
  874. fi
  875. checkTests
  876. (( RESULT = RESULT + $? ))
  877. applyPatch
  878. APPLY_PATCH_RET=$?
  879. (( RESULT = RESULT + $APPLY_PATCH_RET ))
  880. if [[ $APPLY_PATCH_RET != 0 ]] ; then
  881. submitJiraComment 1
  882. cleanupAndExit 1
  883. fi
  884. checkJavacWarnings
  885. JAVAC_RET=$?
  886. #2 is returned if the code could not compile
  887. if [[ $JAVAC_RET == 2 ]] ; then
  888. submitJiraComment 1
  889. cleanupAndExit 1
  890. fi
  891. (( RESULT = RESULT + $JAVAC_RET ))
  892. checkJavadocWarnings
  893. (( RESULT = RESULT + $? ))
  894. ### Checkstyle not implemented yet
  895. #checkStyle
  896. #(( RESULT = RESULT + $? ))
  897. buildAndInstall
  898. checkEclipseGeneration
  899. (( RESULT = RESULT + $? ))
  900. checkFindbugsWarnings
  901. (( RESULT = RESULT + $? ))
  902. checkReleaseAuditWarnings
  903. (( RESULT = RESULT + $? ))
  904. ### Run tests for Jenkins or if explictly asked for by a developer
  905. if [[ $JENKINS == "true" || $RUN_TESTS == "true" ]] ; then
  906. runTests
  907. (( RESULT = RESULT + $? ))
  908. runContribTests
  909. (( RESULT = RESULT + $? ))
  910. fi
  911. checkInjectSystemFaults
  912. (( RESULT = RESULT + $? ))
  913. JIRA_COMMENT_FOOTER="Test results: $BUILD_URL/testReport/
  914. $JIRA_COMMENT_FOOTER"
  915. submitJiraComment $RESULT
  916. cleanupAndExit $RESULT