浏览代码

MAPREDUCE-7288. Fix TestLongLong#testRightShift (#2183)

(cherry picked from commit dc5470ae86b96d6f84abd7354c3c056d3627871b)
Wanqiang Ji 4 年之前
父节点
当前提交
ea7e41e29e

+ 14 - 18
hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/pi/math/TestLongLong.java

@@ -53,32 +53,28 @@ public class TestLongLong {
     verifyMultiplication(max, max);
   }
 
-  static void verifyRightShift(long a, long b) {
+  @Test
+  public void testRightShift() {
+    for(int i = 0; i < 1000; i++) {
+      final long a = nextPositiveLong();
+      final long b = nextPositiveLong();
+      verifyRightShift(a, b);
+    }
+  }
+
+  private static void verifyRightShift(long a, long b) {
     final LongLong ll = new LongLong().set(a, b);
     final BigInteger bi = ll.toBigInteger();
 
-    for (int i = 0; i < LongLong.SIZE >> 1; i++) {
-      final long result = ll.shiftRight(i) & MASK;
-      final long expected = bi.shiftRight(i).longValue() & MASK;
-      final String s = String.format(
-          "\na = %x\nb = %x\nll= " + ll + "\nbi= " + bi.toString(16) + "\n", a,
-          b);
-      Assert.assertEquals(s, expected, result);
-    }
-
     final String s = String.format(
         "\na = %x\nb = %x\nll= " + ll + "\nbi= " + bi.toString(16) + "\n", a,
         b);
-    //System.out.println(s);
     Assert.assertEquals(s, bi, ll.toBigInteger());
-  }
 
-  @Test
-  public void testRightShift() {
-    for(int i = 0; i < 1000; i++) {
-      final long a = nextPositiveLong();
-      final long b = nextPositiveLong();
-      verifyMultiplication(a, b);
+    for (int i = 0; i < LongLong.SIZE >> 1; i++) {
+      final long result = ll.shiftRight(i) & MASK;
+      final long expected = bi.shiftRight(i).longValue() & MASK;
+      Assert.assertEquals(s, expected, result);
     }
   }
 }