Explorar o código

HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun)

Vinayakumar B %!s(int64=10) %!d(string=hai) anos
pai
achega
e5e492a963

+ 3 - 0
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

@@ -658,6 +658,9 @@ Release 2.8.0 - UNRELEASED
 
 
     HDFS-8174. Update replication count to live rep count in fsck report. (J.Andreina)
     HDFS-8174. Update replication count to live rep count in fsck report. (J.Andreina)
 
 
+    HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun()
+    (Sanghyun Yun via vinayakumarb)
+
 Release 2.7.1 - UNRELEASED
 Release 2.7.1 - UNRELEASED
 
 
   INCOMPATIBLE CHANGES
   INCOMPATIBLE CHANGES

+ 2 - 1
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java

@@ -320,8 +320,9 @@ public class BootstrapStandby implements Tool, Configurable {
       image.saveDigestAndRenameCheckpointImage(NameNodeFile.IMAGE, imageTxId,
       image.saveDigestAndRenameCheckpointImage(NameNodeFile.IMAGE, imageTxId,
           hash);
           hash);
     } catch (IOException ioe) {
     } catch (IOException ioe) {
-      image.close();
       throw ioe;
       throw ioe;
+    } finally {
+      image.close();
     }
     }
     return 0;
     return 0;
   }
   }