JournalManager, BackupJournalManager, FileJournalManager should not be public. BackupJournalManager needs JavaDoc.

Part of response to Konstantin's review.


git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/HDFS-1073@1150895 13f79535-47bb-0310-9956-ffa450edef68

hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java

@@ -22,7 +22,11 @@ import java.io.IOException;
 import org.apache.hadoop.hdfs.server.namenode.NNStorageArchivalManager.StorageArchiver;
 import org.apache.hadoop.hdfs.server.protocol.NamenodeRegistration;
 
-public class BackupJournalManager implements JournalManager {
+/**
+ * A JournalManager implementation that uses RPCs to log transactions
+ * to a BackupNode.
+ */
+class BackupJournalManager implements JournalManager {
 
   private final NamenodeRegistration nnReg;
   private final NamenodeRegistration bnReg;

hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java

@@ -39,7 +39,7 @@ import com.google.common.base.Preconditions;
  * Note: this class is not thread-safe and should be externally
  * synchronized.
  */
-public class FileJournalManager implements JournalManager {
+class FileJournalManager implements JournalManager {
   private static final Log LOG = LogFactory.getLog(FileJournalManager.class);
 
   private final StorageDirectory sd;

hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/JournalManager.java

@@ -28,7 +28,7 @@ import org.apache.hadoop.hdfs.server.namenode.NNStorageArchivalManager.StorageAr
  * each conceptual place of storage corresponds to exactly one instance of
  * this class, which is created when the EditLog is first opened.
  */
-public interface JournalManager {
+interface JournalManager {
   /**
    * Begin writing to a new segment of the log stream, which starts at
    * the given transaction ID.