HADOOP-4253. Fix various warnings generated by findbugs.

Following deprecated methods in RawLocalFileSystem are removed:
  public String getName()
  public void lock(Path p, boolean shared)
  public void release(Path p) 
(Suresh Srinivas via johan)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@702086 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -7,6 +7,13 @@ Trunk (unreleased changes)
     HADOOP-4210. Fix findbugs warnings for equals implementations of mapred ID
     classes. Removed public, static ID::read and ID::forName; made ID an
     abstract class. (Suresh Srinivas via cdouglas)
+    
+    HADOOP-4253. Fix various warnings generated by findbugs. 
+    Following deprecated methods in RawLocalFileSystem are removed:
+  	  public String getName()
+  	  public void lock(Path p, boolean shared)
+  	  public void release(Path p) 
+    (Suresh Srinivas via johan)
 
   NEW FEATURES
 

src/core/org/apache/hadoop/conf/Configuration.java

@@ -192,11 +192,18 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
       LOG.debug(StringUtils.stringifyException
                 (new IOException("config(config)")));
     }
-    this.resources = (ArrayList)other.resources.clone();
-    if (other.properties != null)
-      this.properties = (Properties)other.properties.clone();
-    if (other.overlay!=null)
-      this.overlay = (Properties)other.overlay.clone();
+   
+   this.resources = (ArrayList)other.resources.clone();
+   synchronized(other) {
+     if (other.properties != null) {
+       this.properties = (Properties)other.properties.clone();
+     }
+
+     if (other.overlay!=null) {
+       this.overlay = (Properties)other.overlay.clone();
+     }
+   }
+   
     this.finalParameters = new HashSet<String>(other.finalParameters);
   }
 

src/core/org/apache/hadoop/fs/ChecksumFileSystem.java

@@ -484,10 +484,7 @@ public abstract class ChecksumFileSystem extends FilterFileSystem {
     throws IOException {
     if (!fs.isDirectory(src)) { // source is a file
       fs.copyToLocalFile(src, dst);
-      FileSystem localFs = getLocal(getConf());
-      if (localFs instanceof ChecksumFileSystem) {
-        localFs = ((ChecksumFileSystem) localFs).getRawFileSystem();
-      }
+      FileSystem localFs = getLocal(getConf()).getRawFileSystem();
       if (localFs.isDirectory(dst)) {
         dst = new Path(dst, src.getName());
       }

src/core/org/apache/hadoop/fs/RawLocalFileSystem.java

@@ -37,11 +37,6 @@ import org.apache.hadoop.util.Shell;
 public class RawLocalFileSystem extends FileSystem {
   static final URI NAME = URI.create("file:///");
   private Path workingDir;
-  TreeMap<File, FileInputStream> sharedLockDataSet =
-    new TreeMap<File, FileInputStream>();
-  TreeMap<File, FileOutputStream> nonsharedLockDataSet =
-    new TreeMap<File, FileOutputStream>();
-  TreeMap<File, FileLock> lockObjSet = new TreeMap<File, FileLock>();
   
   public RawLocalFileSystem() {
     workingDir = new Path(System.getProperty("user.dir")).makeQualified(this);
@@ -56,9 +51,6 @@ public class RawLocalFileSystem extends FileSystem {
     return new File(path.toUri().getPath());
   }
 
-  /** @deprecated */
-  public String getName() { return "local"; }
-
   public URI getUri() { return NAME; }
   
   public void initialize(URI uri, Configuration conf) {
@@ -336,58 +328,6 @@ public class RawLocalFileSystem extends FileSystem {
     return workingDir;
   }
   
-  /** @deprecated */ @Deprecated
-    public void lock(Path p, boolean shared) throws IOException {
-    File f = pathToFile(p);
-    f.createNewFile();
-    
-    if (shared) {
-      FileInputStream lockData = new FileInputStream(f);
-      FileLock lockObj =
-        lockData.getChannel().lock(0L, Long.MAX_VALUE, shared);
-      synchronized (this) {
-        sharedLockDataSet.put(f, lockData);
-        lockObjSet.put(f, lockObj);
-      }
-    } else {
-      FileOutputStream lockData = new FileOutputStream(f);
-      FileLock lockObj = lockData.getChannel().lock(0L, Long.MAX_VALUE, shared);
-      synchronized (this) {
-        nonsharedLockDataSet.put(f, lockData);
-        lockObjSet.put(f, lockObj);
-      }
-    }
-  }
-  
-  /** @deprecated */ @Deprecated
-    public void release(Path p) throws IOException {
-    File f = pathToFile(p);
-    
-    FileLock lockObj;
-    FileInputStream sharedLockData;
-    FileOutputStream nonsharedLockData;
-    synchronized (this) {
-      lockObj = lockObjSet.remove(f);
-      sharedLockData = sharedLockDataSet.remove(f);
-      nonsharedLockData = nonsharedLockDataSet.remove(f);
-    }
-    
-    if (lockObj == null) {
-      throw new IOException("Given target not held as lock");
-    }
-    if (sharedLockData == null && nonsharedLockData == null) {
-      throw new IOException("Given target not held as lock");
-    }
-    
-    lockObj.release();
-    
-    if (sharedLockData != null) {
-      sharedLockData.close();
-    } else {
-      nonsharedLockData.close();
-    }
-  }
-  
   // In the case of the local filesystem, we can just rename the file.
   public void moveFromLocalFile(Path src, Path dst) throws IOException {
     rename(src, dst);

src/core/org/apache/hadoop/record/compiler/CGenerator.java

@@ -42,26 +42,30 @@ class CGenerator extends CodeGenerator {
     throws IOException {
     name = new File(destDir, (new File(name)).getName()).getAbsolutePath();
     FileWriter cc = new FileWriter(name+".c");
-    FileWriter hh = new FileWriter(name+".h");
-    
-    hh.write("#ifndef __"+name.toUpperCase().replace('.','_')+"__\n");
-    hh.write("#define __"+name.toUpperCase().replace('.','_')+"__\n");
-    hh.write("#include \"recordio.h\"\n");
-    for (Iterator<JFile> iter = ilist.iterator(); iter.hasNext();) {
-      hh.write("#include \""+iter.next().getName()+".h\"\n");
-    }
-    
-    cc.write("#include \""+name+".h\"\n");
-    
-    /*
-      for (Iterator<JRecord> iter = rlist.iterator(); iter.hasNext();) {
-      iter.next().genCppCode(hh, cc);
+    try {
+      FileWriter hh = new FileWriter(name+".h");
+      try {
+        hh.write("#ifndef __"+name.toUpperCase().replace('.','_')+"__\n");
+        hh.write("#define __"+name.toUpperCase().replace('.','_')+"__\n");
+        hh.write("#include \"recordio.h\"\n");
+        for (Iterator<JFile> iter = ilist.iterator(); iter.hasNext();) {
+          hh.write("#include \""+iter.next().getName()+".h\"\n");
+        }
+
+        cc.write("#include \""+name+".h\"\n");
+
+        /*
+        for (Iterator<JRecord> iter = rlist.iterator(); iter.hasNext();) {
+        iter.next().genCppCode(hh, cc);
+        }
+         */
+
+        hh.write("#endif //"+name.toUpperCase().replace('.','_')+"__\n");
+      } finally {
+        hh.close();
       }
-    */
-    
-    hh.write("#endif //"+name.toUpperCase().replace('.','_')+"__\n");
-    
-    hh.close();
-    cc.close();
+    } finally {
+      cc.close();
+    }
   }
 }

src/core/org/apache/hadoop/record/compiler/CppGenerator.java

@@ -41,28 +41,34 @@ class CppGenerator extends CodeGenerator {
                ArrayList<JRecord> rlist, String destDir, ArrayList<String> options)
     throws IOException {
     name = new File(destDir, (new File(name)).getName()).getAbsolutePath();
+
     FileWriter cc = new FileWriter(name+".cc");
-    FileWriter hh = new FileWriter(name+".hh");
-    
-    String fileName = (new File(name)).getName();
-    hh.write("#ifndef __"+fileName.toUpperCase().replace('.','_')+"__\n");
-    hh.write("#define __"+fileName.toUpperCase().replace('.','_')+"__\n");
-    hh.write("#include \"recordio.hh\"\n");
-    hh.write("#include \"recordTypeInfo.hh\"\n");
-    for (Iterator<JFile> iter = ilist.iterator(); iter.hasNext();) {
-      hh.write("#include \""+iter.next().getName()+".hh\"\n");
-    }
-    
-    cc.write("#include \""+fileName+".hh\"\n");
-    cc.write("#include \"utils.hh\"\n");
-    
-    for (Iterator<JRecord> iter = rlist.iterator(); iter.hasNext();) {
-      iter.next().genCppCode(hh, cc, options);
+    try {
+      FileWriter hh = new FileWriter(name+".hh");
+      
+      try {
+        String fileName = (new File(name)).getName();
+        hh.write("#ifndef __"+fileName.toUpperCase().replace('.','_')+"__\n");
+        hh.write("#define __"+fileName.toUpperCase().replace('.','_')+"__\n");
+        hh.write("#include \"recordio.hh\"\n");
+        hh.write("#include \"recordTypeInfo.hh\"\n");
+        for (Iterator<JFile> iter = ilist.iterator(); iter.hasNext();) {
+          hh.write("#include \""+iter.next().getName()+".hh\"\n");
+        }
+        
+        cc.write("#include \""+fileName+".hh\"\n");
+        cc.write("#include \"utils.hh\"\n");
+        
+        for (Iterator<JRecord> iter = rlist.iterator(); iter.hasNext();) {
+          iter.next().genCppCode(hh, cc, options);
+        }
+        
+        hh.write("#endif //"+fileName.toUpperCase().replace('.','_')+"__\n");
+      } finally {
+        hh.close();
+      }
+    } finally {
+      cc.close();
     }
-    
-    hh.write("#endif //"+fileName.toUpperCase().replace('.','_')+"__\n");
-    
-    hh.close();
-    cc.close();
   }
 }

src/core/org/apache/hadoop/record/compiler/JRecord.java

@@ -155,6 +155,8 @@ public class JRecord extends JCompType {
       String pkg = module;
       String pkgpath = pkg.replaceAll("\\.", "/");
       File pkgdir = new File(destDir, pkgpath);
+
+      final File jfile = new File(pkgdir, name+".java");
       if (!pkgdir.exists()) {
         // create the pkg directory
         boolean ret = pkgdir.mkdirs();
@@ -165,9 +167,7 @@ public class JRecord extends JCompType {
         // not a directory
         throw new IOException(pkgpath+" is not a directory.");
       }
-      File jfile = new File(pkgdir, name+".java");
-      FileWriter jj = new FileWriter(jfile);
-      
+
       CodeBuffer cb = new CodeBuffer();
       cb.append("// File generated by hadoop record compiler. Do not edit.\n");
       cb.append("package "+module+";\n\n");
@@ -456,8 +456,12 @@ public class JRecord extends JCompType {
       cb.append("}\n");
       cb.append("}\n");
 
-      jj.write(cb.toString());
-      jj.close();
+      FileWriter jj = new FileWriter(jfile);
+      try {
+        jj.write(cb.toString());
+      } finally {
+        jj.close();
+      }
     }
   }
   

src/mapred/org/apache/hadoop/mapred/TaskTracker.java

@@ -551,7 +551,7 @@ public class TaskTracker
       
     @Override
     public void run() {
-      LOG.info("Starting thread: " + getName());
+      LOG.info("Starting thread: " + this.getName());
         
       while (true) {
         try {
@@ -561,7 +561,7 @@ public class TaskTracker
               try {
                 runningJobs.wait();
               } catch (InterruptedException e) {
-                LOG.info("Shutting down: " + getName());
+                LOG.info("Shutting down: " + this.getName());
                 return;
               }
             }
@@ -592,7 +592,7 @@ public class TaskTracker
                 waitingOn.wait(heartbeatInterval);
               }
             } catch (InterruptedException ie) {
-              LOG.info("Shutting down: " + getName());
+              LOG.info("Shutting down: " + this.getName());
               return;
             }
           }