|
|
@@ -0,0 +1,126 @@
|
|
|
+/**
|
|
|
+ * Licensed to the Apache Software Foundation (ASF) under one
|
|
|
+ * or more contributor license agreements. See the NOTICE file
|
|
|
+ * distributed with this work for additional information
|
|
|
+ * regarding copyright ownership. The ASF licenses this file
|
|
|
+ * to you under the Apache License, Version 2.0 (the
|
|
|
+ * "License"); you may not use this file except in compliance
|
|
|
+ * with the License. You may obtain a copy of the License at
|
|
|
+ *
|
|
|
+ * http://www.apache.org/licenses/LICENSE-2.0
|
|
|
+ *
|
|
|
+ * Unless required by applicable law or agreed to in writing, software
|
|
|
+ * distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
+ * See the License for the specific language governing permissions and
|
|
|
+ * limitations under the License.
|
|
|
+ */
|
|
|
+package org.apache.hadoop.hdfs;
|
|
|
+
|
|
|
+import static org.junit.Assert.*;
|
|
|
+
|
|
|
+import java.util.ArrayList;
|
|
|
+import java.util.Arrays;
|
|
|
+import java.util.Collections;
|
|
|
+import java.util.Comparator;
|
|
|
+import java.util.List;
|
|
|
+
|
|
|
+import org.apache.commons.lang.ClassUtils;
|
|
|
+import org.apache.hadoop.hdfs.protocol.ReconfigurationProtocol;
|
|
|
+import org.apache.hadoop.hdfs.qjournal.server.JournalNodeRpcServer;
|
|
|
+import org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer;
|
|
|
+import org.apache.hadoop.hdfs.server.datanode.DataNode;
|
|
|
+import org.apache.hadoop.security.authorize.Service;
|
|
|
+
|
|
|
+import org.junit.BeforeClass;
|
|
|
+import org.junit.Rule;
|
|
|
+import org.junit.Test;
|
|
|
+import org.junit.rules.TestName;
|
|
|
+import org.junit.runner.RunWith;
|
|
|
+import org.junit.runners.Parameterized;
|
|
|
+import org.junit.runners.Parameterized.Parameters;
|
|
|
+
|
|
|
+import org.slf4j.Logger;
|
|
|
+import org.slf4j.LoggerFactory;
|
|
|
+
|
|
|
+/**
|
|
|
+ * Test suite covering HDFSPolicyProvider. We expect that it contains a
|
|
|
+ * security policy definition for every RPC protocol used in HDFS. The test
|
|
|
+ * suite works by scanning an RPC server's class to find the protocol interfaces
|
|
|
+ * it implements, and then comparing that to the protocol interfaces covered in
|
|
|
+ * HDFSPolicyProvider. This is a parameterized test repeated for multiple HDFS
|
|
|
+ * RPC server classes.
|
|
|
+ */
|
|
|
+@RunWith(Parameterized.class)
|
|
|
+public class TestHDFSPolicyProvider {
|
|
|
+
|
|
|
+ private static final Logger LOG =
|
|
|
+ LoggerFactory.getLogger(TestHDFSPolicyProvider.class);
|
|
|
+
|
|
|
+ private static List<Class<?>> policyProviderProtocols;
|
|
|
+
|
|
|
+ private static final Comparator<Class<?>> CLASS_NAME_COMPARATOR =
|
|
|
+ new Comparator<Class<?>>() {
|
|
|
+ @Override
|
|
|
+ public int compare(Class<?> lhs, Class<?> rhs) {
|
|
|
+ return lhs.getName().compareTo(rhs.getName());
|
|
|
+ }
|
|
|
+ };
|
|
|
+
|
|
|
+ @Rule
|
|
|
+ public TestName testName = new TestName();
|
|
|
+
|
|
|
+ private final Class<?> rpcServerClass;
|
|
|
+
|
|
|
+ @BeforeClass
|
|
|
+ public static void initialize() {
|
|
|
+ Service[] services = new HDFSPolicyProvider().getServices();
|
|
|
+ policyProviderProtocols = new ArrayList<>(services.length);
|
|
|
+ for (Service service : services) {
|
|
|
+ policyProviderProtocols.add(service.getProtocol());
|
|
|
+ }
|
|
|
+ Collections.sort(policyProviderProtocols, CLASS_NAME_COMPARATOR);
|
|
|
+ }
|
|
|
+
|
|
|
+ public TestHDFSPolicyProvider(Class<?> rpcServerClass) {
|
|
|
+ this.rpcServerClass = rpcServerClass;
|
|
|
+ }
|
|
|
+
|
|
|
+ @Parameters(name = "protocolsForServer-{0}")
|
|
|
+ public static List<Class<?>[]> data() {
|
|
|
+ return Arrays.asList(new Class<?>[][]{
|
|
|
+ {NameNodeRpcServer.class},
|
|
|
+ {DataNode.class},
|
|
|
+ {JournalNodeRpcServer.class}
|
|
|
+ });
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ public void testPolicyProviderForServer() {
|
|
|
+ List<?> ifaces = ClassUtils.getAllInterfaces(rpcServerClass);
|
|
|
+ List<Class<?>> serverProtocols = new ArrayList<>(ifaces.size());
|
|
|
+ for (Object obj : ifaces) {
|
|
|
+ Class<?> iface = (Class<?>)obj;
|
|
|
+ // ReconfigurationProtocol is not covered in HDFSPolicyProvider
|
|
|
+ // currently, so we have a special case to skip it. This needs follow-up
|
|
|
+ // investigation.
|
|
|
+ if (iface.getSimpleName().endsWith("Protocol") &&
|
|
|
+ iface != ReconfigurationProtocol.class) {
|
|
|
+ serverProtocols.add(iface);
|
|
|
+ }
|
|
|
+ }
|
|
|
+ Collections.sort(serverProtocols, CLASS_NAME_COMPARATOR);
|
|
|
+ LOG.info("Running test {} for RPC server {}. Found server protocols {} "
|
|
|
+ + "and policy provider protocols {}.", testName.getMethodName(),
|
|
|
+ rpcServerClass.getName(), serverProtocols, policyProviderProtocols);
|
|
|
+ assertFalse("Expected to find at least one protocol in server.",
|
|
|
+ serverProtocols.isEmpty());
|
|
|
+ assertTrue(
|
|
|
+ String.format("Expected all protocols for server %s to be defined in "
|
|
|
+ + "%s. Server contains protocols %s. Policy provider contains "
|
|
|
+ + "protocols %s.", rpcServerClass.getName(),
|
|
|
+ HDFSPolicyProvider.class.getName(), serverProtocols,
|
|
|
+ policyProviderProtocols),
|
|
|
+ policyProviderProtocols.containsAll(serverProtocols));
|
|
|
+ }
|
|
|
+}
|
Chris Nauroth