Browse Source

MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1234148 13f79535-47bb-0310-9956-ffa450edef68
Mahadev Konar 13 năm trước cách đây
mục cha
commit
b49aae0635

+ 3 - 0
hadoop-mapreduce-project/CHANGES.txt

@@ -520,6 +520,9 @@ Release 0.23.1 - Unreleased
     MAPREDUCE-3698. Client cannot talk to the history server in secure mode.
     (mahadev)
 
+    MAPREDUCE-3689. RM web UI doesn't handle newline in job name.
+    (Thomas Graves via mahadev)
+
 Release 0.23.0 - 2011-11-01 
 
   INCOMPATIBLE CHANGES

+ 1 - 1
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java

@@ -40,7 +40,7 @@ public class Jsons {
 
   public static PrintWriter appendProgressBar(PrintWriter out,
                                                   float progress) {
-    return appendProgressBar(out, String.format("%.1f", progress * 100));
+    return appendProgressBar(out, String.format("%.1f", progress));
   }
 
   public static PrintWriter appendSortable(PrintWriter out, Object value) {

+ 1 - 1
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

@@ -66,7 +66,7 @@ class AppsList implements ToJSON {
       appendLink(out, appInfo.getAppId(), rc.prefix(), "app",
           appInfo.getAppId()).append(_SEP).
           append(escapeHtml(appInfo.getUser())).append(_SEP).
-          append(escapeHtml(appInfo.getName())).append(_SEP).
+          append(escapeJavaScript(escapeHtml(appInfo.getName()))).append(_SEP).
           append(escapeHtml(appInfo.getQueue())).append(_SEP).
           append(appInfo.getState()).append(_SEP).
           append(appInfo.getFinalStatus()).append(_SEP);