YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe

(cherry picked from commit f967fd2f21791c5c4a5a090cc14ee88d155d2e2b)

Conflicts:
	hadoop-yarn-project/CHANGES.txt

hadoop-yarn-project/CHANGES.txt

@@ -17,6 +17,9 @@ Release 2.7.1 - UNRELEASED
     YARN-3462. Patches applied for YARN-2424 are inconsistent between
     trunk and branch-2. (Naganarasimha G R via harsh)
 
+    YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf
+    without making a copy. (Jason Lowe via jianhe)
+
 Release 2.7.0 - UNRELEASED
 
   INCOMPATIBLE CHANGES

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java

@@ -67,7 +67,7 @@ public class ContainerManagementProtocolProxy {
 
   public ContainerManagementProtocolProxy(Configuration conf,
       NMTokenCache nmTokenCache) {
-    this.conf = conf;
+    this.conf = new Configuration(conf);
     this.nmTokenCache = nmTokenCache;
 
     maxConnectedNMs =
@@ -88,7 +88,7 @@ public class ContainerManagementProtocolProxy {
       cmProxy = Collections.emptyMap();
       // Connections are not being cached so ensure connections close quickly
       // to avoid creating thousands of RPC client threads on large clusters.
-      conf.setInt(
+      this.conf.setInt(
           CommonConfigurationKeysPublic.IPC_CLIENT_CONNECTION_MAXIDLETIME_KEY,
           0);
     }