Fix findbugs warnings in mr-client modules part 2 (mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/MR-279@1154062 13f79535-47bb-0310-9956-ffa450edef68

mapreduce/CHANGES.txt

@@ -4,6 +4,8 @@ Trunk (unreleased changes)
 
   MAPREDUCE-279
  
+    Fix findbugs warnings in mr-client modules part 2 (mahadev)
+ 
     Fix findbugs warnings in mr-client modules, part 1  (mahadev) 
   
     MAPREDUCE-2776. Fix some of the yarn findbug warnings. (siddharth 

mapreduce/dev-support/findbugs-exclude.xml

@@ -388,4 +388,57 @@
        <Field name="started" />
        <Bug pattern="IS2_INCONSISTENT_SYNC" />
     </Match>
+  
+   <!-- Yarn excludes -->
+  <Match>
+    <Class name="org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl" />
+    <Method name="computeSlotMillis" />
+    <Bug pattern="DB_DUPLICATE_BRACHES" />
+  </Match>
+
+  <Match>
+    <Class name="org.apache.hadoop.mapreduce.v2.app.MRAppMaster$1" />
+    <Bug pattern="DM_EXIT" />
+  </Match>
+
+  <Match>
+    <Class name="org.apache.hadoop.mapred.LocalContainerLauncher$SubtaskRunner" />
+    <Bug pattern="DM_EXIT" />
+  </Match>
+  <Match>
+    <Class name="~org\.apache\.hadoop\.mapreduce\.v2\.app\.job\.impl\.TaskImpl.*" />
+    <Bug pattern="BC_UNCONFIRMED_CAST" />
+  </Match>
+
+  <Match>
+    <Class name="~org\.apache\.hadoop\.mapreduce\.v2\.app\.job\.impl\.JobImpl.*" />
+    <Bug pattern="BC_UNCONFIRMED_CAST" />
+  </Match>
+  <Match>
+    <Class name="~org\.apache\.hadoop\.mapreduce\.v2\.app\.job\.impl\.TaskAttemptImpl.*" />
+    <Bug pattern="BC_UNCONFIRMED_CAST" />
+  </Match>
+  <Match>
+    <Class name="~org\.apache\.hadoop\.mapreduce\.v2\.app\.recover\.RecoveryService" />
+    <Bug pattern="BC_UNCONFIRMED_CAST" />
+  </Match>
+
+  <Match>
+    <Class name="~org\.apache\.hadoop\.mapreduce\.v2\.app\.rm\.RMContainerAllocator" />
+    <Bug pattern="BC_UNCONFIRMED_CAST" />
+  </Match>
+
+  <Match>
+    <Class name="org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl" />
+    <Method name="computeSlotMillis" />
+   <Bug pattern="DB_DUPLICATE_BRANCHES" />
+  </Match>
+
+   <Match>
+    <Package name="org.apache.hadoop.yarn.proto" />
+  </Match>
+  <Match>
+    <Class name="~org\.apache\.hadoop\.mapreduce\.v2\.proto.*" />
+  </Match>
+
  </FindBugsFilter>

mapreduce/mr-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/speculate/LegacyTaskRuntimeEstimator.java

@@ -112,8 +112,9 @@ public class LegacyTaskRuntimeEstimator extends StartEndTimesBase {
         estimate = (long) ((timestamp - start) / Math.max(0.0001, status.progress));
         varianceEstimate = (long) (estimate * status.progress / 10);
       }
-
-      estimateContainer.set(estimate);
+      if (estimateContainer != null) {
+        estimateContainer.set(estimate);
+      }
       estimateVarianceContainer.set(varianceEstimate);
     }
   }

mapreduce/pom.xml

@@ -19,7 +19,7 @@
     <install.pom>${project.build.directory}/saner-pom.xml</install.pom>
     <install.file>${install.pom}</install.file>
     <fork.mode>once</fork.mode>
-    <mr.basedir>=${basedir}</mr.basedir>
+    <mr.basedir>${basedir}</mr.basedir>
   </properties>
 
   <repositories>

mapreduce/yarn/pom.xml

@@ -348,16 +348,16 @@
           </execution>
         </executions>
       </plugin>
-	  <plugin>
+       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-		<configuration>
+         <configuration>
           <findbugsXmlOutput>true</findbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <excludeFilterFile>${yarn.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
           <effort>Max</effort>
         </configuration>
-	  </plugin>
+      </plugin>
     </plugins>
   </build>