Bläddra i källkod

HDDS-762. Fix unit test failure for TestContainerSQLCli & TestSCMMetrics.
Contributed by Mukul Kumar Singh.

Anu Engineer 6 år sedan
förälder
incheckning
9cc2ce1645

+ 7 - 5
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerStateManagerIntegration.java

@@ -40,12 +40,13 @@ import org.junit.Before;
 import org.junit.Test;
 import org.junit.Test;
 
 
 import java.io.IOException;
 import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
 import java.util.NavigableSet;
 import java.util.NavigableSet;
 import java.util.Random;
 import java.util.Random;
 import org.slf4j.event.Level;
 import org.slf4j.event.Level;
 
 
+import static org.apache.hadoop.hdds.scm.ScmConfigKeys
+    .OZONE_SCM_DB_CACHE_SIZE_DEFAULT;
+
 /**
 /**
  * Tests for ContainerStateManager.
  * Tests for ContainerStateManager.
  */
  */
@@ -120,13 +121,11 @@ public class TestContainerStateManagerIntegration {
   public void testContainerStateManagerRestart() throws IOException {
   public void testContainerStateManagerRestart() throws IOException {
     // Allocate 5 containers in ALLOCATED state and 5 in CREATING state
     // Allocate 5 containers in ALLOCATED state and 5 in CREATING state
 
 
-    List<ContainerInfo> containers = new ArrayList<>();
     for (int i = 0; i < 10; i++) {
     for (int i = 0; i < 10; i++) {
       ContainerWithPipeline container = scm.getClientProtocolServer()
       ContainerWithPipeline container = scm.getClientProtocolServer()
           .allocateContainer(
           .allocateContainer(
               xceiverClientManager.getType(),
               xceiverClientManager.getType(),
               xceiverClientManager.getFactor(), containerOwner);
               xceiverClientManager.getFactor(), containerOwner);
-      containers.add(container.getContainerInfo());
       if (i >= 5) {
       if (i >= 5) {
         scm.getContainerManager().updateContainerState(container
         scm.getContainerManager().updateContainerState(container
                 .getContainerInfo().getContainerID(),
                 .getContainerInfo().getContainerID(),
@@ -134,10 +133,13 @@ public class TestContainerStateManagerIntegration {
       }
       }
     }
     }
 
 
+    cluster.getStorageContainerManager().stop();
     // New instance of ContainerStateManager should load all the containers in
     // New instance of ContainerStateManager should load all the containers in
     // container store.
     // container store.
     ContainerStateManager stateManager =
     ContainerStateManager stateManager =
-        new ContainerStateManager(conf, containerManager, selector);
+        new SCMContainerManager(conf, scm.getScmNodeManager(),
+            OZONE_SCM_DB_CACHE_SIZE_DEFAULT,
+            scm.getEventQueue()).getStateManager();
     int matchCount = stateManager
     int matchCount = stateManager
         .getMatchingContainerIDs(containerOwner,
         .getMatchingContainerIDs(containerOwner,
             xceiverClientManager.getType(), xceiverClientManager.getFactor(),
             xceiverClientManager.getType(), xceiverClientManager.getFactor(),

+ 7 - 3
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/TestCSMMetrics.java

@@ -47,6 +47,7 @@ import org.apache.hadoop.test.GenericTestUtils;
 import org.apache.hadoop.hdds.conf.OzoneConfiguration;
 import org.apache.hadoop.hdds.conf.OzoneConfiguration;
 
 
 import static org.apache.ratis.rpc.SupportedRpcType.GRPC;
 import static org.apache.ratis.rpc.SupportedRpcType.GRPC;
+import org.apache.ratis.protocol.RaftGroupId;
 import org.apache.ratis.util.CheckedBiConsumer;
 import org.apache.ratis.util.CheckedBiConsumer;
 
 
 import java.util.function.BiConsumer;
 import java.util.function.BiConsumer;
@@ -104,7 +105,8 @@ public class TestCSMMetrics {
       client.connect();
       client.connect();
 
 
       // Before Read Chunk/Write Chunk
       // Before Read Chunk/Write Chunk
-      MetricsRecordBuilder metric = getMetrics(CSMMetrics.SOURCE_NAME);
+      MetricsRecordBuilder metric = getMetrics(CSMMetrics.SOURCE_NAME +
+          RaftGroupId.valueOf(pipeline.getId().getId()).toString());
       assertCounter("NumWriteStateMachineOps", 0L, metric);
       assertCounter("NumWriteStateMachineOps", 0L, metric);
       assertCounter("NumReadStateMachineOps", 0L, metric);
       assertCounter("NumReadStateMachineOps", 0L, metric);
       assertCounter("NumApplyTransactionOps", 0L, metric);
       assertCounter("NumApplyTransactionOps", 0L, metric);
@@ -120,7 +122,8 @@ public class TestCSMMetrics {
       Assert.assertEquals(ContainerProtos.Result.SUCCESS,
       Assert.assertEquals(ContainerProtos.Result.SUCCESS,
           response.getResult());
           response.getResult());
 
 
-      metric = getMetrics(CSMMetrics.SOURCE_NAME);
+      metric = getMetrics(CSMMetrics.SOURCE_NAME +
+              RaftGroupId.valueOf(pipeline.getId().getId()).toString());
       assertCounter("NumWriteStateMachineOps", 1L, metric);
       assertCounter("NumWriteStateMachineOps", 1L, metric);
       assertCounter("NumApplyTransactionOps", 1L, metric);
       assertCounter("NumApplyTransactionOps", 1L, metric);
 
 
@@ -132,7 +135,8 @@ public class TestCSMMetrics {
       Assert.assertEquals(ContainerProtos.Result.SUCCESS,
       Assert.assertEquals(ContainerProtos.Result.SUCCESS,
           response.getResult());
           response.getResult());
 
 
-      metric = getMetrics(CSMMetrics.SOURCE_NAME);
+      metric = getMetrics(CSMMetrics.SOURCE_NAME +
+          RaftGroupId.valueOf(pipeline.getId().getId()).toString());
       assertCounter("NumReadStateMachineOps", 1L, metric);
       assertCounter("NumReadStateMachineOps", 1L, metric);
       assertCounter("NumApplyTransactionOps", 1L, metric);
       assertCounter("NumApplyTransactionOps", 1L, metric);
     } finally {
     } finally {

+ 1 - 1
hadoop-project/pom.xml

@@ -101,7 +101,7 @@
     <ldap-api.version>1.0.0-M33</ldap-api.version>
     <ldap-api.version>1.0.0-M33</ldap-api.version>
 
 
     <!-- Apache Ratis version -->
     <!-- Apache Ratis version -->
-    <ratis.version>0.3.0-2272086-SNAPSHOT</ratis.version>
+    <ratis.version>0.3.0-1d2ebee-SNAPSHOT</ratis.version>
     <jcache.version>1.0-alpha-1</jcache.version>
     <jcache.version>1.0-alpha-1</jcache.version>
     <ehcache.version>3.3.1</ehcache.version>
     <ehcache.version>3.3.1</ehcache.version>
     <hikari.version>2.4.12</hikari.version>
     <hikari.version>2.4.12</hikari.version>