Ver código fonte

HADOOP-1018. Improve documentation w.r.t handling of lost hearbeats between TaskTrackers and JobTracker.

git-svn-id: https://svn.apache.org/repos/asf/lucene/hadoop/trunk@573513 13f79535-47bb-0310-9956-ffa450edef68
Arun Murthy 18 anos atrás
pai
commit
9a1dee992c
2 arquivos alterados com 9 adições e 5 exclusões
  1. 3 0
      CHANGES.txt
  2. 6 5
      src/java/org/apache/hadoop/mapred/JobTracker.java

+ 3 - 0
CHANGES.txt

@@ -174,6 +174,9 @@ Trunk (unreleased changes)
     code in Hadoop so that you can copy from and to all of the supported file 
     systems.(Chris Douglas via omalley)
 
+    HADOOP-1018.  Improve documentation w.r.t handling of lost hearbeats between 
+    TaskTrackers and JobTracker. (acmurthy)
+
 Release 0.14.1 - 2007-09-04
 
   BUG FIXES

+ 6 - 5
src/java/org/apache/hadoop/mapred/JobTracker.java

@@ -1101,13 +1101,14 @@ public class JobTracker implements MRConstants, InterTrackerProtocol, JobSubmiss
 
       }
                 
-      // It is completely safe to ignore a 'duplicate' from a tracker
-      // since we are guaranteed that the tracker sends the same 
-      // 'heartbeat' when rpcs are lost. 
-      // {@see TaskTracker.transmitHeartbeat()}
+      // It is completely safe to not process a 'duplicate' heartbeat from a 
+      // {@link TaskTracker} since it resends the heartbeat when rpcs are lost - 
+      // @see {@link TaskTracker.transmitHeartbeat()};
+      // acknowledge it by re-sending the previous response to let the 
+      // {@link TaskTracker} go forward. 
       if (prevHeartbeatResponse.getResponseId() != responseId) {
         LOG.info("Ignoring 'duplicate' heartbeat from '" + 
-                 trackerName + "'");
+                 trackerName + "'; resending the previous 'lost' response");
         return prevHeartbeatResponse;
       }
     }