浏览代码

HDFS-16092. Avoid creating LayoutFlags redundant objects (#3150)

Viraj Jasani 3 年之前
父节点
当前提交
93a1685073

+ 5 - 5
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutFlags.java

@@ -31,14 +31,15 @@ import org.apache.hadoop.classification.InterfaceAudience;
  */
 @InterfaceAudience.Private
 public class LayoutFlags {
+
   /**
-   * Load a LayoutFlags object from a stream.
+   * Read next int from given input stream. If the value is not 0 (unsupported
+   * feature flags), throw appropriate IOException.
    *
    * @param in            The stream to read from.
-   * @throws IOException
+   * @throws IOException  If next byte read from given stream is not 0.
    */
-  public static LayoutFlags read(DataInputStream in)
-      throws IOException {
+  public static void read(DataInputStream in) throws IOException {
     int length = in.readInt();
     if (length < 0) {
       throw new IOException("The length of the feature flag section " +
@@ -47,7 +48,6 @@ public class LayoutFlags {
       throw new IOException("Found feature flags which we can't handle. " +
           "Please upgrade your software.");
     }
-    return new LayoutFlags();
   }
 
   private LayoutFlags() {