Browse Source

HADOOP-3405. Made some map/reduce internal classes non-public:
MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol,
CompletedJobStatusStore. Contributed by Enis Soztutar.


git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@659184 13f79535-47bb-0310-9956-ffa450edef68

Owen O'Malley 17 years ago
parent
commit
8e8cdece9f

+ 4 - 0
CHANGES.txt

@@ -54,6 +54,10 @@ Trunk (unreleased changes)
     HADOOP-3390. Removed deprecated ClientProtocol.abandonFileInProgress().
     (Tsz Wo (Nicholas), SZE via rangadi)
 
+    HADOOP-3405. Made some map/reduce internal classes non-public:
+    MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, 
+    CompletedJobStatusStore. (enis via omaley)
+
   NEW FEATURES
 
     HADOOP-3074. Provides a UrlStreamHandler for DFS and other FS,

+ 1 - 1
src/java/org/apache/hadoop/mapred/CompletedJobStatusStore.java

@@ -38,7 +38,7 @@ import org.apache.hadoop.fs.Path;
  * The retain time can be set with the 'persist.jobstatus.hours'
  * configuration variable (it is in hours).
  */
-public class CompletedJobStatusStore implements Runnable {
+class CompletedJobStatusStore implements Runnable {
   private boolean active;
   private String jobInfoDir;
   private long retainTime;

+ 17 - 0
src/java/org/apache/hadoop/mapred/JobProfile.java

@@ -73,6 +73,15 @@ public class JobProfile implements Writable {
     this.name = name;
   }
 
+  /**
+   * @deprecated use JobProfile(String, JobID, String, String, String) instead
+   */
+  @Deprecated
+  public JobProfile(String user, String jobid, String jobFile, String url,
+      String name) {
+    this(user, JobID.forName(jobid), jobFile, url, name);
+  }
+  
   /**
    * Get the user id.
    */
@@ -87,6 +96,14 @@ public class JobProfile implements Writable {
     return jobid;
   }
 
+  /**
+   * @deprecated use getJobID() instead
+   */
+  @Deprecated
+  public String getJobId() {
+    return jobid.toString();
+  }
+  
   /**
    * Get the configuration file for the job.
    */

+ 6 - 0
src/java/org/apache/hadoop/mapred/JobStatus.java

@@ -73,6 +73,12 @@ public class JobStatus implements Writable {
     this.user = "nobody";
   }
 
+  /**
+   * @deprecated use getJobID instead
+   */
+  @Deprecated
+  public String getJobId() { return jobid.toString(); }
+  
   /**
    * @return The jobid of the Job
    */

+ 1 - 1
src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java

@@ -27,7 +27,7 @@ import org.apache.hadoop.ipc.VersionedProtocol;
  * JobClient can use these methods to submit a Job for execution, and learn about
  * the current system status.
  */ 
-public interface JobSubmissionProtocol extends VersionedProtocol {
+interface JobSubmissionProtocol extends VersionedProtocol {
   /* 
    *Changing the versionID to 2L since the getTaskCompletionEvents method has
    *changed.

+ 1 - 1
src/java/org/apache/hadoop/mapred/MapTaskStatus.java

@@ -19,7 +19,7 @@
 package org.apache.hadoop.mapred;
 
 
-public class MapTaskStatus extends TaskStatus {
+class MapTaskStatus extends TaskStatus {
 
   public MapTaskStatus() {}
 

+ 1 - 1
src/java/org/apache/hadoop/mapred/ReduceTaskStatus.java

@@ -26,7 +26,7 @@ import java.util.List;
 
 
 
-public class ReduceTaskStatus extends TaskStatus {
+class ReduceTaskStatus extends TaskStatus {
 
   private long shuffleFinishTime; 
   private long sortFinishTime;