Browse Source

MAPREDUCE-6587. Remove unused params in connection-related methods of Fetcher. Contributed by Yiqun Lin.

Akira Ajisaka 8 years ago
parent
commit
8cc4a67059

+ 4 - 6
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/Fetcher.java

@@ -263,7 +263,7 @@ class Fetcher<K,V> extends Thread {
     DataInputStream input = null;
     DataInputStream input = null;
 
 
     try {
     try {
-      setupConnectionsWithRetry(host, remaining, url);
+      setupConnectionsWithRetry(url);
       if (stopped) {
       if (stopped) {
         abortConnect(host, remaining);
         abortConnect(host, remaining);
       } else {
       } else {
@@ -374,9 +374,8 @@ class Fetcher<K,V> extends Thread {
     }
     }
   }
   }
 
 
-  private void setupConnectionsWithRetry(MapHost host,
-      Set<TaskAttemptID> remaining, URL url) throws IOException {
-    openConnectionWithRetry(host, remaining, url);
+  private void setupConnectionsWithRetry(URL url) throws IOException {
+    openConnectionWithRetry(url);
     if (stopped) {
     if (stopped) {
       return;
       return;
     }
     }
@@ -396,8 +395,7 @@ class Fetcher<K,V> extends Thread {
     verifyConnection(url, msgToEncode, encHash);
     verifyConnection(url, msgToEncode, encHash);
   }
   }
 
 
-  private void openConnectionWithRetry(MapHost host,
-      Set<TaskAttemptID> remaining, URL url) throws IOException {
+  private void openConnectionWithRetry(URL url) throws IOException {
     long startTime = Time.monotonicNow();
     long startTime = Time.monotonicNow();
     boolean shouldWait = true;
     boolean shouldWait = true;
     while (shouldWait) {
     while (shouldWait) {