Sfoglia il codice sorgente

HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon.

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1296019 13f79535-47bb-0310-9956-ffa450edef68
Aaron Myers 13 anni fa
parent
commit
8a99218853

+ 2 - 0
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

@@ -261,6 +261,8 @@ Release 0.23.3 - UNRELEASED
 
     HDFS-3020. Fix editlog to automatically sync when buffer is full. (todd)
 
+    HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. (todd via atm)
+
 Release 0.23.2 - UNRELEASED 
 
   INCOMPATIBLE CHANGES

+ 9 - 0
hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml

@@ -247,4 +247,13 @@
        <Method name="save" />
        <Bug pattern="OS_OPEN_STREAM" />
      </Match>
+     <!--
+      the 'metrics' member is sometimes used from synchronized blocks, sometimes not,
+      but it's only reset by test cases, so should be fine
+     -->
+     <Match>
+       <Class name="org.apache.hadoop.hdfs.server.namenode.FSEditLog" />
+       <Field name="metrics" />
+       <Bug pattern="IS2_INCONSISTENT_SYNC" />
+     </Match>
  </FindBugsFilter>