浏览代码

HDFS-16893. Standardize the usage of DFSClient debug log (#5303)

Co-authored-by: Zhtttylz <hualong.z@hotmail.com>
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
zhtttylz 2 年之前
父节点
当前提交
72b760130a

+ 1 - 3
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java

@@ -293,9 +293,7 @@ public class DFSStripedOutputStream extends DFSOutputStream
                          DataChecksum checksum, String[] favoredNodes)
                          throws IOException {
     super(dfsClient, src, stat, flag, progress, checksum, favoredNodes, false);
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("Creating DFSStripedOutputStream for " + src);
-    }
+    LOG.debug("Creating DFSStripedOutputStream for {}", src);
 
     ecPolicy = stat.getErasureCodingPolicy();
     final int numParityBlocks = ecPolicy.getNumParityUnits();

+ 4 - 8
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/HAUtilClient.java

@@ -135,16 +135,12 @@ public class HAUtilClient {
                 HdfsConstants.HDFS_URI_SCHEME)
                 + "//" + specificToken.getService());
         ugi.addToken(alias, specificToken);
-        if (LOG.isDebugEnabled()) {
-          LOG.debug("Mapped HA service delegation token for logical URI " +
-              haUri + " to namenode " + singleNNAddr);
-        }
+        LOG.debug("Mapped HA service delegation token for logical URI {}" +
+            " to namenode {}", haUri, singleNNAddr);
       }
     } else {
-      if (LOG.isDebugEnabled()) {
-        LOG.debug("No HA service delegation token found for logical URI " +
-            haUri);
-      }
+      LOG.debug("No HA service delegation token found for logical URI {}",
+          haUri);
     }
   }
 }

+ 1 - 1
hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/util/TestByteArrayManager.java

@@ -342,7 +342,7 @@ public class TestByteArrayManager {
           }
 
           if ((i & 0xFF) == 0) {
-            LOG.info("randomRecycler sleep, i=" + i);
+            LOG.info("randomRecycler sleep, i={}", i);
             sleepMs(100);
           }
         }