Bladeren bron

HADOOP-10706. Fix initialization of hrpc_sync_ctx (decstery via cmccabe)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/HADOOP-10388@1603055 13f79535-47bb-0310-9956-ffa450edef68
Colin McCabe 11 jaren geleden
bovenliggende
commit
610ecfd3d7

+ 2 - 2
hadoop-native-core/src/main/native/rpc/protoc-gen-hrpc.cc

@@ -381,12 +381,12 @@ private:
 "    uv_sem_wait(&ctx->sem);\n"
 "    if (ctx->err) {\n"
 "        err = ctx->err;\n"
-"        hrpc_release_sync_ctx(ctx);\n"
+"        hrpc_proxy_release_sync_ctx(ctx);\n"
 "        return err;\n"
 "    }\n"
 "    resp = $resp_ty_uscore$__unpack(NULL, ctx->resp.pb_len,\n"
 "                                                  ctx->resp.pb_base);\n"
-"    hrpc_release_sync_ctx(ctx);\n"
+"    hrpc_proxy_release_sync_ctx(ctx);\n"
 "    if (!resp) {\n"
 "        return hadoop_lerr_alloc(EINVAL,\n"
 "           \"$sync_call$: failed to parse response from server\");\n"

+ 2 - 2
hadoop-native-core/src/main/native/rpc/proxy.c

@@ -96,14 +96,14 @@ struct hrpc_sync_ctx *hrpc_proxy_alloc_sync_ctx(struct hrpc_proxy *proxy)
     if (!ctx) {
         return NULL;
     }
+    memset(ctx, 0, sizeof(*ctx));
     if (uv_sem_init(&ctx->sem, 0)) {
         return NULL;
     }
-    memset(&ctx, 0, sizeof(ctx));
     return ctx;
 }
 
-void hrpc_release_sync_ctx(struct hrpc_sync_ctx *ctx)
+void hrpc_proxy_release_sync_ctx(struct hrpc_sync_ctx *ctx)
 {
     free(ctx->resp.base);
     uv_sem_destroy(&ctx->sem);

+ 1 - 1
hadoop-native-core/src/main/native/rpc/proxy.h

@@ -141,7 +141,7 @@ struct hrpc_sync_ctx *hrpc_proxy_alloc_sync_ctx(struct hrpc_proxy *proxy);
  *
  * @param proxy                 The sync context.
  */
-void hrpc_release_sync_ctx(struct hrpc_sync_ctx *ctx);
+void hrpc_proxy_release_sync_ctx(struct hrpc_sync_ctx *ctx);
 
 /**
  * A callback which synchronous RPCs can use.