Browse Source

HDDS-1476. Fix logIfNeeded logic in EndPointStateMachine. (#779)

Siddharth 6 years ago
parent
commit
5bca062d0e

+ 3 - 4
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/EndpointStateMachine.java

@@ -200,16 +200,15 @@ public class EndpointStateMachine
    *  @param ex         - Exception
    */
   public void logIfNeeded(Exception ex) {
-    LOG.trace("Incrementing the Missed count. Ex : {}", ex);
-    this.incMissed();
-    if (this.getMissedCount() % getLogWarnInterval(conf) ==
-        0) {
+    if (this.getMissedCount() % getLogWarnInterval(conf) == 0) {
       LOG.error(
           "Unable to communicate to SCM server at {} for past {} seconds.",
           this.getAddress().getHostString() + ":" + this.getAddress().getPort(),
           TimeUnit.MILLISECONDS.toSeconds(
               this.getMissedCount() * getScmHeartbeatInterval(this.conf)), ex);
     }
+    LOG.trace("Incrementing the Missed count. Ex : {}", ex);
+    this.incMissed();
   }