Browse Source

Revert "MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha)"

This reverts commit 61bf9cae6f3882c6e9a9222f59457b9be91e3018.
Andrew Wang 9 years ago
parent
commit
50fa383704

+ 2 - 7
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java

@@ -988,13 +988,8 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
       } catch(SecurityException se) {
         LOG.warn("Unexpected SecurityException in Configuration", se);
       }
-      if (val == null || val.isEmpty()) {
-        String raw = getRaw(var);
-        if (raw != null) {
-          // if System.getProperty(var) returns an empty string, retain this
-          // value instead of return null
-          val = raw;
-        }
+      if (val == null) {
+        val = getRaw(var);
       }
       if (val == null) {
         return eval; // return literal ${var}: var is unbound

+ 0 - 2
hadoop-mapreduce-project/CHANGES.txt

@@ -275,8 +275,6 @@ Trunk (Unreleased)
     MAPREDUCE-5801. Uber mode's log message is missing a vcore reason
     (Steven Wong via aw)
 
-    MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha)
-
 Release 2.8.0 - UNRELEASED
 
   INCOMPATIBLE CHANGES

+ 1 - 3
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java

@@ -181,9 +181,7 @@ public class TaskLog {
   }
 
   static String getBaseLogDir() {
-    String logDir = System.getProperty("hadoop.log.dir");
-    // file is treating "" different from null {@see File#File(String, String)}
-    return logDir == null || logDir.isEmpty() ? null : logDir;
+    return System.getProperty("hadoop.log.dir");
   }
 
   static File getAttemptDir(TaskAttemptID taskid, boolean isCleanup) {