HDFS-7583. Fix findbug in TransferFsImage.java (Contributed by Vinayakumar B)

hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

@@ -642,6 +642,8 @@ Release 2.7.0 - UNRELEASED
     HDFS-7572. TestLazyPersistFiles#testDnRestartWithSavedReplicas is flaky on
     Windows. (Arpit Agarwal via cnauroth)
 
+    HDFS-7583. Fix findbug in TransferFsImage.java (vinayakumarb)
+
 Release 2.6.1 - UNRELEASED
 
   INCOMPATIBLE CHANGES

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java

@@ -574,11 +574,12 @@ public class TransferFsImage {
 
     LOG.info("Deleting temporary files: " + files);
     for (File file : files) {
-      file.delete(); // ignore the return value
+      if (!file.delete()) {
+        LOG.warn("Deleting " + file + " has failed");
+      }
     }
   }
 
-
   private static MD5Hash parseMD5Header(HttpURLConnection connection) {
     String header = connection.getHeaderField(MD5_HEADER);
     return (header != null) ? new MD5Hash(header) : null;