Browse Source

HDFS-13551. TestMiniDFSCluster#testClusterSetStorageCapacity does not shut down cluster. Contributed by Anbang Hu.

(cherry picked from commit 92ebd466c75275118107e6ec665cf50e337a29e7)
Inigo Goiri 7 years ago
parent
commit
4ae1ed5b17

+ 25 - 19
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java

@@ -108,29 +108,35 @@ public class TestMiniDFSCluster {
             capacities,
             defaultBlockSize,
             fileLen);
-    verifyStorageCapacity(cluster, capacities);
+    try {
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all data nodes */
-    cluster.restartDataNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all data nodes */
+      cluster.restartDataNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all name nodes */
-    cluster.restartNameNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all name nodes */
+      cluster.restartNameNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all name nodes firstly and data nodes then */
-    cluster.restartNameNodes();
-    cluster.restartDataNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all name nodes firstly and data nodes then */
+      cluster.restartNameNodes();
+      cluster.restartDataNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all data nodes firstly and name nodes then */
-    cluster.restartDataNodes();
-    cluster.restartNameNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all data nodes firstly and name nodes then */
+      cluster.restartDataNodes();
+      cluster.restartNameNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
+    } finally {
+      if (cluster != null) {
+        cluster.shutdown();
+      }
+    }
   }
 
   private void verifyStorageCapacity(