HADOOP-4542. TestDistributedUpgrade used succeed for wrong reasons. (Raghu Angadi)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/branches/branch-0.18@720958 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -46,6 +46,9 @@ Release 0.18.3 - Unreleased
     HADOOP-4614. Lazily open segments when merging map spills to avoid using
     too many file descriptors. (Yuri Pradkin via cdouglas)
 
+    HADOOP-4542. TestDistributedUpgrade used succeed for wrong reasons.
+    (Raghu Angadi)
+
 Release 0.18.2 - 2008-11-03
 
   BUG FIXES

src/test/org/apache/hadoop/dfs/TestDistributedUpgrade.java

@@ -51,7 +51,11 @@ public class TestDistributedUpgrade extends TestCase {
    */
   void startNameNodeShouldFail(StartupOption operation) {
     try {
-      cluster = new MiniDFSCluster(conf, 0, operation); // should fail
+      //cluster = new MiniDFSCluster(conf, 0, operation); // should fail
+      // we set manage dirs to true as NN has to start from untar'ed image with 
+      // nn dirs set to name1 and name2
+      cluster = new MiniDFSCluster(0, conf, 0, false, true,
+          operation, null); // Should fail
       throw new AssertionError("NameNode should have failed to start");
     } catch (Exception expected) {
       expected = null;