Browse Source

HADOOP-15989. Synchronized at CompositeService#removeService is not required. Contributed by Prabhu Joseph.

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
Prabhu Joseph 6 years ago
parent
commit
371452e260

+ 2 - 1
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java

@@ -93,7 +93,8 @@ public class CompositeService extends AbstractService {
     }
     }
   }
   }
 
 
-  protected synchronized boolean removeService(Service service) {
+  protected boolean removeService(Service service) {
+    LOG.debug("Removing service {}", service.getName());
     synchronized (serviceList) {
     synchronized (serviceList) {
       return serviceList.remove(service);
       return serviceList.remove(service);
     }
     }