Browse Source

HDFS-2117. DiskChecker#mkdirsWithExistsAndPermissionCheck may return true even when the dir is not created. Contributed by Eli Collins

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20-security@1153317 13f79535-47bb-0310-9956-ffa450edef68
Eli Collins 14 years ago
parent
commit
3377c961ed
2 changed files with 5 additions and 0 deletions
  1. 3 0
      CHANGES.txt
  2. 2 0
      src/core/org/apache/hadoop/util/DiskChecker.java

+ 3 - 0
CHANGES.txt

@@ -24,6 +24,9 @@ Release 0.20.205.0 - unreleased
     HDFS-2053. Bug in INodeDirectory#computeContentSummary warning
     HDFS-2053. Bug in INodeDirectory#computeContentSummary warning
     (Michael Noll via eli)
     (Michael Noll via eli)
 
 
+    HDFS-2117. DiskChecker#mkdirsWithExistsAndPermissionCheck may
+    return true even when the dir is not created. (eli)
+
   IMPROVEMENTS
   IMPROVEMENTS
 
 
     MAPREDUCE-7343. Make the number of warnings accepted by test-patch
     MAPREDUCE-7343. Make the number of warnings accepted by test-patch

+ 2 - 0
src/core/org/apache/hadoop/util/DiskChecker.java

@@ -138,6 +138,8 @@ public class DiskChecker {
       if (created) {
       if (created) {
         localFS.setPermission(dir, expected);
         localFS.setPermission(dir, expected);
         return true;
         return true;
+      } else {
+        return false;
       }
       }
     }
     }