HDFS-9401. Fix findbugs warnings in BlockRecoveryWorker. Contributed by Brahma Reddy Battula.

hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

@@ -2282,6 +2282,9 @@ Release 2.8.0 - UNRELEASED
     HDFS-9249. NPE is thrown if an IOException is thrown in NameNode constructor.
     (Wei-Chiu Chuang via Yongjun Zhang)
 
+    HDFS-9401. Fix findbugs warnings in BlockRecoveryWorker.
+    (Brahma Reddy Battula via waltersu4549)
+
 Release 2.7.3 - UNRELEASED
 
   INCOMPATIBLE CHANGES

hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml

@@ -124,13 +124,6 @@
        <Bug pattern="DM_EXIT" />
      </Match>
 
-     <!-- Don't complain about recoverBlock equality check -->
-     <Match>
-       <Class name="org.apache.hadoop.hdfs.server.datanode.DataNode" />
-       <Method name="recoverBlock" />
-       <Bug pattern="EC_UNRELATED_TYPES" />
-     </Match>
-
      <!-- More complex cleanup logic confuses findbugs -->
      <Match>
        <Class name="org.apache.hadoop.hdfs.qjournal.server.Journal" />

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java

@@ -112,7 +112,8 @@ public class BlockRecoveryWorker {
       // - Original state is RWR or better
       for(DatanodeID id : locs) {
         try {
-          DatanodeID bpReg =datanode.getBPOfferService(bpid).bpRegistration;
+          DatanodeID bpReg = new DatanodeID(
+              datanode.getBPOfferService(bpid).bpRegistration);
           InterDatanodeProtocol proxyDN = bpReg.equals(id)?
               datanode: DataNode.createInterDataNodeProtocolProxy(id, conf,
               dnConf.socketTimeout, dnConf.connectToDnViaHostname);