Browse Source

YARN-11334. Improve SubClusterState#fromString parameter and LogMessage. (#4988). Contributed by fanshilun.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
slfan1989 2 years ago
parent
commit
1ff7e84caf

+ 5 - 5
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/SubClusterState.java

@@ -70,15 +70,15 @@ public enum SubClusterState {
   /**
    * Convert a string into {@code SubClusterState}.
    *
-   * @param x the string to convert in SubClusterState
+   * @param state the string to convert in SubClusterState
    * @return the respective {@code SubClusterState}
    */
-  public static SubClusterState fromString(String x) {
+  public static SubClusterState fromString(String state) {
     try {
-      return SubClusterState.valueOf(x);
+      return SubClusterState.valueOf(state);
     } catch (Exception e) {
-      LOG.error("Invalid SubCluster State value in the StateStore does not"
-          + " match with the YARN Federation standard.");
+      LOG.error("Invalid SubCluster State value({}) in the StateStore does not"
+          + " match with the YARN Federation standard.", state);
       return null;
     }
   }