瀏覽代碼

HADOOP-11619. FTPFileSystem should override getDefaultPort. (Brahma Reddy Battula via gera)

Gera Shegalov 10 年之前
父節點
當前提交
1dba57271f

+ 3 - 0
hadoop-common-project/hadoop-common/CHANGES.txt

@@ -995,6 +995,9 @@ Release 2.7.0 - UNRELEASED
     HADOOP-8642. Document that io.native.lib.available only controls native bz2
     and zlib compression codecs. (aajisaka)
 
+    HADOOP-11619. FTPFileSystem should override getDefaultPort.
+    (Brahma Reddy Battula via gera)
+
 Release 2.6.1 - UNRELEASED
 
   INCOMPATIBLE CHANGES

+ 10 - 0
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ftp/FTPFileSystem.java

@@ -81,6 +81,16 @@ public class FTPFileSystem extends FileSystem {
     return "ftp";
   }
 
+  /**
+   * Get the default port for this FTPFileSystem.
+   *
+   * @return the default port
+   */
+  @Override
+  protected int getDefaultPort() {
+    return FTP.DEFAULT_PORT;
+  }
+
   @Override
   public void initialize(URI uri, Configuration conf) throws IOException { // get
     super.initialize(uri, conf);

+ 33 - 0
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/ftp/TestFTPFileSystem.java

@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.hadoop.fs.ftp;
+
+import org.apache.commons.net.ftp.FTP;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestFTPFileSystem {
+
+  @Test
+  public void testFTPDefaultPort() throws Exception {
+    FTPFileSystem ftp = new FTPFileSystem();
+    Assert.assertEquals(FTP.DEFAULT_PORT, ftp.getDefaultPort());
+  }
+
+}