瀏覽代碼

HDFS-8111. NPE thrown when invalid FSImage filename given for 'hdfs oiv_legacy' cmd ( Contributed by surendra singh lilhore )

Vinayakumar B 10 年之前
父節點
當前提交
14384f5b51

+ 3 - 0
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

@@ -482,6 +482,9 @@ Release 2.8.0 - UNRELEASED
     HDFS-7939. Two fsimage_rollback_* files are created which are not deleted
     after rollback. (J.Andreina via vinayakumarb)
 
+    HDFS-8111. NPE thrown when invalid FSImage filename given for
+    'hdfs oiv_legacy' cmd ( surendra singh lilhore via vinayakumarb )
+
 Release 2.7.1 - UNRELEASED
 
   INCOMPATIBLE CHANGES

+ 5 - 1
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java

@@ -137,7 +137,11 @@ public class OfflineImageViewer {
       done = true;
     } finally {
       if (!done) {
-        LOG.error("image loading failed at offset " + tracker.getPos());
+        if (tracker != null) {
+          LOG.error("image loading failed at offset " + tracker.getPos());
+        } else {
+          LOG.error("Failed to load image file.");
+        }
       }
       IOUtils.cleanup(LOG, in, tracker);
     }