HADOOP-2904. Fix to RPC metrics to log the correct host name.

(girish vaitheeswaran via dhruba)



git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@632184 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -91,6 +91,9 @@ Trunk (unreleased changes)
 
     HADOOP-2891.  DFSClient.close() closes all open files. (dhruba)
 
+    HADOOP-2904.  Fix to RPC metrics to log the correct host name. 
+    (girish vaitheeswaran via dhruba)
+
 Release 0.16.1 - Unreleased
 
   IMPROVEMENTS

src/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java

@@ -41,24 +41,22 @@ import org.apache.hadoop.metrics.util.MetricsTimeVaryingRate;
  */
 public class RpcMetrics implements Updater {
   private MetricsRecord metricsRecord;
-  private static Log LOG = LogFactory.getLog(JvmMetrics.class);
+  private static Log LOG = LogFactory.getLog(RpcMetrics.class);
   RpcMgt rpcMgt;
   
-  private void setTags(String serverName, String port) {
-    metricsRecord.setTag("serverName", serverName);
-    metricsRecord.setTag("port", port);
-    LOG.info("Initializing RPC Metrics with serverName=" 
-        + serverName + ", port=" + port);
-  }
-
-  public RpcMetrics(String serverName, String port, Server server) {
+  public RpcMetrics(String hostName, String port, Server server) {
     MetricsContext context = MetricsUtil.getContext("rpc");
     metricsRecord = MetricsUtil.createRecord(context, "metrics");
-    setTags(serverName, port);
+
+    metricsRecord.setTag("port", port);
+
+    LOG.info("Initializing RPC Metrics with hostName=" 
+        + hostName + ", port=" + port);
+
     context.registerUpdater(this);
     
     // Need to clean up the interface to RpcMgt - don't need both metrics and server params
-    rpcMgt = new RpcMgt(serverName, port, this, server);
+    rpcMgt = new RpcMgt(hostName, port, this, server);
   }