Bladeren bron

commit cfa25eafadb089a7a9de44a5b0837ede9286c0e2
Author: Luke Lu <llu@yahoo-inc.com>
Date: Fri Sep 3 14:32:43 2010 -0700

MAPREDUCE:1233 Fix waiting map/reduces metrics

when jobs are killed.


git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20-security-patches@1077665 13f79535-47bb-0310-9956-ffa450edef68

Owen O'Malley 14 jaren geleden
bovenliggende
commit
08b9c9743b
1 gewijzigde bestanden met toevoegingen van 4 en 2 verwijderingen
  1. 4 2
      src/mapred/org/apache/hadoop/mapred/JobInProgress.java

+ 4 - 2
src/mapred/org/apache/hadoop/mapred/JobInProgress.java

@@ -2829,6 +2829,7 @@ public class JobInProgress {
    
     boolean isRunning = tip.isRunning();
     boolean isComplete = tip.isComplete();
+    boolean metricsDone = isComplete(); // job metrics garbage collected
     
     if (wasAttemptRunning) {
       // We are decrementing counters without looking for isRunning ,
@@ -2840,11 +2841,12 @@ public class JobInProgress {
       //.........
       //      metrics.launchMap(id);
       // hence we are decrementing the same set.
+      // Except after garbageCollect in a different thread.
       if (!tip.isJobCleanupTask() && !tip.isJobSetupTask()) {
-        if (tip.isMapTask()) {
+        if (tip.isMapTask() && !metricsDone) {
           runningMapTasks -= 1;
           metrics.failedMap(taskid);
-        } else {
+        } else if (!metricsDone) {
           runningReduceTasks -= 1;
           metrics.failedReduce(taskid);
         }