Browse Source

HDFS-9855. Modify TestAuditLoggerWithCommands to workaround the absence of HDFS-8332. Contributed by Kuhu Shukla.

Kihwal Lee 9 years ago
parent
commit
03afcdd39d

+ 3 - 0
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

@@ -1900,6 +1900,9 @@ Release 2.8.0 - UNRELEASED
     HDFS-9549. TestCacheDirectives#testExceedsCapacity is flaky (Xiao Chen via
     cmccabe)
 
+    HDFS-9855. Modify TestAuditLoggerWithCommands to workaround the absence
+    of HDFS-8332 (Kuhu Shukla via kihwal)
+
 Release 2.7.3 - UNRELEASED
 
   INCOMPATIBLE CHANGES

+ 7 - 6
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAuditLoggerWithCommands.java

@@ -121,7 +121,6 @@ public class TestAuditLoggerWithCommands {
   public void testSetQuota() throws Exception {
     Path path = new Path("/testdir/testdir1");
     fs.mkdirs(path);
-    fileSys = DFSTestUtil.getFileSystemAs(user1, conf);
     try {
       ((DistributedFileSystem)fileSys).setQuota(path, 10l, 10l);
       fail("The operation should have failed with AccessControlException");
@@ -129,15 +128,17 @@ public class TestAuditLoggerWithCommands {
     }
     String acePattern =
         ".*allowed=false.*ugi=theDoctor.*cmd=setQuota.*";
-    int length = verifyAuditLogs(acePattern);
-    fileSys.close();
+    verifyAuditLogs(acePattern);
+    String ioePattern =
+        ".*allowed=true.*ugi=" + fs.getFileStatus(path).getOwner().toString() +
+            ".*cmd=delete.*";
+    fs.delete(path, true);
     try {
-      ((DistributedFileSystem)fileSys).setQuota(path, 10l, 10l);
+      ((DistributedFileSystem)fs).setQuota(path, 10l, 10l);
       fail("The operation should have failed with IOException");
     } catch (IOException ace) {
     }
-    assertTrue("Unexpected log from getContentSummary",
-        length == auditlog.getOutput().split("\n").length);
+    verifyAuditLogs(ioePattern);
   }
 
   @Test