YARN-5073. Refactor startContainerInternal() in ContainerManager to remove unused parameter. (Konstantinos Karanasos via asuresh)

(cherry picked from commit d971bf252f36e902a0fe446cb11201835ad16bcb)

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java

@@ -819,8 +819,7 @@ public class ContainerManagerImpl extends CompositeService implements
           }
           performContainerPreStartChecks(nmTokenIdentifier, request,
               containerTokenIdentifier);
-          startContainerInternal(nmTokenIdentifier, containerTokenIdentifier,
-              request);
+          startContainerInternal(containerTokenIdentifier, request);
           succeededContainers.add(containerId);
         } catch (YarnException e) {
           failedContainers.put(containerId, SerializedException.newInstance(e));
@@ -916,7 +915,7 @@ public class ContainerManagerImpl extends CompositeService implements
   }
 
   @SuppressWarnings("unchecked")
-  protected void startContainerInternal(NMTokenIdentifier nmTokenIdentifier,
+  protected void startContainerInternal(
       ContainerTokenIdentifier containerTokenIdentifier,
       StartContainerRequest request) throws YarnException, IOException {
 

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/queuing/QueuingContainerManagerImpl.java

@@ -104,14 +104,14 @@ public class QueuingContainerManagerImpl extends ContainerManagerImpl {
   }
 
   @Override
-  protected void startContainerInternal(NMTokenIdentifier nmTokenIdentifier,
+  protected void startContainerInternal(
       ContainerTokenIdentifier containerTokenIdentifier,
       StartContainerRequest request) throws YarnException, IOException {
     this.context.getQueuingContext().getQueuedContainers().put(
         containerTokenIdentifier.getContainerID(), containerTokenIdentifier);
 
     AllocatedContainerInfo allocatedContInfo = new AllocatedContainerInfo(
-        containerTokenIdentifier, nmTokenIdentifier, request,
+        containerTokenIdentifier, request,
         containerTokenIdentifier.getExecutionType(), containerTokenIdentifier
             .getResource(), getConfig());
 
@@ -198,7 +198,6 @@ public class QueuingContainerManagerImpl extends ContainerManagerImpl {
     this.context.getQueuingContext().getQueuedContainers().remove(containerId);
     try {
       super.startContainerInternal(
-          allocatedContainerInfo.getNMTokenIdentifier(),
           allocatedContainerInfo.getContainerTokenIdentifier(),
           allocatedContainerInfo.getStartRequest());
     } catch (YarnException | IOException e) {
@@ -508,7 +507,6 @@ public class QueuingContainerManagerImpl extends ContainerManagerImpl {
     }
 
     @Override
-    @SuppressWarnings("unchecked")
     public void handle(ApplicationEvent event) {
       if (event.getType() ==
           ApplicationEventType.APPLICATION_CONTAINER_FINISHED) {
@@ -530,16 +528,14 @@ public class QueuingContainerManagerImpl extends ContainerManagerImpl {
 
   static class AllocatedContainerInfo {
     private final ContainerTokenIdentifier containerTokenIdentifier;
-    private final NMTokenIdentifier nmTokenIdentifier;
     private final StartContainerRequest startRequest;
     private final ExecutionType executionType;
     private final ProcessTreeInfo pti;
 
     AllocatedContainerInfo(ContainerTokenIdentifier containerTokenIdentifier,
-        NMTokenIdentifier nmTokenIdentifier, StartContainerRequest startRequest,
-        ExecutionType executionType, Resource resource, Configuration conf) {
+        StartContainerRequest startRequest, ExecutionType executionType,
+        Resource resource, Configuration conf) {
       this.containerTokenIdentifier = containerTokenIdentifier;
-      this.nmTokenIdentifier = nmTokenIdentifier;
       this.startRequest = startRequest;
       this.executionType = executionType;
       this.pti = createProcessTreeInfo(containerTokenIdentifier
@@ -550,10 +546,6 @@ public class QueuingContainerManagerImpl extends ContainerManagerImpl {
       return this.containerTokenIdentifier;
     }
 
-    private NMTokenIdentifier getNMTokenIdentifier() {
-      return this.nmTokenIdentifier;
-    }
-
     private StartContainerRequest getStartRequest() {
       return this.startRequest;
     }