Browse Source

AMBARI-15038 Alert definitions: Percentage params get validation errors when they shouldn't (Joe Wang via rzang)

Richard Zang 9 năm trước cách đây
mục cha
commit
f18601c7c7

+ 2 - 2
ambari-web/app/models/alerts/alert_config.js

@@ -532,7 +532,7 @@ App.AlertConfigProperties.Parameters = {
       value = String(value).trim();
       value = parseFloat(value);
 
-      return !isNaN(value) && value > 0 && value <= 100;
+      return !isNaN(value) && value > 0;
     }.property('value')
   })
 
@@ -622,7 +622,7 @@ App.AlertConfigProperties.Thresholds = {
         return false;
       }
 
-      return this.get('showInputForValue') ? !isNaN(value) && value > 0 && value <= 100 : true;
+      return this.get('showInputForValue') ? !isNaN(value) && value > 0 : true;
     }.property('displayValue', 'showInputForValue'),
 
     /**

+ 4 - 4
ambari-web/test/models/alerts/alert_config_test.js

@@ -104,13 +104,13 @@ describe('App.AlertConfigProperties', function () {
           {value: 'abc', expected: false},
           {value: 'g1', expected: false},
           {value: '1g', expected: false},
-          {value: '123', expected: false},
+          {value: '123', expected: true},
           {value: '23', expected: true},
-          {value: '123.8', expected: false},
+          {value: '123.8', expected: true},
           {value: '5.8', expected: true},
-          {value: 123, expected: false},
+          {value: 123, expected: true},
           {value: 23, expected: true},
-          {value: 123.8, expected: false},
+          {value: 123.8, expected: true},
           {value: 5.8, expected: true}
         ]).forEach(function (test) {
           it('value: ' + JSON.stringify(test.value) + ' ;result - ' + test.expected, function () {