AMBARI-15237. Create Grafana user through Ambari and add user to Grafana. (avijayan, swagle via swagle)

ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini

@@ -145,13 +145,13 @@ static_root_path = /usr/lib/ambari-metrics-grafana/public
 #################################### Anonymous Auth ##########################
 [auth.anonymous]
 # enable anonymous access
-enabled = true
+;enabled = true
 
 # specify organization name that should be used for unauthenticated users
-org_name = Main Org.
+;org_name = Main Org.
 
 # specify role for unauthenticated users
-org_role = Admin
+;org_role = Admin
 
 #################################### Github Auth ##########################
 [auth.github]

ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml

@@ -37,6 +37,34 @@
     <display-name>Metrics Grafana data dir</display-name>
     <description>Metrics Grafana data directory.</description>
   </property>
+  <property>
+    <name>metrics_grafana_username</name>
+    <value>admin</value>
+    <display-name>Metrics Grafana Admin Username</display-name>
+    <description>
+      Metrics Grafana Username. This value cannot be modified by Ambari
+      except on initial install. Please make sure the username change in
+      Grafana is reflected in Ambari.
+    </description>
+    <value-attributes>
+      <type>db_user</type>
+      <overridable>false</overridable>
+    </value-attributes>
+  </property>
+  <property require-input="true">
+    <name>metrics_grafana_password</name>
+    <value> </value>
+    <property-type>PASSWORD</property-type>
+    <display-name>Metrics Grafana Admin Password</display-name>
+    <description>
+      Metrics Grafana password. This value cannot be modified by Ambari
+      except on initial install. Please make sure the password change in
+      Grafana is reflected back in Ambari.
+    </description>
+    <value-attributes>
+      <overridable>false</overridable>
+    </value-attributes>
+  </property>
   <property>
     <name>content</name>
     <value>

ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml

@@ -153,10 +153,10 @@ cert_key = {{ams_grafana_cert_key}}
 #################################### Security ####################################
 [security]
 # default admin user, created on startup
-;admin_user = admin
+admin_user = {{ams_grafana_admin_user}}
 
 # default admin password, can be changed before first start of grafana,  or in profile settings
-;admin_password = admin
+admin_password = {{ams_grafana_admin_pwd}}
 
 # used for signing
 ;secret_key = SW2YcwTIb9zpOOhoPsMm

ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py

@@ -23,6 +23,7 @@ from resource_management.core.base import Fail
 from resource_management import Template
 from collections import namedtuple
 from urlparse import urlparse
+from base64 import b64encode
 import time
 import socket
 import ambari_simplejson as json
@@ -35,7 +36,7 @@ GRAFANA_DATASOURCE_URL = "/api/datasources"
 GRAFANA_DASHBOARDS_URL = "/api/dashboards/db"
 METRICS_GRAFANA_DATASOURCE_NAME = "AMBARI_METRICS"
 
-Server = namedtuple('Server', [ 'protocol', 'host', 'port' ])
+Server = namedtuple('Server', [ 'protocol', 'host', 'port', 'user', 'password' ])
 
 def perform_grafana_get_call(url, server):
   grafana_https_enabled = server.protocol.lower() == 'https'
@@ -44,10 +45,12 @@ def perform_grafana_get_call(url, server):
                                      int(server.port),
                                      grafana_https_enabled)
 
-  Logger.info("Connecting (GET) to %s:%s%s" % (server.host,
-                                               server.port,
-                                               url))
-  conn.request("GET", url)
+  userAndPass = b64encode('{0}:{1}'.format(server.user, server.password))
+  headers = { 'Authorization' : 'Basic %s' %  userAndPass }
+
+  Logger.info("Connecting (GET) to %s:%s%s" % (server.host, server.port, url))
+
+  conn.request("GET", url, headers = headers)
   response = conn.getresponse()
   Logger.info("Http response: %s %s" % (response.status, response.reason))
 
@@ -56,7 +59,9 @@ def perform_grafana_get_call(url, server):
 def perform_grafana_put_call(url, id, payload, server):
   response = None
   data = None
-  headers = {"Content-Type": "application/json"}
+  userAndPass = b64encode('{0}:{1}'.format(server.user, server.password))
+  headers = {"Content-Type": "application/json",
+             'Authorization' : 'Basic %s' %  userAndPass }
   grafana_https_enabled = server.protocol.lower() == 'https'
 
   for i in xrange(0, GRAFANA_CONNECT_TRIES):
@@ -82,8 +87,10 @@ def perform_grafana_put_call(url, id, payload, server):
 def perform_grafana_post_call(url, payload, server):
   response = None
   data = None
+  userAndPass = b64encode('{0}:{1}'.format(server.user, server.password))
   Logger.debug('POST payload: %s' % payload)
-  headers = {"Content-Type": "application/json", "Content-Length" : len(payload)}
+  headers = {"Content-Type": "application/json", "Content-Length" : len(payload),
+             'Authorization' : 'Basic %s' %  userAndPass}
   grafana_https_enabled = server.protocol.lower() == 'https'
 
   for i in xrange(0, GRAFANA_CONNECT_TRIES):
@@ -115,21 +122,24 @@ def perform_grafana_post_call(url, payload, server):
 def is_unchanged_datasource_url(datasource_url):
   import params
   parsed_url = urlparse(datasource_url)
-  Logger.debug("parsed url, scheme = %s, host = %s, port = %s" % (
+  Logger.debug("parsed url: scheme = %s, host = %s, port = %s" % (
     parsed_url.scheme, parsed_url.hostname, parsed_url.port))
-  Logger.debug("collector, scheme = %s, host = %s, port = %s" %
+  Logger.debug("collector: scheme = %s, host = %s, port = %s" %
               (params.metric_collector_protocol, params.metric_collector_host,
                params.metric_collector_port))
 
-  return (parsed_url.scheme == params.metric_collector_protocol.strip()) and \
-         (parsed_url.hostname == params.metric_collector_host.strip()) and \
-         (parsed_url.port == params.metric_collector_port)
+  return parsed_url.scheme.strip() == params.metric_collector_protocol.strip() and \
+         parsed_url.hostname.strip() == params.metric_collector_host.strip() and \
+         str(parsed_url.port) == params.metric_collector_port
+
 
 def create_ams_datasource():
   import params
   server = Server(protocol = params.ams_grafana_protocol.strip(),
                   host = params.ams_grafana_host.strip(),
-                  port = params.ams_grafana_port)
+                  port = params.ams_grafana_port,
+                  user = params.ams_grafana_admin_user,
+                  password = params.ams_grafana_admin_pwd)
 
   """
   Create AMS datasource in Grafana, if exsists make sure the collector url is accurate
@@ -206,7 +216,9 @@ def create_ams_dashboards():
   import params
   server = Server(protocol = params.ams_grafana_protocol.strip(),
                   host = params.ams_grafana_host.strip(),
-                  port = params.ams_grafana_port)
+                  port = params.ams_grafana_port,
+                  user = params.ams_grafana_admin_user,
+                  password = params.ams_grafana_admin_pwd)
 
   dashboard_files = params.get_grafana_dashboard_defs()
   version = params.get_ambari_version()
@@ -283,7 +295,8 @@ def create_ams_dashboards():
           else:
             Logger.error("Failed creating dashboard: %s" % dashboard_def['title'])
           pass
-        pass
+        else:
+          Logger.info('No update needed for dashboard = %s' % dashboard_def['title'])
       pass
     pass
 

ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py

@@ -127,6 +127,8 @@ ams_grafana_log_dir = default("/configurations/ams-grafana-env/metrics_grafana_l
 ams_grafana_pid_dir = status_params.ams_grafana_pid_dir
 ams_grafana_conf_dir = '/etc/ambari-metrics-grafana/conf'
 ams_grafana_data_dir = default("/configurations/ams-grafana-env/metrics_grafana_data_dir", '/var/lib/ambari-metrics-grafana')
+ams_grafana_admin_user = config['configurations']['ams-grafana-env']['metrics_grafana_username']
+ams_grafana_admin_pwd = config['configurations']['ams-grafana-env']['metrics_grafana_password']
 
 metrics_grafana_hosts = default('/clusterHostInfo/metrics_grafana_hosts', None)
 ams_grafana_host = None

ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py

@@ -38,7 +38,8 @@ class TestMetricsGrafana(RMFTestCase):
   import  metrics_grafana_util
 
   @patch("metrics_grafana_util.create_ams_datasource")
-  def test_start(self, create_ams_datasource_mock):
+  @patch("metrics_grafana_util.create_ams_dashboards")
+  def test_start(self, create_ams_datasource_mock, create_ams_dashboards_mock):
     self.executeScript(self.COMMON_SERVICES_PACKAGE_DIR + "/metrics_grafana.py",
                        classname = "AmsGrafana",
                        command = "start",
@@ -64,6 +65,7 @@ class TestMetricsGrafana(RMFTestCase):
                               user = 'ams'
                               )
     create_ams_datasource_mock.assertCalled()
+    create_ams_dashboards_mock.assertCalled()
     self.assertNoMoreResources()
 
   def assert_configure(self):

ambari-server/src/test/python/stacks/2.0.6/configs/default.json

@@ -865,7 +865,9 @@
             "metrics_grafana_log_dir": "/var/log/ambari-metrics-grafana",
             "metrics_grafana_pid_dir": "/var/run/ambari-metrics-grafana",
             "metrics_grafana_data_dir": "/var/lib/ambari-metrics-grafana",
-            "content": "\n"
+            "content": "\n",
+            "metrics_grafana_username" : "admin",
+            "metrics_grafana_password" : "admin"
         },
         "ams-ssl-server": {
             "content": "\n"

ambari-web/app/data/HDP2/site_properties.js

@@ -1649,6 +1649,20 @@ var hdp2properties = [
     "category": "General",
     "index": 5
   },
+  {
+    "name": "metrics_grafana_username",
+    "serviceName": "AMBARI_METRICS",
+    "filename": "ams-grafana-env.xml",
+    "category": "General",
+    "index": 6
+  },
+  {
+    "name": "metrics_grafana_password",
+    "serviceName": "AMBARI_METRICS",
+    "filename": "ams-grafana-env.xml",
+    "category": "General",
+    "index": 7
+  },
   {
     "name": "timeline.metrics.aggregator.checkpoint.dir",
     "serviceName": "AMBARI_METRICS",