AMBARI-358. Make index.php always accessible, rather than automatically forwarding to the action, even if there's only one action that the user can take (Contributed by Yusaku)

git-svn-id: https://svn.apache.org/repos/asf/incubator/ambari/branches/ambari-186@1347165 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -6,6 +6,8 @@ characters wide.
 
 Release 0.1.x - unreleased
 
+  AMBARI-358. Make index.php always accessible, rather than automatically forwarding to the action, even if there's only one action that the user can take (Yusaku via Vikram)
+
   AMBARI-390. Handle multiple ZooKeeper service masters in Assign Masters page (Yusaku via Vikram)
 
   AMBARI-389. Do not allow invalid chars for database name and user name for hive (Hitesh via Vikram)

hmc/html/head.inc

@@ -6,21 +6,35 @@ require_once "../php/util/lock.php";
 require_once '../php/db/HMCDBAccessor.php';
 require_once "../php/util/clusterState.php";
 
+/* 
+ * due to the way include files are scoped,
+ * we return the string to be eval'd, rather than
+ * executing them.
+ */
+function redirectToPage($requestPage, $targetPage) {
+  // if the page is index.php or the root app directory, don't redirect... simply include
+  if ($requestPage != 'index.php' && $requestPage != 'html') {
+    return "header('Location: /hmc/html/$targetPage');";
+  } else {
+    return "require('$targetPage');";
+  }
+}
+
 $logger = new HMCLogger("Interceptor");
 $db = new HMCDBAccessor($GLOBALS["DB_PATH"]);
+$appDir = "/hmc/html";
 
 $res = $db->getAllClusters();
 $clusters = $res['clusters'];
-$baseUrl = basename(preg_replace('/\?.*/', '', $_SERVER['REQUEST_URI']));
-$logger->log_trace('basename='.$baseUrl);
-$appDir = "/hmc/html";
+$requestPage = basename(preg_replace('/\?.*/', '', $_SERVER['REQUEST_URI']));
+$logger->log_trace('requestPage='.$requestPage);
 
-$logger->log_trace('basename='.$baseUrl);
 if (sizeof($clusters) == 0) {
-  if ($baseUrl != 'welcome.php' && $baseUrl != 'initializeCluster.php') {
-    header("Location: $appDir/welcome.php");
-    return;
+  if ($requestPage != 'welcome.php' && $requestPage != 'initializeCluster.php') {
+    eval(redirectToPage($requestPage, 'welcome.php'));
+    exit;
   }
+  $clusterState = 'NOT_CONFIGURED';
 } else {
   foreach ($clusters as $cluster) {
     $state = json_decode($cluster['state'], true);    
@@ -28,23 +42,31 @@ if (sizeof($clusters) == 0) {
     switch ($state['state']) {
       case 'DEPLOYED':
         if ($state['context']['status']) {
-          return;
+          $clusterState = 'OPERATIONAL';
         } else {
-          if ($baseUrl != "reinstall.php" && $baseUrl != "uninstallWizard.php") {
-            header("Location: $appDir/reinstall.php");
-            return;
+          if ($requestPage != 'installFailed.php' && $requestPage != 'uninstallWizard.php') {
+            eval(redirectToPage($requestPage, 'installFailed.php'));
+            exit; 
           }
+          $clusterState = 'DEPLOY_FAILED';            
         }
         break;
       case 'CONFIGURATION_IN_PROGRESS':
-        if ($baseUrl != 'initializeCluster.php') {
-          header("Location: $appDir/initializeCluster.php");
+        if ($requestPage != 'reinstall.php' && $requestPage != 'initializeCluster.php') {
+          $targetPage = 'reinstall.php';
+          eval(redirectToPage($requestPage, 'reinstall.php'));
+          exit;
         }
+        $clusterState = 'CONFIGURATION_IN_PROGRESS';
         break;      
       case 'DEPLOYMENT_IN_PROGRESS':
-        if ($baseUrl != 'showDeployProgress.php') {
-          header("Location: $appDir/showDeployProgress.php?clusterName=" . $cluster['clusterName']);          
-        }
+        if ($requestPage != 'showDeployProgress.php') {
+          $targetPage = 'showDeployProgress.php?clusterName=' . $cluster['clusterName'];
+          $_GET['clusterName'] = $cluster['clusterName'];
+          eval(redirectToPage($requestPage, 'showDeployProgress.php'));
+          exit;
+        }          
+        $clusterState = 'DEPLOYMENT_IN_PROGRESS';
         break;
     } 
   }  

hmc/html/installFailed.php

@@ -0,0 +1,28 @@
+<?php require_once "./head.inc" ?>
+<html>
+  <head>
+    <title id="pageTitleId"><?php echo $RES['page.title'] ?></title>
+
+    <!-- CSS -->
+    <link type="text/css" rel="stylesheet" href="../yui-3.5.1/build/cssreset/cssreset-min.css"> 
+    <link type="text/css" rel="stylesheet" href="../css/bootstrap.css" media="screen"/>
+    <link type="text/css" rel="stylesheet" href="../css/common.css" media="screen"/>
+    <link type="text/css" rel="stylesheet" href="../css/common2.css" media="screen"/>
+    <link type="text/css" rel="stylesheet" href="../css/common3.css" media="screen"/>
+    <link type="text/css" rel="stylesheet" href="../css/selectHosts.css" media="screen"/>
+    <link rel="shortcut icon" href="../images/logo-micro.gif">
+    <!-- End CSS -->
+  </head>
+  <body class="yui3-skin-sam">
+    <?php require "./topnav.htmli"; ?>
+    <div id="ContentDivId"> 
+      <div class="container">
+        <div class="alert alert-important" style="margin-top:40px;padding:20px">
+          <h2 style="margin-bottom:10px"><?php echo $RES['installFailed.header'] ?></h2>
+          <p><?php echo $RES['installFailed.body'] ?></p>
+          <a class='btn btn-large' style='margin-top:20px' href='uninstallWizard.php'><?php echo $RES['installFailed.submit.label'] ?></a>
+        </div>
+      </div>
+    </div>
+  </body>
+</html>

hmc/html/reinstall.php

@@ -20,7 +20,7 @@
         <div class="alert alert-important" style="margin-top:40px;padding:20px">
           <h2 style="margin-bottom:10px"><?php echo $RES['reinstall.header'] ?></h2>
           <p><?php echo $RES['reinstall.body'] ?></p>
-          <a class='btn btn-large' style='margin-top:20px' href='uninstallWizard.php'><?php echo $RES['reinstall.submit.label'] ?></a>
+          <a class='btn btn-large' style='margin-top:20px' href='initializeCluster.php'><?php echo $RES['reinstall.submit.label'] ?></a>
         </div>
       </div>
     </div>

hmc/html/topnav.htmli

@@ -1,10 +1,6 @@
 <!-- START TOPNAV -->
     <?php 
 		if (basename($_SERVER['REQUEST_URI']) == 'initializeCluster.php') {
-			$isInitWizard = true;
-			$logoUrl = 'javascript:void 0';
-        } else {
-        	$isInitWizard = false;
 			$logoUrl = '/hmc/html';
 		}
 	?>
@@ -13,7 +9,7 @@
 			<div class="container">
 				<a href="<?php echo $logoUrl ?>"><img id="logo" src="../images/logo-small.gif"></a>
 				<a class="brand" href="<?php echo $logoUrl ?>"><?php echo $RES['app.name'] ?></a>
-				<?php if (!$isInitWizard) { ?> 
+				<?php if ($clusterState == 'OPERATIONAL') { ?> 
 				<ul class="nav">
 					<li class="active"><a href="/hmc/html">Cluster Management</a>
 					</li>

hmc/js/deployProgress.js

@@ -123,7 +123,7 @@ function renderDeployProgress (deployProgressInfo) {
           '</a>'
       );          
       globalYui.one("#restartInstallationWizardLinkId").on( "click", function(e) {
-        document.location.href = 'reinstall.php';
+        document.location.href = 'installFailed.php';
       });
       globalYui.one('#txnProgressStatusActionsDivId').setStyle('display','block');
 

hmc/php/conf/MessageResources-en.inc

@@ -3,9 +3,15 @@ $RES['app.name']="Hortonworks Management Center";
 $RES['page.title']="Hortonworks Management Center";
 $RES['page.footer.body']="Hortonworks © 2012";
 $RES['welcome.header']="Welcome to Hortonworks Management Center!";
-$RES['welcome.body']="<p>Hortonworks Management Center makes it really easy for you to install, configure, and manage your Hadoop cluster.</p><p>First, we'll walk you through the cluster set up with a 7-step wizard.</p>";
+$RES['welcome.body']="<p>Hortonworks Management Center makes it really easy for you to install, configure, and manage your Hadoop cluster.</p><p>First, we'll walk you through setting up your cluster with a 7-step wizard.</p>";
 $RES['welcome.note']="Before you proceed, make sure you have performed all the pre-installation steps (REFERENCE MATERIAL HERE).";
 $RES['welcome.submit.label']="Let's get started!";
+$RES['installFailed.header']="Cluster installation failed";
+$RES['installFailed.body']="Cluster installation failed.  To continue, you will need to uninstall the cluster first and re-install the cluster.";
+$RES['installFailed.submit.label']="Start the uninstall process";
+$RES['reinstall.header']="You have not set up a cluster yet.";
+$RES['reinstall.body']="We'll walk you through setting up your cluster with a 7-step wizard.";
+$RES['reinstall.submit.label']="Let's get started!";
 $RES['common.sshUsername.label']="SSH Username";
 $RES['common.sshPrivateKeyFile.label']="SSH Private Key File";
 $RES['common.hostsFile.label']="Hosts File (newline-delimited list of hostnames)";
@@ -41,11 +47,11 @@ $RES['addNodesWizard.addNodes.pageSummary.header']="Which nodes are you adding t
 $RES['addNodesWizard.addNodes.pageSummary.body']="We'll use the SSH private key and a file containing a list of hostnames to perform installation on your nodes.  The public key that is paired with the private key must already be installed on all the nodes.";
 $RES['addNodesWizard.addNodes.submit.label']="Add Nodes";
 $RES['addNodesWizard.selectServices.pageSummary.header']='Which services do you want to install?';
-$RES['addNodesWizard.selectServices.pageSummary.body']="Some services are installed by default.";
+$RES['addNodesWizard.selectServices.pageSummary.body']="Some services will be installed by default.";
 $RES['addNodesWizard.selectServices.submit.label']="Deploy";
 $RES['uninstallWizard.pageSummary.header']="Uninstall Cluster";
 $RES['uninstallWizard.pageSummary.body']="<span class='label label-important'>Warning</span>  Proceed with caution!  This will delete all services from all of your nodes in the cluster (and all of your data, if you choose the <i>wipe out</i> option).";
 $RES['uninstallWizard.wipeout.label']="Perform wipe out (delete all data)";
 $RES['uninstallWizard.submit.label']="Uninstall Cluster";
-
+$RES['initWizard.configureClusterAdvanced.validation.error']="We've encountered invalid settings.";
 ?>