AMBARI-9301 - Views: edit view instance not working (tbeerbower)

ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java

@@ -1197,6 +1197,9 @@ public class ViewRegistry {
 
   // sync a given view instance entity with another given view instance entity
   private void syncViewInstance(ViewInstanceEntity instance1, ViewInstanceEntity instance2) {
+    instance1.setLabel(instance2.getLabel());
+    instance1.setDescription(instance2.getDescription());
+    instance1.setVisible(instance2.isVisible());
     instance1.setResource(instance2.getResource());
     instance1.setViewInstanceId(instance2.getViewInstanceId());
     instance1.setData(instance2.getData());

ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java

@@ -930,6 +930,12 @@ public class ViewRegistryTest {
     registry.addDefinition(viewEntity);
     registry.installViewInstance(viewInstanceEntity);
 
+    Assert.assertTrue(viewInstanceEntity.isVisible());
+
+    updateInstance.setLabel("new label");
+    updateInstance.setDescription("new description");
+    updateInstance.setVisible(false);
+
     registry.updateViewInstance(updateInstance);
 
     Collection<ViewInstanceEntity> viewInstanceDefinitions = registry.getInstanceDefinitions(viewEntity);
@@ -938,6 +944,9 @@ public class ViewRegistryTest {
 
     ViewInstanceEntity instanceEntity = viewInstanceDefinitions.iterator().next();
     Assert.assertEquals("v2-1", instanceEntity.getProperty("p2").getValue() );
+    Assert.assertEquals("new label", instanceEntity.getLabel() );
+    Assert.assertEquals("new description", instanceEntity.getDescription() );
+    Assert.assertFalse(instanceEntity.isVisible());
 
     Assert.assertEquals(viewInstanceEntity, viewInstanceDefinitions.iterator().next());