AMBARI-13144. Error during update service configurations while kerberizing cluster post Ambari upgrade (aonishuk)

ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java

@@ -67,6 +67,14 @@ public class ServiceConfigDAO {
             "WHERE scv.serviceName=?1 AND scv.version=?2", ServiceConfigEntity.class);
     return daoUtils.selectOne(query, serviceName, version);
   }
+  
+  @RequiresSession
+  public List<ServiceConfigEntity> findByService(Long clusterId, String serviceName) {
+    TypedQuery<ServiceConfigEntity> query = entityManagerProvider.get().
+        createQuery("SELECT scv FROM ServiceConfigEntity scv " +
+            "WHERE scv.clusterId=?1 AND scv.serviceName=?2", ServiceConfigEntity.class);
+    return daoUtils.selectList(query, clusterId, serviceName);
+  }
 
   @RequiresSession
   public List<ServiceConfigEntity> getLastServiceConfigVersionsForGroups(Collection<Long> configGroupIds) {

ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java

@@ -19,6 +19,7 @@
 package org.apache.ambari.server.state;
 
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.concurrent.locks.ReadWriteLock;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
@@ -33,12 +34,14 @@ import org.apache.ambari.server.events.ServiceRemovedEvent;
 import org.apache.ambari.server.events.publishers.AmbariEventPublisher;
 import org.apache.ambari.server.orm.dao.ClusterDAO;
 import org.apache.ambari.server.orm.dao.ClusterServiceDAO;
+import org.apache.ambari.server.orm.dao.ServiceConfigDAO;
 import org.apache.ambari.server.orm.dao.ServiceDesiredStateDAO;
 import org.apache.ambari.server.orm.dao.StackDAO;
 import org.apache.ambari.server.orm.entities.ClusterEntity;
 import org.apache.ambari.server.orm.entities.ClusterServiceEntity;
 import org.apache.ambari.server.orm.entities.ClusterServiceEntityPK;
 import org.apache.ambari.server.orm.entities.ServiceComponentDesiredStateEntity;
+import org.apache.ambari.server.orm.entities.ServiceConfigEntity;
 import org.apache.ambari.server.orm.entities.ServiceDesiredStateEntity;
 import org.apache.ambari.server.orm.entities.StackEntity;
 import org.slf4j.Logger;
@@ -67,6 +70,8 @@ public class ServiceImpl implements Service {
   private Map<String, ServiceComponent> components;
   private final boolean isClientOnlyService;
 
+  @Inject
+  private ServiceConfigDAO serviceConfigDAO;
   @Inject
   private ClusterServiceDAO clusterServiceDAO;
   @Inject
@@ -538,6 +543,20 @@ public class ServiceImpl implements Service {
     }
   }
 
+  @Transactional
+  void deleteAllServiceConfigs() throws AmbariException {
+    LOG.info("Deleting all serviceconfigs for service"
+        + ", clusterName=" + cluster.getClusterName()
+        + ", serviceName=" + getName());
+    
+    List<ServiceConfigEntity> serviceConfigEntities = serviceConfigDAO.findByService(cluster.getClusterId(), getName());
+
+    for (ServiceConfigEntity serviceConfigEntity : serviceConfigEntities) {
+      serviceConfigDAO.remove(serviceConfigEntity);
+    }
+
+  }
+  
   @Override
   @Transactional
   public void deleteAllComponents() throws AmbariException {
@@ -617,6 +636,7 @@ public class ServiceImpl implements Service {
       readWriteLock.writeLock().lock();
       try {
         deleteAllComponents();
+        deleteAllServiceConfigs();
 
         if (persisted) {
           removeEntities();