Browse Source

AMBARI-1151. Reconfigure fails silently; it's not firing any API calls due to a JS error. (yusaku)

git-svn-id: https://svn.apache.org/repos/asf/incubator/ambari/trunk@1431770 13f79535-47bb-0310-9956-ffa450edef68
Yusaku Sako 12 years ago
parent
commit
bab1f46b26
2 changed files with 7 additions and 1 deletions
  1. 3 0
      CHANGES.txt
  2. 4 1
      ambari-web/app/controllers/main/service/info/configs.js

+ 3 - 0
CHANGES.txt

@@ -667,6 +667,9 @@ AMBARI-666 branch (unreleased changes)
 
   BUG FIXES
 
+  AMBARI-1151. Reconfigure fails silently; it's not firing any API calls due
+  to a JS error. (yusaku)
+
   AMBARI-1098. Switching services does not update various UI elements.
   (Srimanth Gunturi via yusaku)
 

+ 4 - 1
ambari-web/app/controllers/main/service/info/configs.js

@@ -569,7 +569,10 @@ App.MainServiceInfoConfigsController = Em.Controller.extend({
       if (this.get('globalConfigs').someProperty('name', templateName[index])) {
         //console.log("The name of the variable is: " + this.get('content.serviceConfigProperties').findProperty('name', templateName[index]).name);
         var globValue = this.get('globalConfigs').findProperty('name', templateName[index]).value;
-        value = value.replace(_express, globValue);
+        // TODO: hack to make reconfig work for now due to some hive params breaking reconfig in general
+        if (value != null) {
+          value = value.replace(_express, globValue);
+        }
       } else {
         /*
          console.log("ERROR: The variable name is: " + templateName[index]);