AMBARI-7270. FE: Errors in /recommendation API being silently ignored

ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java

@@ -75,7 +75,15 @@ public class StackAdvisorRunner {
         if (exitCode > 0) {
           String errorMessage;
           if (errMessage != null) {
-            errorMessage = errMessage.substring(errMessage.lastIndexOf("\n"));
+            // We want to get the last line.
+            int index = errMessage.lastIndexOf("\n");
+            if (index > 0 && index == (errMessage.length() - 1)) {
+              index = errMessage.lastIndexOf("\n", index - 1); // sentence ended with newline
+            }
+            if (index > -1) {
+              errMessage = errMessage.substring(index + 1).trim();
+            }
+            errorMessage = errMessage;
           } else {
             errorMessage = "Error occurred during stack advisor execution";
           }

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java

@@ -93,12 +93,10 @@ public class RecommendationResourceProvider extends StackAdvisorResourceProvider
       response = saHelper.recommend(recommendationRequest);
     } catch (StackAdvisorRequestException e) {
       LOG.warn("Error occured during recommnedation", e);
-      throw new WebApplicationException(Response.status(Status.BAD_REQUEST).entity(e.getMessage())
-          .build());
+      throw new IllegalArgumentException(e.getMessage(), e);
     } catch (StackAdvisorException e) {
       LOG.warn("Error occured during recommnedation", e);
-      throw new WebApplicationException(Response.status(Status.INTERNAL_SERVER_ERROR).entity(e.getMessage())
-          .build());
+      throw new SystemException(e.getMessage(), e);
     }
 
     Resource recommendation = createResources(new Command<Resource>() {

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java

@@ -85,12 +85,10 @@ public class ValidationResourceProvider extends StackAdvisorResourceProvider {
       response = saHelper.validate(validationRequest);
     } catch (StackAdvisorRequestException e) {
       LOG.warn("Error occurred during validation", e);
-      throw new WebApplicationException(Response.status(Status.BAD_REQUEST).entity(e.getMessage())
-          .build());
+      throw new IllegalArgumentException(e.getMessage(), e);
     } catch (StackAdvisorException e) {
       LOG.warn("Error occurred during validation", e);
-      throw new WebApplicationException(Response.status(Status.INTERNAL_SERVER_ERROR).entity(e.getMessage())
-          .build());
+      throw new SystemException(e.getMessage(), e);
     }
 
     Resource validation = createResources(new Command<Resource>() {

ambari-web/app/controllers/wizard/step5_controller.js

@@ -281,19 +281,13 @@ App.WizardStep5Controller = Em.Controller.extend(App.BlueprintMixin, {
         validate: 'host_groups',
         recommendations: blueprint
       },
-      success: 'updateValidationsSuccessCallback'
+      success: 'updateValidationsSuccessCallback',
+      error: 'updateValidationsErrorCallback'
     }).
-      retry({
-        times: App.maxRetries,
-        timeout: App.timeout
-      }).
       then(function() {
         if (callback) {
           callback();
         }
-      }, function () {
-        App.showReloadPopup();
-        console.log('Load validations failed');
       }
     );
   },
@@ -306,8 +300,8 @@ App.WizardStep5Controller = Em.Controller.extend(App.BlueprintMixin, {
   updateValidationsSuccessCallback: function (data) {
     var self = this;
 
-    generalErrorMessages = [];
-    generalWarningMessages = [];
+    var generalErrorMessages = [];
+    var generalWarningMessages = [];
     this.get('servicesMasters').setEach('warnMessage', null);
     this.get('servicesMasters').setEach('errorMessage', null);
     var anyErrors = false;
@@ -343,6 +337,19 @@ App.WizardStep5Controller = Em.Controller.extend(App.BlueprintMixin, {
     this.set('submitDisabled', false); //this.set('submitDisabled', anyErrors);
   },
 
+  /**
+   * Error-callback for validations request
+   * @param {object} jqXHR
+   * @param {object} ajaxOptions
+   * @param {string} error
+   * @param {object} opt
+   * @method updateValidationsErrorCallback
+   */
+  updateValidationsErrorCallback: function (jqXHR, ajaxOptions, error, opt) {
+    App.ajax.defaultErrorHandler(jqXHR, opt.url, opt.method, jqXHR.status);
+    console.log('Load validations failed');
+  },
+
   /**
    * Composes selected values of comboboxes into master blueprint + merge it with currenlty installed slave blueprint
    */
@@ -532,20 +539,12 @@ App.WizardStep5Controller = Em.Controller.extend(App.BlueprintMixin, {
         name: 'wizard.loadrecommendations',
         sender: self,
         data: data,
-        success: 'loadRecommendationsSuccessCallback'
+        success: 'loadRecommendationsSuccessCallback',
+        error: 'loadRecommendationsErrorCallback'
       }).
-        retry({
-          times: App.maxRetries,
-          timeout: App.timeout
-        }).
         then(function () {
           callback(self.createComponentInstallationObjects(), self);
-        },
-        function () {
-          App.showReloadPopup();
-          console.log('Load recommendations failed');
-        }
-      );
+        });
     }
   },
 
@@ -647,6 +646,19 @@ App.WizardStep5Controller = Em.Controller.extend(App.BlueprintMixin, {
     this.set('content.recommendations', data.resources[0].recommendations);
   },
 
+  /**
+   * Error-callback for recommendations request
+   * @param {object} jqXHR
+   * @param {object} ajaxOptions
+   * @param {string} error
+   * @param {object} opt
+   * @method loadRecommendationsErrorCallback
+   */
+  loadRecommendationsErrorCallback: function (jqXHR, ajaxOptions, error, opt) {
+    App.ajax.defaultErrorHandler(jqXHR, opt.url, opt.method, jqXHR.status);
+    console.log('Load recommendations failed');
+  },
+
   /**
    * Load services info to appropriate variable and return masterComponentHosts
    * @return {Object[]}

ambari-web/app/controllers/wizard/step6_controller.js

@@ -69,7 +69,7 @@ App.WizardStep6Controller = Em.Controller.extend(App.BlueprintMixin, {
    * Define state for submit button
    * @type {bool}
    */
-  submitDisabled: true,
+  submitDisabled: false,
 
   /**
    * Check if <code>addHostWizard</code> used
@@ -544,7 +544,9 @@ App.WizardStep6Controller = Em.Controller.extend(App.BlueprintMixin, {
    */
   callServerSideValidation: function (successCallback) {
     var self = this;
-    self.set('submitDisabled', true);
+
+    // We do not want to disable Next due to server validation issues - hence commented out line below
+    // self.set('submitDisabled', true);
 
     var selectedServices = App.StackService.find().filterProperty('isSelected').mapProperty('serviceName');
     var installedServices = App.StackService.find().filterProperty('isInstalled').mapProperty('serviceName');
@@ -593,19 +595,13 @@ App.WizardStep6Controller = Em.Controller.extend(App.BlueprintMixin, {
         validate: 'host_groups',
         recommendations: bluePrintsForValidation
       },
-      success: 'updateValidationsSuccessCallback'
+      success: 'updateValidationsSuccessCallback',
+      error: 'updateValidationsErrorCallback'
     }).
-      retry({
-        times: App.maxRetries,
-        timeout: App.timeout
-      }).
       then(function () {
         if (!self.get('submitDisabled') && successCallback) {
           successCallback();
         }
-      }, function () {
-        App.showReloadPopup();
-        console.log('Load validations failed');
       }
     );
   },
@@ -690,7 +686,20 @@ App.WizardStep6Controller = Em.Controller.extend(App.BlueprintMixin, {
 
     // use this.set('submitDisabled', anyErrors); is validation results should block next button
     // It's because showValidationIssuesAcceptBox allow use accept validation issues and continue
-    this.set('submitDisabled', false);
+    // this.set('submitDisabled', false);
+  },
+
+  /**
+   * Error-callback for validations request
+   * @param {object} jqXHR
+   * @param {object} ajaxOptions
+   * @param {string} error
+   * @param {object} opt
+   * @method updateValidationsErrorCallback
+   */
+  updateValidationsErrorCallback: function (jqXHR, ajaxOptions, error, opt) {
+    App.ajax.defaultErrorHandler(jqXHR, opt.url, opt.method, jqXHR.status);
+    console.log('Load validations failed');
   },
 
   /**

ambari-web/app/controllers/wizard/step7_controller.js

@@ -1343,11 +1343,22 @@ App.WizardStep7Controller = Em.Controller.extend(App.ServerValidatorMixin, {
     }
     var self = this;
     this.set('submitButtonClicked', true);
-    this.serverSideValidation().done(function () {
-      self.checkDatabaseConnectionTest().done(function () {
+    this.serverSideValidation().done(function() {
+      self.checkDatabaseConnectionTest().done(function() {
         self.resolveHiveMysqlDatabase();
         self.set('submitButtonClicked', false);
       });
+    }).fail(function(value){
+      if ("invalid_configs" == value) {
+        self.set('submitButtonClicked', false);
+      } else {
+        // Failed due to validation mechanism failure.
+        // Should proceed with other checks
+        self.checkDatabaseConnectionTest().done(function() {
+          self.resolveHiveMysqlDatabase();
+          self.set('submitButtonClicked', false);
+        });
+      }
     });
   }
 

ambari-web/app/mixins/common/serverValidator.js

@@ -134,7 +134,8 @@ App.ServerValidatorMixin = Em.Mixin.create({
     this.set("recommendationsConfigs", Em.get(data.resources[0] , "recommendations.blueprint.configurations"));
   },
 
-  loadRecommendationsError: function() {
+  loadRecommendationsError: function(jqXHR, ajaxOptions, error, opt) {
+    App.ajax.defaultErrorHandler(jqXHR, opt.url, opt.method, jqXHR.status);
     console.error('Load recommendations failed');
   },
 
@@ -251,8 +252,9 @@ App.ServerValidatorMixin = Em.Mixin.create({
     });
   },
 
-  validationError: function() {
+  validationError: function (jqXHR, ajaxOptions, error, opt) {
     this.set('configValidationFailed', true);
+    App.ajax.defaultErrorHandler(jqXHR, opt.url, opt.method, jqXHR.status);
     console.error('config validation failed');
   },
 
@@ -279,7 +281,7 @@ App.ServerValidatorMixin = Em.Mixin.create({
         },
         onSecondary: function () {
           this.hide();
-          deferred.reject();
+          deferred.reject("invalid_configs"); // message used to differentiate types of rejections.
         },
         bodyClass: Em.View.extend({
           controller: self,