Sfoglia il codice sorgente

AMBARI-2480. Dashboard page has a lot of footer padding. (Xi Wang via yusaku)

git-svn-id: https://svn.apache.org/repos/asf/incubator/ambari/trunk@1498750 13f79535-47bb-0310-9956-ffa450edef68
Yusaku Sako 12 anni fa
parent
commit
9a5e18dfb0

+ 16 - 28
ambari-web/app/styles/application.less

@@ -39,7 +39,7 @@ html, body {
 @footer-height: 100px;
 
 #main {
-  overflow: visible;
+  overflow: hidden;
   padding-bottom: @footer-height;
   min-width: 980px;
 }
@@ -1935,6 +1935,8 @@ table.graphs {
       color: #666666;
     }
     .filter-components{
+      overflow: auto;
+      height: 375px;
       color: #333333;
       right: 0;
       left: auto;
@@ -2055,7 +2057,13 @@ table.graphs {
       font-size: 12px;
       text-align: left;
     }
-
+    .thumbnail .icon-remove-sign{
+      color: #000000;
+      text-shadow: #fff 0px 0px 15px;
+      position: relative;
+      left: -17px;
+      top: -7px;
+    }
     .thumbnail .widget-content{
       text-align: center;
       font-size: 35px;
@@ -2095,16 +2103,10 @@ table.graphs {
       .corner-icon{
         display:block;
         text-decoration: none;
-        .icon-remove-sign{
-          color: #000000;
-          text-shadow: #fff 0px 0px 15px;
-          position:absolute;
-          margin-left: -17px;
-          margin-top: -7px;
-        }
       }
       .caption{
         color: #ffffff;
+        margin-left: -5px;
         text-shadow: #000 0px 0px 15px;
       }
       .rickshaw_legend{
@@ -2153,16 +2155,10 @@ table.graphs {
       .corner-icon{
         display:block;
         text-decoration: none;
-        .icon-remove-sign{
-          color: #000000;
-          text-shadow: #fff 0px 0px 15px;
-          position:absolute;
-          margin-left: -17px;
-          margin-top: -7px;
-        }
       }
       .caption{
         color: #ffffff;
+        margin-left: -5px;
         text-shadow: #000 0px 0px 15px;
       }
       .widget-content{
@@ -2180,13 +2176,6 @@ table.graphs {
       .corner-icon{
         display:block;
         text-decoration: none;
-        .icon-remove-sign{
-          color: #000000;
-          text-shadow: #fff 0px 0px 15px;
-          position:absolute;
-          margin-left: -17px;
-          margin-top: -7px;
-        }
       }
       .hidden-info{
         display: block;
@@ -2194,19 +2183,18 @@ table.graphs {
       .hidden-info-three-line{
         display: block;
       }
+      .caption{
+        color: #ffffff;
+        margin-left: -5px;
+      }
       .widget-content{
         display: none;
       }
       .widget-content-isNA{
         display: none;
       }
-      .caption{
-        color: #ffffff;
-      }
     }
 
-
-
     .thumbnail .widget-content .svg {
       position:relative;
     }

+ 9 - 9
ambari-web/app/templates/main/dashboard.hbs

@@ -21,16 +21,16 @@
       <div class="span6">
         <div class="row">
           <div class="span6">
-              <div class="box">
-                  <div class="box-header">
-                      <h4>{{t dashboard.services}}</h4>
-                  </div>
-                  <dl class="dl-horizontal services">
-                    {{#each item in view.content}}
-                      {{view item.viewName serviceBinding="item.model"}}
-                    {{/each}}
-                  </dl>
+            <div class="box">
+              <div class="box-header">
+                <h4>{{t dashboard.services}}</h4>
               </div>
+              <dl class="dl-horizontal services">
+                {{#each item in view.content}}
+                  {{view item.viewName serviceBinding="item.model"}}
+                {{/each}}
+              </dl>
+            </div>
           </div>
         </div>
       </div>

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/cluster_metrics.hbs

@@ -18,7 +18,7 @@
 
 <div class="cluster-metrics">
   <li class="thumbnail row">
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}>
         <i class="icon-remove-sign icon-large"></i>
     </a>
     <div class="caption span10">{{view.title}}</div>

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs

@@ -18,7 +18,7 @@
 
 <div class="links">
   <li class="thumbnail row">
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}><i class="icon-remove-sign icon-large"></i></a>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}><i class="icon-remove-sign icon-large"></i></a>
     <div class="caption span10"> {{view.title}}</div>
 
     <div class="widget-content" >

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs

@@ -18,7 +18,7 @@
 
 <div class="links">
   <li class="thumbnail row">
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}>
       <i class="icon-remove-sign icon-large"></i>
     </a>
     <div class="caption span10"> {{view.title}}</div>

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/mapreduce_links.hbs

@@ -18,7 +18,7 @@
 
 <div class="links">
   <li class="thumbnail row">
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}>
       <i class="icon-remove-sign icon-large"></i>
     </a>
     <div class="caption span10"> {{view.title}}</div>

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/mapreduce_slots.hbs

@@ -18,7 +18,7 @@
 
 <div class="has-hidden-info">
   <li class="thumbnail row" >
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}><i class="icon-remove-sign icon-large"></i></a>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}><i class="icon-remove-sign icon-large"></i></a>
     <div class="caption span10"> {{view.title}}</div>
 
     <div class="hidden-info">

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/pie_chart.hbs

@@ -18,7 +18,7 @@
 
 <div class="has-hidden-info">
   <li class="thumbnail row">
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}>
       <i class="icon-remove-sign icon-large"></i>
     </a>
     <div class="caption span10">{{view.title}}</div>

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/simple_text.hbs

@@ -18,7 +18,7 @@
 
 <div class="has-hidden-info">
   <li class="thumbnail row" >
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}>
       <i class="icon-remove-sign icon-large"></i>
     </a>
     <div class="caption span10"> {{view.title}}</div>

+ 1 - 1
ambari-web/app/templates/main/dashboard/widgets/uptime.hbs

@@ -18,7 +18,7 @@
 
 <div class="has-hidden-info">
   <li class="thumbnail row" >
-    <a class="corner-icon" href="#" {{action deleteWidget target="view"}}>
+    <a class="corner-icon span1" href="#" {{action deleteWidget target="view"}}>
       <i class="icon-remove-sign icon-large"></i>
     </a>
     <div class="caption span11"> {{view.title}} </div>

+ 1 - 3
ambari-web/app/views/main/dashboard.js

@@ -151,7 +151,6 @@ App.MainDashboardView = Em.View.extend({
             visibleWidgets.pushObject(new_obj);
             hiddenWidgets.removeObject(item);
           }, this);
-
         } else {
           //save in persist
           parent.getUserPref(parent.get('persistKey'));
@@ -168,12 +167,11 @@ App.MainDashboardView = Em.View.extend({
           }, this);
           hiddenWidgets.forEach(function(item){
             newValue.hidden.push([item.id, item.displayName]);
-          },this);
+          }, this);
 
           parent.postUserPref(parent.get('persistKey'), newValue);
           parent.translateToReal(newValue);
         }
-
       }
     })
   }),

+ 6 - 7
ambari-web/app/views/main/dashboard/widget.js

@@ -58,12 +58,12 @@ App.DashboardWidgetView = Em.View.extend({
 
   deleteWidget: function (event) {
     var parent = this.get('parentView');
-    if(App.testMode) {
-      //update view on dashboard
-      var obj_class = parent.widgetsMapper(this.id);
-      parent.get('visibleWidgets').removeObject(obj_class);
-      parent.get('hiddenWidgets').pushObject(Em.Object.create({displayName: this.title, id: this.id, checked: false}));
-    }else{
+    //update view on dashboard
+    var obj_class = parent.widgetsMapper(this.id);
+    parent.get('visibleWidgets').removeObject(obj_class);
+    parent.get('hiddenWidgets').pushObject(Em.Object.create({displayName: this.title, id: this.id, checked: false}));
+
+    if (!App.testMode) {
       //reconstruct new persist value then post in persist
       parent.getUserPref(parent.get('persistKey'));
       var oldValue = parent.get('currentPrefObject');
@@ -81,7 +81,6 @@ App.DashboardWidgetView = Em.View.extend({
       }
       newValue.hidden.push([deletedId, this.title]);
       parent.postUserPref(parent.get('persistKey'), newValue);
-      parent.translateToReal(newValue);
     }
 
   },