AMBARI-12957. FE: Do better handling for missed max or min jdk in stack definition. (alexantonenko)

ambari-web/app/controllers/installer.js

@@ -741,8 +741,9 @@ App.InstallerController = App.WizardController.extend({
   validateJDKVersion: function (successCallback, failCallback) {
     var selectedStack = App.Stack.find().findProperty('isSelected', true),
         currentJDKVersion = App.router.get('clusterController.ambariProperties')['java.version'],
-        minJDKVersion = selectedStack.get('minJdkVersion'),
-        maxJDKVersion = selectedStack.get('maxJdkVersion'),
+        // use min as max, or max as min version, in case when some of them missed
+        minJDKVersion = selectedStack.get('minJdkVersion') || selectedStack.get('maxJdkVersion'),
+        maxJDKVersion = selectedStack.get('maxJdkVersion') || selectedStack.get('minJdkVersion'),
         t = Em.I18n.t,
         fCallback = failCallback || function() {},
         sCallback = successCallback || function() {};
@@ -754,9 +755,9 @@ App.InstallerController = App.WizardController.extend({
     }
 
     if (currentJDKVersion) {
-      if (stringUtils.compareVersions(currentJDKVersion, selectedStack.get('minJdkVersion')) < 0 ||
-          stringUtils.compareVersions(selectedStack.get('maxJdkVersion'), currentJDKVersion) < 0) {
-        // checks and process only major part for now
+      if (stringUtils.compareVersions(currentJDKVersion, minJDKVersion) < 0 ||
+          stringUtils.compareVersions(maxJDKVersion, currentJDKVersion) < 0) {
+        // checks and process only minor part for now
         var versionDistance = parseInt(maxJDKVersion.split('.')[1]) - parseInt(minJDKVersion.split('.')[1]);
         var versionsList = [minJDKVersion];
         for (var i = 1; i < (versionDistance + 1); i++) {

ambari-web/test/controllers/installer_test.js

@@ -1015,6 +1015,76 @@ describe('App.InstallerController', function () {
         })],
         m: 'JDK 1.5, stack supports 1.6-1.8, popup should be displayed'
       },
+      {
+        isCustomJDK: false,
+        ambariProperties: {
+          'java.version': '1.5'
+        },
+        successCallbackCalled: true,
+        popupCalled: false,
+        stacks: [Em.Object.create({
+          minJdkVersion: null,
+          maxJdkVersion: null,
+          isSelected: true
+        })],
+        m: 'JDK 1.5, stack supports max and min are null, procceed installation without warning'
+      },
+      {
+        isCustomJDK: false,
+        ambariProperties: {
+          'java.version': '1.5'
+        },
+        successCallbackCalled: true,
+        popupCalled: false,
+        stacks: [Em.Object.create({
+          minJdkVersion: '1.5',
+          maxJdkVersion: null,
+          isSelected: true
+        })],
+        m: 'JDK 1.5, stack supports max is missed and min is 1.5, procceed installation without warning'
+      },
+      {
+        isCustomJDK: false,
+        ambariProperties: {
+          'java.version': '1.6'
+        },
+        successCallbackCalled: false,
+        popupCalled: true,
+        stacks: [Em.Object.create({
+          minJdkVersion: '1.5',
+          maxJdkVersion: null,
+          isSelected: true
+        })],
+        m: 'JDK 1.6, stack supports max is missed and min is 1.5, popup should be displayed'
+      },
+      {
+        isCustomJDK: false,
+        ambariProperties: {
+          'java.version': '1.5'
+        },
+        successCallbackCalled: true,
+        popupCalled: false,
+        stacks: [Em.Object.create({
+          minJdkVersion: null,
+          maxJdkVersion: '1.5',
+          isSelected: true
+        })],
+        m: 'JDK 1.5, stack supports max 1.5 and min is missed, procceed installation without warning'
+      },
+      {
+        isCustomJDK: false,
+        ambariProperties: {
+          'java.version': '1.5'
+        },
+        successCallbackCalled: false,
+        popupCalled: true,
+        stacks: [Em.Object.create({
+          minJdkVersion: null,
+          maxJdkVersion: '1.8',
+          isSelected: true
+        })],
+        m: 'JDK 1.5, stack supports max 1.8 and min is missed, popup should be displayed'
+      },
       {
         isCustomJDK: false,
         ambariProperties: {