AMBARI-18446. Review necessity of xmllint and remove libxml2-utils package from Oozie manifest (aonishuk)

ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/metainfo.xml

@@ -142,9 +142,6 @@
             <package>
               <name>extjs</name>
             </package>
-            <package>
-              <name>libxml2-utils</name>
-            </package>
           </packages>
         </osSpecific>
 

ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh

@@ -34,11 +34,6 @@ export smoke_user_keytab=${11}
 export kinit_path_local=${12}
 export smokeuser_principal=${13}
 
-function getValueFromField {
-  xmllint $1 | grep "<name>$2</name>" -C 2 | grep '<value>' | cut -d ">" -f2 | cut -d "<" -f1
-  return $?
-}
-
 function checkOozieJobStatus {
   local job_id=$1
   local num_of_tries=$2

ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py

@@ -26,8 +26,6 @@ from resource_management.core.source import StaticFile
 from resource_management.core.system import System
 from resource_management.libraries.functions import format
 from resource_management.libraries.script import Script
-from resource_management.libraries.resources.xml_config import XmlConfig
-from resource_management.core.exceptions import Fail
 from ambari_commons.os_family_impl import OsFamilyImpl
 from ambari_commons import OSConst
 
@@ -47,17 +45,6 @@ class OozieServiceCheckDefault(OozieServiceCheck):
     prepare_hdfs_file_name = 'prepareOozieHdfsDirectories.sh'
     smoke_test_file_name = 'oozieSmoke2.sh'
 
-    if 'yarn-site' in params.config['configurations']:
-      XmlConfig("yarn-site.xml",
-                conf_dir=params.hadoop_conf_dir,
-                configurations=params.config['configurations']['yarn-site'],
-                owner=params.hdfs_user,
-                group=params.user_group,
-                mode=0644
-      )
-    else:
-      raise Fail("yarn-site.xml was not present in config parameters.")
-
     OozieServiceCheckDefault.oozie_smoke_shell_file(smoke_test_file_name, prepare_hdfs_file_name)
 
   @staticmethod

ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/metainfo.xml

@@ -155,9 +155,6 @@
             <package>
               <name>extjs</name>
             </package>
-            <package>
-              <name>libxml2-utils</name>
-            </package>
           </packages>
         </osSpecific>
       </osSpecifics>

ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml

@@ -56,9 +56,6 @@
             <package>
               <name>extjs</name>
             </package>
-            <package>
-              <name>libxml2-utils</name>
-            </package>
           </packages>
         </osSpecific>
 

ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/metainfo.xml

@@ -97,9 +97,6 @@
             <package>
               <name>extjs</name>
             </package>
-            <package>
-              <name>libxml2-utils</name>
-            </package>
           </packages>
         </osSpecific>
       </osSpecifics>

ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_service_check.py

@@ -53,14 +53,6 @@ class TestOozieServiceCheck(RMFTestCase):
 
     self.maxDiff = None
 
-    self.assertResourceCalled('XmlConfig',
-      "yarn-site.xml",
-      owner = "hdfs",
-      group = "hadoop",
-      mode = 0644,
-      conf_dir="/usr/hdp/current/hadoop-client/conf",
-      configurations = json_content['configurations']['yarn-site'])
-
     self.assertResourceCalled('File',
       "/tmp/oozieSmoke2.sh",
       content = StaticFile("oozieSmoke2.sh"),

ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py

@@ -37,14 +37,6 @@ class TestServiceCheck(RMFTestCase):
                         target = RMFTestCase.TARGET_COMMON_SERVICES
     )
 
-    self.assertResourceCalled('XmlConfig', 'yarn-site.xml',
-      owner = 'hdfs',
-      group = 'hadoop',
-      conf_dir = '/etc/hadoop/conf',
-      mode = 0644,
-      configurations = self.getConfig()['configurations']['yarn-site'],
-    )
-
     self.assert_service_check()
     self.assertNoMoreResources()
     
@@ -58,14 +50,6 @@ class TestServiceCheck(RMFTestCase):
                         target = RMFTestCase.TARGET_COMMON_SERVICES
     )
 
-    self.assertResourceCalled('XmlConfig', 'yarn-site.xml',
-      owner = 'hdfs',
-      group = 'hadoop',
-      conf_dir = '/etc/hadoop/conf',
-      mode = 0644,
-      configurations = self.getConfig()['configurations']['yarn-site'],
-    )
-
     self.assert_service_check()
     self.assertNoMoreResources()