AMBARI-25516. Missing @Override on methods (#3200) (rickyma via dgrinenko)

ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkConnection.java

@@ -40,11 +40,9 @@ public class ZkConnection {
     throws IOException, InterruptedException, IllegalStateException
   {
     final CountDownLatch connSignal = new CountDownLatch(1);
-    ZooKeeper zooKeeper = new ZooKeeper(serverAddress, sessionTimeoutMillis, new Watcher() {
-      public void process(WatchedEvent event) {
-        if (event.getState() == SyncConnected) {
-          connSignal.countDown();
-        }
+    ZooKeeper zooKeeper = new ZooKeeper(serverAddress, sessionTimeoutMillis, event -> {
+      if (event.getState() == SyncConnected) {
+        connSignal.countDown();
       }
     });
     connSignal.await(connectionTimeoutMillis, MILLISECONDS);

ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java

@@ -206,10 +206,12 @@ public class AppCookieManager {
 
   private static class EmptyJaasCredentials implements Credentials {
 
+    @Override
     public String getPassword() {
       return null;
     }
 
+    @Override
     public Principal getUserPrincipal() {
       return null;
     }

ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java

@@ -68,12 +68,10 @@ public class HadoopTimelineMetricsSink extends AbstractTimelineMetricsSink imple
   // Cache the rpc port used and the suffix to use if the port tag is found
   private Map<String, String> rpcPortSuffixes = new HashMap<>(10);
 
-  private final ExecutorService executorService = Executors.newSingleThreadExecutor(new ThreadFactory() {
-    public Thread newThread(Runnable r) {
-      Thread t = Executors.defaultThreadFactory().newThread(r);
-      t.setDaemon(true);
-      return t;
-    }
+  private final ExecutorService executorService = Executors.newSingleThreadExecutor(r -> {
+    Thread t = Executors.defaultThreadFactory().newThread(r);
+    t.setDaemon(true);
+    return t;
   });
   private int hostInMemoryAggregationPort;
   private boolean hostInMemoryAggregationEnabled;

ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java

@@ -240,11 +240,7 @@ public class AggregatorApplication {
 
     app.startWebServerAndPublishersThreads();
 
-    Runtime.getRuntime().addShutdownHook(new Thread() {
-      public void run() {
-        app.stop();
-      }
-    });
+    Runtime.getRuntime().addShutdownHook(new Thread(() -> app.stop()));
   }
 
   private void startWebServerAndPublishersThreads() {

ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java

@@ -228,10 +228,12 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink
     }
   }
 
+  @Override
   public String getMBeanName() {
     return "kafka:type=org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter";
   }
 
+  @Override
   public synchronized void startReporter(long period) {
     synchronized (lock) {
       if (initialized && !running) {
@@ -242,6 +244,7 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink
     }
   }
 
+  @Override
   public synchronized void stopReporter() {
     synchronized (lock) {
       if (initialized && running) {
@@ -315,11 +318,7 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink
         for (Entry<MetricName, Metric> entry : metrics) {
           final MetricName metricName = entry.getKey();
           final Metric metric = entry.getValue();
-          Context context = new Context() {
-            public List<TimelineMetric> getTimelineMetricList() {
-              return metricsList;
-            }
-          };
+          Context context = () -> metricsList;
           metric.processWith(this, metricName, context);
         }
       } catch (Throwable t) {

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/HBaseTimelineMetricsService.java

@@ -402,6 +402,7 @@ public class HBaseTimelineMetricsService extends AbstractService implements Time
     return metricsFunctions;
   }
 
+  @Override
   public TimelinePutResponse putMetricsSkipCache(TimelineMetrics metrics) throws SQLException, IOException {
     TimelinePutResponse response = new TimelinePutResponse();
     hBaseAccessor.insertMetricRecordsWithMetadata(metricMetadataManager, metrics, true);

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/TimelineMetricStoreWatcher.java

@@ -98,15 +98,13 @@ public class TimelineMetricStoreWatcher implements Runnable {
     final TimelineMetrics metrics = new TimelineMetrics();
     metrics.setMetrics(Collections.singletonList(fakeMetric));
 
-    Callable<TimelineMetric> task = new Callable<TimelineMetric>() {
-      public TimelineMetric call() throws Exception {
-        timelineMetricStore.putMetricsSkipCache(metrics);
-        TimelineMetrics timelineMetrics = timelineMetricStore.getTimelineMetrics(
-          Collections.singletonList(FAKE_METRIC_NAME), Collections.singletonList(FAKE_HOSTNAME),
-          FAKE_APP_ID, null, startTime - delay * 2 * 1000,
-          startTime + delay * 2 * 1000, Precision.SECONDS, 1, true, null, null);
-        return timelineMetrics.getMetrics().get(0);
-      }
+    Callable<TimelineMetric> task = () -> {
+      timelineMetricStore.putMetricsSkipCache(metrics);
+      TimelineMetrics timelineMetrics = timelineMetricStore.getTimelineMetrics(
+        Collections.singletonList(FAKE_METRIC_NAME), Collections.singletonList(FAKE_HOSTNAME),
+        FAKE_APP_ID, null, startTime - delay * 2 * 1000,
+        startTime + delay * 2 * 1000, Precision.SECONDS, 1, true, null, null);
+      return timelineMetrics.getMetrics().get(0);
     };
 
     Future<TimelineMetric> future = executor.submit(task);

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/aggregators/AbstractTimelineAggregator.java

@@ -253,6 +253,7 @@ public abstract class AbstractTimelineAggregator implements TimelineMetricAggreg
    * @param startTime Sample start time
    * @param endTime Sample end time
    */
+  @Override
   public boolean doWork(long startTime, long endTime) {
     LOG.info("Start aggregation cycle @ " + new Date() + ", " +
       "startTime = " + new Date(startTime) + ", endTime = " + new Date(endTime));
@@ -357,6 +358,7 @@ public abstract class AbstractTimelineAggregator implements TimelineMetricAggreg
 
   }
 
+  @Override
   public Long getSleepIntervalMillis() {
     return sleepIntervalMillis;
   }
@@ -373,6 +375,7 @@ public abstract class AbstractTimelineAggregator implements TimelineMetricAggreg
     return getCheckpointCutOffMultiplier() * getSleepIntervalMillis();
   }
 
+  @Override
   public boolean isDisabled() {
     return metricsConf.getBoolean(aggregatorDisableParam, false);
   }

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/query/DefaultCondition.java

@@ -80,18 +80,22 @@ public class DefaultCondition implements Condition {
     this.grouped = grouped;
   }
 
+  @Override
   public String getStatement() {
     return statement;
   }
 
+  @Override
   public void setStatement(String statement) {
     this.statement = statement;
   }
 
+  @Override
   public List<String> getMetricNames() {
     return metricNames == null || metricNames.isEmpty() ? null : metricNames;
   }
 
+  @Override
   public StringBuilder getConditionClause() {
     StringBuilder sb = new StringBuilder();
     boolean appendConjunction = appendUuidClause(sb);
@@ -115,18 +119,22 @@ public class DefaultCondition implements Condition {
     return appendConjunction;
   }
 
+  @Override
   public List<String> getHostnames() {
     return hostnames;
   }
 
+  @Override
   public Precision getPrecision() {
     return precision;
   }
 
+  @Override
   public void setPrecision(Precision precision) {
     this.precision = precision;
   }
 
+  @Override
   public String getAppId() {
     if (appId != null && !appId.isEmpty()) {
       if (!(appId.equals("HOST") || appId.equals("FLUME_HANDLER"))) {
@@ -138,6 +146,7 @@ public class DefaultCondition implements Condition {
     return null;
   }
 
+  @Override
   public String getInstanceId() {
     return instanceId == null || instanceId.isEmpty() ? null : instanceId;
   }
@@ -145,6 +154,7 @@ public class DefaultCondition implements Condition {
   /**
    * Convert to millis.
    */
+  @Override
   public Long getStartTime() {
     if (startTime == null) {
       return null;
@@ -155,6 +165,7 @@ public class DefaultCondition implements Condition {
     }
   }
 
+  @Override
   public Long getEndTime() {
     if (endTime == null) {
       return null;
@@ -166,6 +177,7 @@ public class DefaultCondition implements Condition {
     }
   }
 
+  @Override
   public void setNoLimit() {
     this.noLimit = true;
   }
@@ -175,6 +187,7 @@ public class DefaultCondition implements Condition {
     return false;
   }
 
+  @Override
   public Integer getLimit() {
     if (noLimit) {
       return null;
@@ -182,14 +195,17 @@ public class DefaultCondition implements Condition {
     return limit == null ? PhoenixHBaseAccessor.RESULTSET_LIMIT : limit;
   }
 
+  @Override
   public boolean isGrouped() {
     return grouped;
   }
 
+  @Override
   public boolean isPointInTime() {
     return getStartTime() == null && getEndTime() == null;
   }
 
+  @Override
   public boolean isEmpty() {
     return (metricNames == null || metricNames.isEmpty())
       && (hostnames == null || hostnames.isEmpty())
@@ -199,18 +215,22 @@ public class DefaultCondition implements Condition {
       && endTime == null;
   }
 
+  @Override
   public Integer getFetchSize() {
     return fetchSize;
   }
 
+  @Override
   public void setFetchSize(Integer fetchSize) {
     this.fetchSize = fetchSize;
   }
 
+  @Override
   public void addOrderByColumn(String column) {
     orderByColumns.add(column);
   }
 
+  @Override
   public String getOrderByClause(boolean asc) {
     String orderByStr = " ORDER BY ";
     if (!orderByColumns.isEmpty()) {
@@ -296,6 +316,7 @@ public class DefaultCondition implements Condition {
     return false;
   }
 
+  @Override
   public void setMetricNamesNotCondition(boolean metricNamesNotCondition) {
     this.metricNamesNotCondition = metricNamesNotCondition;
   }

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/query/DefaultPhoenixDataSource.java

@@ -62,6 +62,7 @@ public class DefaultPhoenixDataSource implements PhoenixConnectionProvider {
    * @return @HBaseAdmin
    * @throws IOException
    */
+  @Override
   public HBaseAdmin getHBaseAdmin() throws IOException {
     return (HBaseAdmin) ConnectionFactory.createConnection(hbaseConf).getAdmin();
   }
@@ -75,6 +76,7 @@ public class DefaultPhoenixDataSource implements PhoenixConnectionProvider {
    *
    * @return @java.sql.Connection
    */
+  @Override
   public Connection getConnection() throws SQLException {
 
     LOG.debug("Metric store connection url: " + url);

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/query/MetadataQueryCondition.java

@@ -38,6 +38,7 @@ public class MetadataQueryCondition extends TransientMetricCondition {
     isMetricMetadataCondition = false;
   }
 
+  @Override
   public StringBuilder getConditionClause() {
     StringBuilder sb = new StringBuilder();
 

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/upgrade/core/AbstractPhoenixMetricsCopier.java

@@ -49,6 +49,7 @@ public abstract class AbstractPhoenixMetricsCopier implements Runnable {
     this.processedMetricsFile = outputStream;
   }
 
+  @Override
   public void run(){
     LOG.info(String.format("Copying %s metrics from %s to %s", metricNames, inputTable, outputTable));
     long startTimer = System.currentTimeMillis();

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/upgrade/core/MetricsDataMigrationLauncher.java

@@ -306,15 +306,13 @@ public class MetricsDataMigrationLauncher {
     try {
       //Setup shutdown hook for metadata save.
       MetricsDataMigrationLauncher finalDataMigrationLauncher = dataMigrationLauncher;
-      Runtime.getRuntime().addShutdownHook(new Thread() {
-        public void run() {
-          try {
-            finalDataMigrationLauncher.saveMetadata();
-          } catch (SQLException e) {
-            LOG.error("Exception during metadata saving, exiting...", e);
-          }
+      Runtime.getRuntime().addShutdownHook(new Thread(() -> {
+        try {
+          finalDataMigrationLauncher.saveMetadata();
+        } catch (SQLException e) {
+          LOG.error("Exception during metadata saving, exiting...", e);
         }
-      });
+      }));
 
       dataMigrationLauncher.runMigration(timeoutInMinutes);
     } catch (IOException e) {

ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ServiceComponentHostEventWrapper.java

@@ -66,6 +66,7 @@ public class ServiceComponentHostEventWrapper {
     }
   }
   
+  @Override
   public String toString() {
     if (event != null) {
       return event.toString();

ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java

@@ -445,6 +445,7 @@ public class HostInfo {
     return ret.toString();
   }
 
+  @Override
   public String toString() {
     return "[" +
         "hostname=" + this.hostname + "," +

ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultImpl.java

@@ -88,10 +88,12 @@ public class ResultImpl implements Result {
     m_status = status;
   }
 
+  @Override
   public void setResultMetadata(ResultMetadata resultMetadata) {
     m_resultMetadata = resultMetadata;
   }
 
+  @Override
   public ResultMetadata getResultMetadata() {
     return m_resultMetadata;
   }

ambari-server/src/main/java/org/apache/ambari/server/bootstrap/FifoLinkedHashMap.java

@@ -29,6 +29,7 @@ import java.util.Map;
 public class FifoLinkedHashMap<K, V> extends
 LinkedHashMap<K, V> {
   public static final int MAX_ENTRIES = 100;
+  @Override
   protected boolean removeEldestEntry(Map.Entry<K,
       V> eldest) {
     return size() > MAX_ENTRIES;

ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasMigrationPropertyCheck.java

@@ -45,12 +45,17 @@ public class AtlasMigrationPropertyCheck extends AbstractCheckDescriptor {
     /**
      * Default constructor
      */
-    public AtlasMigrationPropertyCheck(){  super(CheckDescription.ATLAS_MIGRATION_PROPERTY_CHECK); }
+    public AtlasMigrationPropertyCheck() {
+        super(CheckDescription.ATLAS_MIGRATION_PROPERTY_CHECK);
+    }
 
     /**
      * {@inheritDoc}
      */
-    public Set<String> getApplicableServices() { return Sets.newHashSet(serviceName); }
+    @Override
+    public Set<String> getApplicableServices() {
+        return Sets.newHashSet(serviceName);
+    }
 
     /**
      * {@inheritDoc}

ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java

@@ -73,6 +73,7 @@ public class CleanupServiceImpl implements CleanupService<TimeBasedCleanupPolicy
    * @param cleanupPolicy the policy based on which the cleanup is done
    * @return the number of affected rows
    */
+  @Override
   public CleanupResult cleanup(TimeBasedCleanupPolicy cleanupPolicy) {
     long affectedRows = 0;
     int errorCount = 0;

ambari-server/src/main/java/org/apache/ambari/server/configuration/SingleFileWatch.java

@@ -89,6 +89,7 @@ public class SingleFileWatch {
     watchdog.interrupt();
   }
 
+  @Override
   public String toString() {
     return "SingleFileWatcher:" + file.getName();
   }

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java

@@ -765,6 +765,7 @@ public class AmbariManagementControllerImpl implements AmbariManagementControlle
   /**
    * {@inheritDoc}
    */
+  @Override
   public TopologyUpdateEvent getAddedComponentsTopologyEvent(Set<ServiceComponentHostRequest> requests)
     throws AmbariException {
     TreeMap<String, TopologyCluster> topologyUpdates = new TreeMap<>();

ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java

@@ -112,6 +112,7 @@ public class HostRequest implements ApiModel {
     return hostGroup;
   }
 
+  @Override
   public String toString() {
     return "{ hostname=" + hostname + ", clusterName=" + clusterName + " }";
   }

ambari-server/src/main/java/org/apache/ambari/server/controller/ShortTaskStatus.java

@@ -142,6 +142,7 @@ public class ShortTaskStatus {
     this.status = status;
   }
 
+  @Override
   public String toString() {
     StringBuilder sb = new StringBuilder();
     sb.append("ShortTaskStatusDump ")

ambari-server/src/main/java/org/apache/ambari/server/controller/ViewPrivilegeRequest.java

@@ -36,6 +36,7 @@ public class ViewPrivilegeRequest extends ViewPrivilegeResponse implements ApiMo
    * Hide privilege id in request body schema
    * @return privilege id
    */
+  @Override
   @ApiModelProperty(name = PrivilegeResourceProvider.PRIVILEGE_ID_PROPERTY_ID, hidden = true)
   public Integer getPrivilegeId() {
     return privilegeId;
@@ -45,6 +46,7 @@ public class ViewPrivilegeRequest extends ViewPrivilegeResponse implements ApiMo
    * Hide permission label in request body schema
    * @return permission label
    */
+  @Override
   @ApiModelProperty(name = PrivilegeResourceProvider.PERMISSION_LABEL_PROPERTY_ID, hidden = true)
   public String getPermissionLabel() {
     return permissionLabel;
@@ -54,6 +56,7 @@ public class ViewPrivilegeRequest extends ViewPrivilegeResponse implements ApiMo
    * Hide view name in request body schema
    * @return view name
    */
+  @Override
   @ApiModelProperty(name = ViewPrivilegeResourceProvider.VIEW_NAME_PROPERTY_ID, hidden = true)
   public String getViewName() {
     return viewName;
@@ -63,6 +66,7 @@ public class ViewPrivilegeRequest extends ViewPrivilegeResponse implements ApiMo
    * Hide view version in request body schema
    * @return view version
    */
+  @Override
   @ApiModelProperty(name = ViewPrivilegeResourceProvider.VERSION_PROPERTY_ID, hidden = true)
   public String getVersion() {
     return version;
@@ -72,6 +76,7 @@ public class ViewPrivilegeRequest extends ViewPrivilegeResponse implements ApiMo
    * Hide view instance name in request body schema
    * @return view instance name
    */
+  @Override
   @ApiModelProperty(name = ViewPrivilegeResourceProvider.INSTANCE_NAME_PROPERTY_ID, hidden = true)
   public String getInstanceName() {
     return instanceName;

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AppCookieManager.java

@@ -196,10 +196,12 @@ public class AppCookieManager {
 
   private static class EmptyJaasCredentials implements Credentials {
 
+    @Override
     public String getPassword() {
       return null;
     }
 
+    @Override
     public Principal getUserPrincipal() {
       return null;
     }

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java

@@ -131,6 +131,7 @@ public class ExtensionLinkResourceProvider extends AbstractControllerResourcePro
     return getRequestStatus(null);
   }
 
+  @Override
   protected RequestStatus deleteResourcesAuthorized(Request request, Predicate predicate)
         throws SystemException, UnsupportedPropertyException,
         NoSuchResourceException, NoSuchParentResourceException {

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java

@@ -299,16 +299,22 @@ public class URLStreamProvider implements StreamProvider {
 
   public static class TrustAllHostnameVerifier implements HostnameVerifier
   {
-    public boolean verify(String hostname, SSLSession session) { return true; }
+    @Override
+    public boolean verify(String hostname, SSLSession session) {
+      return true;
+    }
   }
 
   public static class TrustAllManager implements X509TrustManager
   {
+    @Override
     public X509Certificate[] getAcceptedIssuers()
     {
       return new X509Certificate[0];
     }
+    @Override
     public void checkClientTrusted(X509Certificate[] certs, String authType) {}
+    @Override
     public void checkServerTrusted(X509Certificate[] certs, String authType) {}
   }
 

ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java

@@ -156,6 +156,7 @@ public class LoggingRequestHelperImpl implements LoggingRequestHelper {
     this.logSearchReadTimeoutInMilliseconds = logSearchReadTimeoutInMilliseconds;
   }
 
+  @Override
   public LogQueryResponse sendQueryRequest(Map<String, String> queryParameters) {
     try {
       // use the Apache builder to create the correct URI
@@ -302,6 +303,7 @@ public class LoggingRequestHelperImpl implements LoggingRequestHelper {
     return null;
   }
 
+  @Override
   public HostLogFilesResponse sendGetLogFileNamesRequest(String hostName) {
     try {
       // use the Apache builder to create the correct URI

ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java

@@ -64,6 +64,7 @@ public class AgentConfigsUpdateEvent extends STOMPHostEvent implements Hashable
     return hash;
   }
 
+  @Override
   public void setHash(String hash) {
     this.hash = hash;
   }

ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java

@@ -81,10 +81,12 @@ public class TopologyUpdateEvent extends STOMPEvent implements Hashable {
     return eventType;
   }
 
+  @Override
   public String getHash() {
     return hash;
   }
 
+  @Override
   public void setHash(String hash) {
     this.hash = hash;
   }

ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java

@@ -99,6 +99,7 @@ public class AmbariSNMPDispatcher extends SNMPDispatcher {
      * {@inheritDoc}
      * Uses default Ambari OIDs
      */
+    @Override
     protected PDU prepareTrap(Notification notification, SnmpVersion snmpVersion) throws InvalidSnmpConfigurationException {
         AlertNotification alertNotification;
         PDU pdu = DefaultPDUFactory.createPDU(snmpVersion.getTargetVersion());

ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java

@@ -941,6 +941,7 @@ public class DBAccessorImpl implements DBAccessor {
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedQuery(String query, Object...arguments) throws SQLException {
     executePreparedQuery(query, false, arguments);
   }
@@ -948,6 +949,7 @@ public class DBAccessorImpl implements DBAccessor {
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedQuery(String query, boolean ignoreFailure, Object...arguments) throws SQLException{
     LOG.info("Executing prepared query: {}", query);
 
@@ -973,6 +975,7 @@ public class DBAccessorImpl implements DBAccessor {
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedUpdate(String query, Object...arguments) throws SQLException {
     executePreparedUpdate(query, false, arguments);
   }
@@ -980,6 +983,7 @@ public class DBAccessorImpl implements DBAccessor {
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedUpdate(String query, boolean ignoreFailure, Object...arguments) throws SQLException{
     LOG.info("Executing prepared query: {}", query);
 

ambari-server/src/main/java/org/apache/ambari/server/orm/cache/HostConfigMappingImpl.java

@@ -105,6 +105,8 @@ public class HostConfigMappingImpl implements HostConfigMapping {
       throw new RuntimeException("Version couldn't be null");
     this.version = version;
   }
+
+  @Override
   public String getServiceName() {
     return serviceName;
   }

ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java

@@ -77,6 +77,7 @@ public class AmbariConfigurationDAO extends CrudDAO<AmbariConfigurationEntity, A
   }
 
   @Transactional
+  @Override
   public void create(AmbariConfigurationEntity entity) {
     // make sure only one entry exists per configuration type...
     AmbariConfigurationEntity foundEntity = findByPK(new AmbariConfigurationEntityPK(entity.getCategoryName(), entity.getPropertyName()));

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java

@@ -64,6 +64,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @return configuration type
    */
+  @Override
   public String getType() {
     return type;
   }
@@ -73,6 +74,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @param type  configuration type
    */
+  @Override
   public void setType(String type) {
     this.type = type;
   }
@@ -100,6 +102,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @return blueprint name
    */
+  @Override
   public String getBlueprintName() {
     return blueprintName;
   }
@@ -109,6 +112,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    * '
    * @param blueprintName  blueprint name
    */
+  @Override
   public void setBlueprintName(String blueprintName) {
     this.blueprintName = blueprintName;
   }
@@ -118,6 +122,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @return config data in json format
    */
+  @Override
   public String getConfigData() {
     return configData;
   }
@@ -127,6 +132,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @param configData  all config data in json format
    */
+  @Override
   public void setConfigData(String configData) {
     this.configData = configData;
   }
@@ -136,6 +142,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @return config attributes in JSON format
    */
+  @Override
   public String getConfigAttributes() {
     return configAttributes;
   }
@@ -145,6 +152,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @param configAttributes  all attribute values of configs in JSON format
    */
+  @Override
   public void setConfigAttributes(String configAttributes) {
     this.configAttributes = configAttributes;
   }

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java

@@ -74,6 +74,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @return configuration type
    */
+  @Override
   public String getType() {
     return type;
   }
@@ -83,6 +84,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @param type  configuration type
    */
+  @Override
   public void setType(String type) {
     this.type = type;
   }
@@ -110,6 +112,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @return blueprint name
    */
+  @Override
   public String getBlueprintName() {
     return blueprintName;
   }
@@ -119,6 +122,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    * '
    * @param blueprintName  blueprint name
    */
+  @Override
   public void setBlueprintName(String blueprintName) {
     this.blueprintName = blueprintName;
   }
@@ -146,6 +150,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @return config data in json format
    */
+  @Override
   public String getConfigData() {
     return configData;
   }
@@ -155,6 +160,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @param configData  all config data in json format
    */
+  @Override
   public void setConfigData(String configData) {
     this.configData = configData;
   }
@@ -164,6 +170,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @return config attributes in JSON format
    */
+  @Override
   public String getConfigAttributes() {
     return configAttributes;
   }
@@ -173,6 +180,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @param configAttributes  all attribute values of configs in JSON format
    */
+  @Override
   public void setConfigAttributes(String configAttributes) {
     this.configAttributes = configAttributes;
   }

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/SettingEntity.java

@@ -118,6 +118,7 @@ public class SettingEntity {
     this.updateTimestamp = updateTimestamp;
   }
 
+  @Override
   public SettingEntity clone() {
     SettingEntity cloned = new SettingEntity();
     cloned.setId(id);

ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java

@@ -163,6 +163,7 @@ public class ExecutionScheduleManager {
 
         }
 
+        @Override
         public X509Certificate[] getAcceptedIssuers() {
           return null;
         }

ambari-server/src/main/java/org/apache/ambari/server/security/InternalSSLSocketFactory.java

@@ -99,14 +99,17 @@ public class InternalSSLSocketFactory extends SSLSocketFactory {
    * chain of trust or hostname.
    */
   public static class LenientTrustManager extends X509ExtendedTrustManager implements X509TrustManager {
+    @Override
     public void checkClientTrusted(X509Certificate[] xcs, String string) throws CertificateException {
       // do nothing
     }
 
+    @Override
     public void checkServerTrusted(X509Certificate[] xcs, String string) throws CertificateException {
       // do nothing
     }
 
+    @Override
     public X509Certificate[] getAcceptedIssuers() {
       return new X509Certificate[0];
     }

ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java

@@ -291,12 +291,7 @@ public class AmbariLdapBindAuthenticator extends AbstractLdapAuthenticator {
     String setAmbariAdminAttrFilter = resolveAmbariAdminAttrFilter(ldapServerProperties, memberValue);
     LOG.debug("LDAP login - set admin attr filter: {}", setAmbariAdminAttrFilter);
 
-    AttributesMapper attributesMapper = new AttributesMapper() {
-      public Object mapFromAttributes(Attributes attrs)
-          throws NamingException {
-        return attrs.get(groupNamingAttribute).get();
-      }
-    };
+    AttributesMapper attributesMapper = attrs -> attrs.get(groupNamingAttribute).get();
 
     LdapTemplate ldapTemplate = new LdapTemplate((getContextSource()));
     ldapTemplate.setIgnorePartialResultException(true);

ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java

@@ -1363,19 +1363,17 @@ public class Users {
     addAuthentication(userEntity,
         UserAuthenticationType.JWT,
         key,
-        new Validator() {
-          public void validate(UserEntity userEntity, String key) throws AmbariException {
-            List<UserAuthenticationEntity> authenticationEntities = userEntity.getAuthenticationEntities();
-
-            // Ensure only one UserAuthenticationEntity exists for JWT for the user...
-            for (UserAuthenticationEntity entity : authenticationEntities) {
-              if ((entity.getAuthenticationType() == UserAuthenticationType.JWT) &&
-                  ((key == null) ? (entity.getAuthenticationKey() == null) : key.equals(entity.getAuthenticationKey()))) {
-                throw new AmbariException("The authentication type already exists for this user");
+            (user, authKey) -> {
+              List<UserAuthenticationEntity> authenticationEntities = user.getAuthenticationEntities();
+
+              // Ensure only one UserAuthenticationEntity exists for JWT for the user...
+              for (UserAuthenticationEntity entity : authenticationEntities) {
+                if ((entity.getAuthenticationType() == UserAuthenticationType.JWT) &&
+                    ((authKey == null) ? (entity.getAuthenticationKey() == null) : authKey.equals(entity.getAuthenticationKey()))) {
+                  throw new AmbariException("The authentication type already exists for this user");
+                }
               }
-            }
-          }
-        },
+            },
         persist);
   }
 
@@ -1405,14 +1403,12 @@ public class Users {
     addAuthentication(userEntity,
         UserAuthenticationType.KERBEROS,
         principalName,
-        new Validator() {
-          public void validate(UserEntity userEntity, String key) throws AmbariException {
-            // Ensure no other authentication entries exist for the same principal...
-            if (!CollectionUtils.isEmpty(userAuthenticationDAO.findByTypeAndKey(UserAuthenticationType.KERBEROS, key))) {
-              throw new AmbariException("The authentication type already exists for this principal");
-            }
-          }
-        },
+            (user, key) -> {
+              // Ensure no other authentication entries exist for the same principal...
+              if (!CollectionUtils.isEmpty(userAuthenticationDAO.findByTypeAndKey(UserAuthenticationType.KERBEROS, key))) {
+                throw new AmbariException("The authentication type already exists for this principal");
+              }
+            },
         persist);
   }
 
@@ -1453,18 +1449,16 @@ public class Users {
     addAuthentication(userEntity,
         UserAuthenticationType.LOCAL,
         encodedPassword,
-        new Validator() {
-          public void validate(UserEntity userEntity, String key) throws AmbariException {
-            List<UserAuthenticationEntity> authenticationEntities = userEntity.getAuthenticationEntities();
-
-            // Ensure only one UserAuthenticationEntity exists for LOCAL for the user...
-            for (UserAuthenticationEntity entity : authenticationEntities) {
-              if (entity.getAuthenticationType() == UserAuthenticationType.LOCAL) {
-                throw new AmbariException("The authentication type already exists for this user");
+            (user, key) -> {
+              List<UserAuthenticationEntity> authenticationEntities = user.getAuthenticationEntities();
+
+              // Ensure only one UserAuthenticationEntity exists for LOCAL for the user...
+              for (UserAuthenticationEntity entity : authenticationEntities) {
+                if (entity.getAuthenticationType() == UserAuthenticationType.LOCAL) {
+                  throw new AmbariException("The authentication type already exists for this user");
+                }
               }
-            }
-          }
-        },
+            },
         persist);
   }
 
@@ -1494,18 +1488,16 @@ public class Users {
     addAuthentication(userEntity,
         UserAuthenticationType.PAM,
         userName,
-        new Validator() {
-          public void validate(UserEntity userEntity, String key) throws AmbariException {
-            List<UserAuthenticationEntity> authenticationEntities = userEntity.getAuthenticationEntities();
-
-            // Ensure only one UserAuthenticationEntity exists for PAM for the user...
-            for (UserAuthenticationEntity entity : authenticationEntities) {
-              if (entity.getAuthenticationType() == UserAuthenticationType.PAM) {
-                throw new AmbariException("The authentication type already exists for this user");
+            (user, key) -> {
+              List<UserAuthenticationEntity> authenticationEntities = user.getAuthenticationEntities();
+
+              // Ensure only one UserAuthenticationEntity exists for PAM for the user...
+              for (UserAuthenticationEntity entity : authenticationEntities) {
+                if (entity.getAuthenticationType() == UserAuthenticationType.PAM) {
+                  throw new AmbariException("The authentication type already exists for this user");
+                }
               }
-            }
-          }
-        },
+            },
         persist);
   }
 
@@ -1535,19 +1527,17 @@ public class Users {
     addAuthentication(userEntity,
         UserAuthenticationType.LDAP,
         StringUtils.lowerCase(dn), // DNs are case-insensitive and are stored internally as the bytes of lowercase characters
-        new Validator() {
-          public void validate(UserEntity userEntity, String key) throws AmbariException {
-            List<UserAuthenticationEntity> authenticationEntities = userEntity.getAuthenticationEntities();
-
-            // Ensure only one UserAuthenticationEntity exists for LDAP for the user...
-            for (UserAuthenticationEntity entity : authenticationEntities) {
-              if ((entity.getAuthenticationType() == UserAuthenticationType.LDAP) &&
-                  ((key == null) ? (entity.getAuthenticationKey() == null) : key.equalsIgnoreCase(entity.getAuthenticationKey()))) {
-                throw new AmbariException("The authentication type already exists for this user");
+            (user, key) -> {
+              List<UserAuthenticationEntity> authenticationEntities = user.getAuthenticationEntities();
+
+              // Ensure only one UserAuthenticationEntity exists for LDAP for the user...
+              for (UserAuthenticationEntity entity : authenticationEntities) {
+                if ((entity.getAuthenticationType() == UserAuthenticationType.LDAP) &&
+                    ((key == null) ? (entity.getAuthenticationKey() == null) : key.equalsIgnoreCase(entity.getAuthenticationKey()))) {
+                  throw new AmbariException("The authentication type already exists for this user");
+                }
               }
-            }
-          }
-        },
+            },
         persist);
   }
 

ambari-server/src/main/java/org/apache/ambari/server/security/credential/GenericKeyCredential.java

@@ -63,6 +63,7 @@ public class GenericKeyCredential implements Credential {
    *
    * @return a String containing the value representation of this GenericKeyCredential
    */
+  @Override
   public char[] toValue() {
     return this.key;
   }

ambari-server/src/main/java/org/apache/ambari/server/security/credential/PrincipalKeyCredential.java

@@ -101,6 +101,7 @@ public class PrincipalKeyCredential implements Credential {
    *
    * @return a String containing the value representation of this PrincipalKeyCredential
    */
+  @Override
   public char[] toValue() {
     StringBuilder builder = new StringBuilder();
     builder.append("PrincipalKeyCredential");

ambari-server/src/main/java/org/apache/ambari/server/stack/BaseModule.java

@@ -45,6 +45,7 @@ public abstract class BaseModule<T, I> implements StackDefinitionModule<T, I> {
    *
    * @return the module's state
    */
+  @Override
   public ModuleState getModuleState() {
     return moduleState;
   }

ambari-server/src/main/java/org/apache/ambari/server/state/action/ActionId.java

@@ -31,6 +31,7 @@ public class ActionId {
     this.actionType = actionType;
   }
 
+  @Override
   public String toString() {
     return "[ actionId=" + actionId
         + ", actionType=" + actionType + "]";

ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java

@@ -595,6 +595,7 @@ public class ClusterImpl implements Cluster {
     return serviceComponentHosts.get(serviceName).get(serviceComponentName).get(hostname);
   }
 
+  @Override
   public List<ServiceComponentHost> getServiceComponentHosts() {
     List<ServiceComponentHost> serviceComponentHosts = new ArrayList<>();
     if (!serviceComponentHostsByHost.isEmpty()) {
@@ -2712,6 +2713,7 @@ public class ClusterImpl implements Cluster {
    *
    * @return
    */
+  @Override
   public ClusterEntity getClusterEntity() {
     return clusterDAO.findById(clusterId);
   }

ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java

@@ -903,10 +903,12 @@ public class HostImpl implements Host {
     this.lastHeartbeatTime = lastHeartbeatTime;
   }
 
+  @Override
   public long getLastAgentStartTime() {
     return lastAgentStartTime;
   }
 
+  @Override
   public void setLastAgentStartTime(long lastAgentStartTime) {
     this.lastAgentStartTime = lastAgentStartTime;
   }

ambari-server/src/main/java/org/apache/ambari/server/state/host/HostStatusUpdatesReceivedEvent.java

@@ -36,6 +36,7 @@ public class HostStatusUpdatesReceivedEvent extends HostEvent {
   /**
    * @return the timestamp
    */
+  @Override
   public long getTimestamp() {
     return timestamp;
   }

ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java

@@ -534,6 +534,7 @@ public abstract class AbstractKerberosDescriptorContainer extends AbstractKerber
    *
    * @return true if this AbstractKerberosDescriptor is a container, false otherwise
    */
+  @Override
   public boolean isContainer() {
     return true;
   }

ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/DefaultQuickLinkVisibilityController.java

@@ -116,6 +116,7 @@ public class DefaultQuickLinkVisibilityController implements QuickLinkVisibility
    * @param quickLink the quicklink
    * @return a boolean indicating whether the link in the parameter should be visible
    */
+  @Override
   public boolean isVisible(@Nonnull String service, @Nonnull Link quickLink) {
     // First, component rules are evaluated if exist and applicable
     Optional<Boolean> componentResult = evaluateComponentRules(service, quickLink);

ambari-server/src/main/java/org/apache/ambari/server/state/stack/MetricDefinition.java

@@ -72,6 +72,7 @@ public class MetricDefinition {
     return metricMap;
   }
   
+  @Override
   public String toString() {
     StringBuilder sb = new StringBuilder();
     sb.append("{type=").append(type);

ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java

@@ -104,6 +104,7 @@ public class BlueprintImpl implements Blueprint {
     this.setting = setting;
   }
 
+  @Override
   public String getName() {
     return name;
   }
@@ -116,6 +117,7 @@ public class BlueprintImpl implements Blueprint {
     return stack.getVersion();
   }
 
+  @Override
   public SecurityConfiguration getSecurity() {
     return security;
   }
@@ -332,6 +334,7 @@ public class BlueprintImpl implements Blueprint {
     validator.validateTopology();
   }
 
+  @Override
   public BlueprintEntity toEntity() {
 
     BlueprintEntity entity = new BlueprintEntity();
@@ -619,6 +622,7 @@ public class BlueprintImpl implements Blueprint {
   /**
    * A config type is valid if there are services related to except cluster-env and global.
    */
+  @Override
   public boolean isValidConfigType(String configType) {
     if (ConfigHelper.CLUSTER_ENV.equals(configType) || "global".equals(configType)) {
       return true;
@@ -650,6 +654,7 @@ public class BlueprintImpl implements Blueprint {
     return result;
   }
 
+  @Override
   public List<RepositorySetting> getRepositorySettings(){
     return repoSettings;
   }

ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupImpl.java

@@ -168,6 +168,7 @@ public class HostGroupImpl implements HostGroup {
    *
    * @return true if component was added; false if component already existed
    */
+  @Override
   public boolean addComponent(String component, ProvisionAction provisionAction) {
     boolean added;
     if (!components.containsKey(component)) {
@@ -285,6 +286,8 @@ public class HostGroupImpl implements HostGroup {
     Map<String, Map<String, Map<String, String>>> attributes = new HashMap<>();
     configuration = new Configuration(config, attributes);
   }
+
+  @Override
   public String toString(){
        return  name;
   }

ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java

@@ -105,6 +105,7 @@ public class RepositorySetting {
     this.baseUrl = baseUrl;
   }
 
+  @Override
   public String toString(){
     StringBuilder strBldr = new StringBuilder();
     strBldr.append(OVERRIDE_STRATEGY);strBldr.append(": ");strBldr.append(overrideStrategy);

ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/TopologyHostTask.java

@@ -46,6 +46,7 @@ public abstract class TopologyHostTask implements TopologyTask {
   /**
    * Run with an InternalAuthenticationToken as when running these tasks we might not have any active security context.
    */
+  @Override
   public void run() {
     Authentication savedAuthContext = SecurityContextHolder.getContext().getAuthentication();
     try {

ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java

@@ -46,6 +46,7 @@ public class RequiredPasswordValidator implements TopologyValidator {
    * @throws InvalidTopologyException if required password properties are missing and no
    *                                  default is specified via 'default_password'
    */
+  @Override
   public void validate(ClusterTopology topology) throws InvalidTopologyException {
 
     defaultPassword = topology.getDefaultPassword();

ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java

@@ -289,6 +289,7 @@ public abstract class AbstractUpgradeCatalog implements UpgradeCatalog {
   /**
    * {@inheritDoc}
    */
+  @Override
   public Map<String,String> getUpgradeJsonOutput() {
     return upgradeJsonOutput;
   }

ambari-server/src/main/java/org/apache/ambari/server/utils/ManagedThreadPoolExecutor.java

@@ -42,6 +42,7 @@ public class ManagedThreadPoolExecutor extends ThreadPoolExecutor {
     isStopped = true;
   }
 
+  @Override
   protected void beforeExecute(Thread t, Runnable r) {
     super.beforeExecute(t, r);
     pauseLock.lock();

ambari-server/src/main/java/org/apache/ambari/server/utils/ScheduledExecutorCompletionService.java

@@ -35,7 +35,10 @@ public class ScheduledExecutorCompletionService<V> extends ExecutorCompletionSer
       super(task, null);
       this.task = task;
     }
-    protected void done() { queue.add(task); }
+    @Override
+    protected void done() {
+      queue.add(task);
+    }
     private final Future<V> task;
   }
 

ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java

@@ -88,6 +88,7 @@ public class ViewDirectoryWatcher implements DirectoryWatcher {
     };
   }
 
+  @Override
   public void start() {
 
     try {

ambari-server/src/main/java/org/apache/ambari/server/view/events/EventImpl.java

@@ -92,6 +92,7 @@ public class EventImpl implements Event {
    *
    * @return the id
    */
+  @Override
   public String getId() {
     return id;
   }
@@ -101,6 +102,7 @@ public class EventImpl implements Event {
    *
    * @return the properties
    */
+  @Override
   public Map<String, String> getProperties() {
     return properties;
   }
@@ -110,6 +112,7 @@ public class EventImpl implements Event {
    *
    * @return the view subject
    */
+  @Override
   public ViewDefinition getViewSubject() {
     return viewSubject;
   }
@@ -119,6 +122,7 @@ public class EventImpl implements Event {
    *
    * @return the instance subject; null if this is a view level event
    */
+  @Override
   public ViewInstanceDefinition getViewInstanceSubject() {
     return viewInstanceSubject;
   }

ambari-utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java

@@ -253,6 +253,7 @@ public class AmbariSwaggerReader extends JaxrsReader {
 }
 
 class ParameterToName implements Function<Parameter, String> {
+  @Override
   public String apply(Parameter input) {
     return input.getName();
   }