AMBARI-14770 Config page has half shown button. (atkach)

ambari-web/app/views/common/configs/config_history_flow.js

@@ -91,6 +91,7 @@ App.ConfigHistoryFlowView = Em.View.extend({
     var groupName = this.get('controller.selectedConfigGroup.isDefault') ? 'default'
         : this.get('controller.selectedConfigGroup.name');
     var groupId = this.get('controller.selectedConfigGroup.configGroupId');
+    var self = this;
 
     this.get('allServiceVersions').forEach(function (version) {
       version.set('isDisabled', !(version.get('groupName') === groupName));
@@ -100,6 +101,13 @@ App.ConfigHistoryFlowView = Em.View.extend({
       return (s.get('groupId') === groupId) || s.get('groupName') == 'default';
     });
 
+    if (!serviceVersions.findProperty('isDisplayed')) {
+      //recompute serviceVersions if displayed version absent
+      Em.run.next(function() {
+        self.propertyDidChange('controller.selectedConfigGroup.name');
+      });
+    }
+
     return serviceVersions.sort(function (a, b) {
       return Em.get(b, 'createTime') - Em.get(a, 'createTime');
     });

ambari-web/app/views/common/quick_view_link_view.js

@@ -512,6 +512,9 @@ App.QuickViewLinks = Em.View.extend({
         publicHostName: App.get('singleNodeAlias')
       }];
     }
+    if (Em.isNone(this.get('content.hostComponents'))) {
+      return [];
+    }
     var hosts = [];
     switch (serviceName) {
       case 'OOZIE':

ambari-web/app/views/main/service/info/summary.js

@@ -163,19 +163,22 @@ App.MainServiceInfoSummaryView = Em.View.extend(App.UserPref, App.TimeRangeMixin
 
   setComponentsContent: function() {
     Em.run.next(function() {
-      var masters = this.get('service.hostComponents').filterProperty('isMaster');
+      if (Em.isNone(this.get('service'))) {
+        return;
+      }
+      var masters = this.get('service.masterComponents').toArray();
       var slaves = this.get('service.slaveComponents').toArray();
       var clients = this.get('service.clientComponents').toArray();
 
-      if (this.get('mastersLength') != masters.length) {
+      if (this.get('mastersLength') !== masters.length) {
         this.updateComponentList(this.get('mastersObj'), masters);
         this.set('mastersLength', masters.length);
       }
-      if (this.get('slavesLength') != slaves.length) {
+      if (this.get('slavesLength') !== slaves.length) {
         this.updateComponentList(this.get('slavesObj'), slaves);
         this.set('slavesLength', slaves.length);
       }
-      if (this.get('clientsLength') != clients.length) {
+      if (this.get('clientsLength') !== clients.length) {
         this.updateComponentList(this.get('clientObj'), clients);
         this.set('clientsLength', clients.length);
       }

ambari-web/test/views/common/quick_link_view_test.js

@@ -853,7 +853,7 @@ describe('App.QuickViewLinks', function () {
             {
               'type': 'yarn-site',
               'properties': {'yarn.timeline-service.webapp.https.address': 'c6401.ambari.apache.org:8090'}
-            },
+            }
           ],
         'result': '8090'
       })
@@ -871,4 +871,96 @@ describe('App.QuickViewLinks', function () {
     }, this);
   });
 
+  describe("#getHosts()", function() {
+
+    beforeEach(function() {
+      sinon.stub(quickViewLinks, 'processOozieHosts').returns(['oozieHost']);
+      sinon.stub(quickViewLinks, 'processHdfsHosts').returns(['hdfsHost']);
+      sinon.stub(quickViewLinks, 'processHbaseHosts').returns(['hbaseHost']);
+      sinon.stub(quickViewLinks, 'processYarnHosts').returns(['yarnHost']);
+      sinon.stub(quickViewLinks, 'findHosts').returns(['host1']);
+      App.set('singleNodeInstall', false);
+      quickViewLinks.set('content', Em.Object.create({
+        hostComponents: []
+      }));
+    });
+    afterEach(function() {
+      quickViewLinks.processOozieHosts.restore();
+      quickViewLinks.processHdfsHosts.restore();
+      quickViewLinks.processHbaseHosts.restore();
+      quickViewLinks.findHosts.restore();
+      quickViewLinks.processYarnHosts.restore();
+    });
+
+    it("singleNodeInstall is true", function() {
+      App.set('singleNodeInstall', true);
+      App.set('singleNodeAlias', 'host1');
+      expect(quickViewLinks.getHosts({}, 'S1')).to.eql([{
+        hostName: 'host1',
+        publicHostName: 'host1'
+      }])
+    });
+
+    it("content is null", function() {
+      quickViewLinks.set('content', null);
+      expect(quickViewLinks.getHosts({}, 'S1')).to.be.empty;
+    });
+
+    it("OOZIE service", function() {
+      expect(quickViewLinks.getHosts({}, 'OOZIE')).to.eql(['oozieHost']);
+      expect(quickViewLinks.findHosts.calledWith('OOZIE_SERVER', {})).to.be.true;
+      expect(quickViewLinks.processOozieHosts.calledOnce).to.be.true;
+    });
+
+    it("HDFS service", function() {
+      expect(quickViewLinks.getHosts({}, 'HDFS')).to.eql(['hdfsHost']);
+      expect(quickViewLinks.findHosts.calledWith('NAMENODE', {})).to.be.true;
+      expect(quickViewLinks.processHdfsHosts.calledOnce).to.be.true;
+    });
+
+    it("HBASE service", function() {
+      expect(quickViewLinks.getHosts({}, 'HBASE')).to.eql(['hbaseHost']);
+      expect(quickViewLinks.findHosts.calledWith('HBASE_MASTER', {})).to.be.true;
+      expect(quickViewLinks.processHbaseHosts.calledOnce).to.be.true;
+    });
+
+    it("YARN service", function() {
+      expect(quickViewLinks.getHosts({}, 'YARN')).to.eql(['yarnHost']);
+      expect(quickViewLinks.findHosts.calledWith('RESOURCEMANAGER', {})).to.be.true;
+      expect(quickViewLinks.processYarnHosts.calledOnce).to.be.true;
+    });
+
+    it("STORM service", function() {
+      expect(quickViewLinks.getHosts({}, 'STORM')).to.eql(['host1']);
+      expect(quickViewLinks.findHosts.calledWith('STORM_UI_SERVER', {})).to.be.true;
+    });
+
+    it("ACCUMULO service", function() {
+      expect(quickViewLinks.getHosts({}, 'ACCUMULO')).to.eql(['host1']);
+      expect(quickViewLinks.findHosts.calledWith('ACCUMULO_MONITOR', {})).to.be.true;
+    });
+
+    it("ATLAS service", function() {
+      expect(quickViewLinks.getHosts({}, 'ATLAS')).to.eql(['host1']);
+      expect(quickViewLinks.findHosts.calledWith('ATLAS_SERVER', {})).to.be.true;
+    });
+
+    it("custom service without master", function() {
+      expect(quickViewLinks.getHosts({}, 'S1')).to.be.empty;
+    });
+
+    it("custom service with master", function() {
+      quickViewLinks.set('content', Em.Object.create({
+        hostComponents: [
+          Em.Object.create({
+            isMaster: true,
+            componentName: 'C1'
+          })
+        ]
+      }));
+      expect(quickViewLinks.getHosts({}, 'S1')).to.eql(['host1']);
+      expect(quickViewLinks.findHosts.calledWith('C1', {})).to.be.true;
+    });
+  });
+
 });

ambari-web/test/views/main/service/info/summary_test.js

@@ -524,4 +524,60 @@ describe('App.MainServiceInfoSummaryView', function() {
 
   });
 
+  describe("#setComponentsContent()", function() {
+
+    beforeEach(function() {
+      sinon.stub(Em.run, 'next', Em.clb);
+      sinon.stub(view, 'updateComponentList');
+      view.set('service', Em.Object.create({
+        masterComponents: [],
+        slaveComponents: [],
+        clientComponents: []
+      }));
+      view.setProperties({
+        mastersLength: 0,
+        slavesLength: 0,
+        clientsLength: 0,
+        mastersObj: ['master'],
+        slavesObj: ['slave'],
+        clientObj: ['client']
+      });
+    });
+    afterEach(function() {
+      Em.run.next.restore();
+      view.updateComponentList.restore();
+    });
+
+    it("service is null", function() {
+      view.set('service', null);
+      view.setComponentsContent();
+      expect(Em.run.next.calledOnce).to.be.true;
+      expect(view.updateComponentList.called).to.be.false
+    });
+
+    it("update master length", function() {
+      view.set('mastersLength', 1);
+      view.setComponentsContent();
+      expect(Em.run.next.calledOnce).to.be.true;
+      expect(view.updateComponentList.calledWith(['master'], [])).to.be.true;
+      expect(view.get('mastersLength')).to.be.equal(0);
+    });
+
+    it("update slave length", function() {
+      view.set('slavesLength', 1);
+      view.setComponentsContent();
+      expect(Em.run.next.calledOnce).to.be.true;
+      expect(view.updateComponentList.calledWith(['slave'], [])).to.be.true;
+      expect(view.get('slavesLength')).to.be.equal(0);
+    });
+
+    it("update client length", function() {
+      view.set('clientsLength', 1);
+      view.setComponentsContent();
+      expect(Em.run.next.calledOnce).to.be.true;
+      expect(view.updateComponentList.calledWith(['client'], [])).to.be.true;
+      expect(view.get('clientsLength')).be.equal(0);
+    });
+  });
+
 });